Re: [Xen-devel] [PATCH] tmem: default to off
On Wed, Jan 09, 2019 at 05:16:17PM +, Wei Liu wrote: > On Wed, Jan 09, 2019 at 02:05:19AM -0700, Jan Beulich wrote: > > As a short term alternative to deleting the code, default its building > > to off (overridable in EXPERT mode only). Additionally make sure other > > related baggage (LZO code) won't be carried when the option is off (with > > TMEM scheduled to be deleted anyway, I didn't want to introduce a > > separate Kconfig option to control the LZO compression code, and hence > > CONFIG_TMEM is used directly there). Similarly I couldn't be bothered to > > add actual content to the command line option doc for the two affected > > options. > > > > Signed-off-by: Jan Beulich > > Acked-by: Wei Liu Acked-by: Konrad Rzeszutek Wilk Thank you! ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] tmem: default to off
On Wed, Jan 09, 2019 at 02:05:19AM -0700, Jan Beulich wrote: > As a short term alternative to deleting the code, default its building > to off (overridable in EXPERT mode only). Additionally make sure other > related baggage (LZO code) won't be carried when the option is off (with > TMEM scheduled to be deleted anyway, I didn't want to introduce a > separate Kconfig option to control the LZO compression code, and hence > CONFIG_TMEM is used directly there). Similarly I couldn't be bothered to > add actual content to the command line option doc for the two affected > options. > > Signed-off-by: Jan Beulich Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] tmem: default to off
On Wed, Jan 9, 2019 at 4:28 PM Jan Beulich wrote: > > >>> On 09.01.19 at 16:02, wrote: > > From: Xen-devel on behalf of Jan > > Beulich > > : > > --- a/xen/common/Makefile > > +++ b/xen/common/Makefile > > @@ -21,7 +21,7 @@ obj-$(CONFIG_KEXEC) += kimage.o > > obj-y += lib.o > > obj-$(CONFIG_NEEDS_LIST_SORT) += list_sort.o > > obj-$(CONFIG_LIVEPATCH) += livepatch.o livepatch_elf.o > > -obj-y += lzo.o > > +obj-$(CONFIG_TMEM) += lzo.o > > > > Here you completely disable the build of lzo if tmem is not enabled. > > > > obj-$(CONFIG_MEM_ACCESS) += mem_access.o > > obj-y += memory.o > > obj-y += monitor.o > > @@ -66,8 +66,9 @@ obj-bin-y += warning.init.o > > obj-$(CONFIG_XENOPROF) += xenoprof.o > > obj-y += xmalloc_tlsf.o > > > > -obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma unlzo > > unlz4 earlycpio,$(n).init.o) > > - > > +lzo-y := lzo > > +lzo-$(CONFIG_TMEM) := > > +obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma > > $(lzo-y) unlzo unlz4 earlycpio,$(n).init.o) > > > > Here however you always build unlzo.c, which AFAICT makes use of the > > lzo1x_decompress_safe function that's defined in lzo.c. > > Note the (new) definition and use of lzo-y, so together with unlzo.init.o > lzo.init.o will also be built. (I can assure you that I did test with TMEM > enabled and disabled.) Oh sorry, missed it. That makes the lzo parts need when not using tmem be placed (and checked) to be in the init section. Reviewed-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] tmem: default to off
>>> On 09.01.19 at 16:02, wrote: > From: Xen-devel on behalf of Jan > Beulich > : > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -21,7 +21,7 @@ obj-$(CONFIG_KEXEC) += kimage.o > obj-y += lib.o > obj-$(CONFIG_NEEDS_LIST_SORT) += list_sort.o > obj-$(CONFIG_LIVEPATCH) += livepatch.o livepatch_elf.o > -obj-y += lzo.o > +obj-$(CONFIG_TMEM) += lzo.o > > Here you completely disable the build of lzo if tmem is not enabled. > > obj-$(CONFIG_MEM_ACCESS) += mem_access.o > obj-y += memory.o > obj-y += monitor.o > @@ -66,8 +66,9 @@ obj-bin-y += warning.init.o > obj-$(CONFIG_XENOPROF) += xenoprof.o > obj-y += xmalloc_tlsf.o > > -obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma unlzo > unlz4 earlycpio,$(n).init.o) > - > +lzo-y := lzo > +lzo-$(CONFIG_TMEM) := > +obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma $(lzo-y) > unlzo unlz4 earlycpio,$(n).init.o) > > Here however you always build unlzo.c, which AFAICT makes use of the > lzo1x_decompress_safe function that's defined in lzo.c. Note the (new) definition and use of lzo-y, so together with unlzo.init.o lzo.init.o will also be built. (I can assure you that I did test with TMEM enabled and disabled.) Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] tmem: default to off
Sorry for the wrong formatting. From: Xen-devel on behalf of Jan Beulich : --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -21,7 +21,7 @@ obj-$(CONFIG_KEXEC) += kimage.o obj-y += lib.o obj-$(CONFIG_NEEDS_LIST_SORT) += list_sort.o obj-$(CONFIG_LIVEPATCH) += livepatch.o livepatch_elf.o -obj-y += lzo.o +obj-$(CONFIG_TMEM) += lzo.o Here you completely disable the build of lzo if tmem is not enabled. obj-$(CONFIG_MEM_ACCESS) += mem_access.o obj-y += memory.o obj-y += monitor.o @@ -66,8 +66,9 @@ obj-bin-y += warning.init.o obj-$(CONFIG_XENOPROF) += xenoprof.o obj-y += xmalloc_tlsf.o -obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma unlzo unlz4 earlycpio,$(n).init.o) - +lzo-y := lzo +lzo-$(CONFIG_TMEM) := +obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma $(lzo-y) unlzo unlz4 earlycpio,$(n).init.o) Here however you always build unlzo.c, which AFAICT makes use of the lzo1x_decompress_safe function that's defined in lzo.c. Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] tmem: default to off
On 09/01/2019 10:05, Jan Beulich wrote: > As a short term alternative to deleting the code, default its building > to off (overridable in EXPERT mode only). Additionally make sure other > related baggage (LZO code) won't be carried when the option is off (with > TMEM scheduled to be deleted anyway, I didn't want to introduce a > separate Kconfig option to control the LZO compression code, and hence > CONFIG_TMEM is used directly there). Similarly I couldn't be bothered to > add actual content to the command line option doc for the two affected > options. > > Signed-off-by: Jan Beulich > --- > While not posted previously, this is meant to be considered a > replacement for the TMEM removal patch, which was posted in time. I > therefore would like to see this allowed in for 4.12. Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
