Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-09 Thread Wei Liu
On Fri, Mar 09, 2018 at 12:08:42PM +0100, Olaf Hering wrote: > On Fri, Mar 09, Olaf Hering wrote: > > > abuild@latitude:~> readelf -Wa /usr/lib64/libpython2.7.so | grep dlsym > > 003e5e08 00d90007 R_X86_64_JUMP_SLOT > > dlsym@GLIBC_2.2.5 + 0 > >217:

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-09 Thread Olaf Hering
On Fri, Mar 09, Olaf Hering wrote: > abuild@latitude:~> readelf -Wa /usr/lib64/libpython2.7.so | grep dlsym > 003e5e08 00d90007 R_X86_64_JUMP_SLOT > dlsym@GLIBC_2.2.5 + 0 >217: 0 FUNCGLOBAL DEFAULT UND dlsym@GLIBC_2.2.5 > (10)

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-09 Thread Olaf Hering
On Fri, Mar 09, Juergen Gross wrote: > So how does this work? No idea, at least this output differs: abuild@latitude:~> readelf -Wa /usr/lib64/libpython2.7.so | grep dlsym 003e5e08 00d90007 R_X86_64_JUMP_SLOT dlsym@GLIBC_2.2.5 + 0 217:

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-09 Thread Juergen Gross
On 09/03/18 09:36, Olaf Hering wrote: > On Wed, Mar 07, Juergen Gross wrote: > >> On 07/03/18 13:06, ian.jack...@citrix.com wrote: >>> Juergen Gross writes ("Re: [PATCH] tools/xenstore: add libdl dependency to >>> libxenstore"): On 07/03/18 12:19, Ian Jackson wrote: > Juergen Gross

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-09 Thread Olaf Hering
On Wed, Mar 07, Juergen Gross wrote: > On 07/03/18 13:06, ian.jack...@citrix.com wrote: > > Juergen Gross writes ("Re: [PATCH] tools/xenstore: add libdl dependency to > > libxenstore"): > >> On 07/03/18 12:19, Ian Jackson wrote: > >>> Juergen Gross writes ("[PATCH] tools/xenstore: add libdl

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Juergen Gross
On 07/03/18 13:06, ian.jack...@citrix.com wrote: > Juergen Gross writes ("Re: [PATCH] tools/xenstore: add libdl dependency to > libxenstore"): >> On 07/03/18 12:19, Ian Jackson wrote: >>> Juergen Gross writes ("[PATCH] tools/xenstore: add libdl dependency to >>> libxenstore"):

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread ian.jackson
Juergen Gross writes ("Re: [PATCH] tools/xenstore: add libdl dependency to libxenstore"): > On 07/03/18 12:19, Ian Jackson wrote: > > Juergen Gross writes ("[PATCH] tools/xenstore: add libdl dependency to > > libxenstore"): > >> libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl > >> +else > >>

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Juergen Gross
On 07/03/18 12:19, Ian Jackson wrote: > Juergen Gross writes ("[PATCH] tools/xenstore: add libdl dependency to > libxenstore"): >> libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl >> +else >> +PKG_CONFIG_REMOVE += dl > > What is this ? -ldl is needed on Linux only, but I didn't want to add a

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Wei Liu
On Wed, Mar 07, 2018 at 12:01:25PM +0100, Juergen Gross wrote: > On 07/03/18 11:17, Juergen Gross wrote: > > Commit 448c03b3cbe14873ee63 ("tools/xenstore: try to get minimum thread > > stack size for watch thread") added a dependency to libdl to > > libxenstore. > > > > Add the needed flags to

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Juergen Gross
On 07/03/18 11:17, Juergen Gross wrote: > Commit 448c03b3cbe14873ee63 ("tools/xenstore: try to get minimum thread > stack size for watch thread") added a dependency to libdl to > libxenstore. > > Add the needed flags to LDLIBS_libxenstore and the pkg-config file of > libxenstore. > > Fixes:

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Wei Liu
On Wed, Mar 07, 2018 at 11:17:44AM +0100, Juergen Gross wrote: > Commit 448c03b3cbe14873ee63 ("tools/xenstore: try to get minimum thread > stack size for watch thread") added a dependency to libdl to > libxenstore. > > Add the needed flags to LDLIBS_libxenstore and the pkg-config file of >