>>> On 10.12.18 at 15:57, wrote:
>> From: Paul Durrant
>> Sent: 10 December 2018 14:57
>>
>> > From: Jan Beulich [mailto:jbeul...@suse.com]
>> > Sent: 10 December 2018 13:44
>> >
>> > >>> On 07.12.18 at 18:50, wrote:
>> > > The code in viridian_synic_wrmsr() duplicates logic in
>> >
> -Original Message-
> From: Paul Durrant
> Sent: 10 December 2018 14:57
> To: 'Jan Beulich'
> Cc: Andrew Cooper ; Roger Pau Monne
> ; Wei Liu ; xen-devel de...@lists.xenproject.org>
> Subject: RE: [PATCH] x86/hvm/viridian: stop open coding updates to APIC
> registers
>
> >
> -Original Message-
> From: Jan Beulich [mailto:jbeul...@suse.com]
> Sent: 10 December 2018 13:44
> To: Paul Durrant
> Cc: Andrew Cooper ; Roger Pau Monne
> ; Wei Liu ; xen-devel de...@lists.xenproject.org>
> Subject: Re: [PATCH] x86/hvm/viridian: stop open coding updates to APIC
>
>>> On 07.12.18 at 18:50, wrote:
> The code in viridian_synic_wrmsr() duplicates logic in vlapic_reg_write()
> to update the ICR, ICR2 and TASKPRI registers. Instead of doing this,
> make vlapic_reg_write() non-static and call it.
There's a side effect from this change, which I think should be
> -Original Message-
> From: Andrew Cooper
> Sent: 10 December 2018 11:04
> To: Paul Durrant ; xen-devel@lists.xenproject.org
> Cc: Jan Beulich ; Wei Liu ; Roger
> Pau Monne
> Subject: Re: [PATCH] x86/hvm/viridian: stop open coding updates to APIC
> registers
>
> On 08/12/2018 11:34,
On 08/12/2018 11:34, Paul Durrant wrote:
>> -Original Message-
>> From: Andrew Cooper
>> Sent: 07 December 2018 18:23
>> To: Paul Durrant ; xen-devel@lists.xenproject.org
>> Cc: Jan Beulich ; Wei Liu ; Roger
>> Pau Monne
>> Subject: Re: [PATCH] x86/hvm/viridian: stop open coding updates
> -Original Message-
> From: Andrew Cooper
> Sent: 07 December 2018 18:23
> To: Paul Durrant ; xen-devel@lists.xenproject.org
> Cc: Jan Beulich ; Wei Liu ; Roger
> Pau Monne
> Subject: Re: [PATCH] x86/hvm/viridian: stop open coding updates to APIC
> registers
>
> On 07/12/2018 17:50,
On 07/12/2018 17:50, Paul Durrant wrote:
> The code in viridian_synic_wrmsr() duplicates logic in vlapic_reg_write()
> to update the ICR, ICR2 and TASKPRI registers. Instead of doing this,
> make vlapic_reg_write() non-static and call it.
>
> Signed-off-by: Paul Durrant
> ---
> Cc: Jan Beulich
>
