Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-04-12 Thread Ingo Molnar
* Jan Beulich wrote: > >>> On 12.04.18 at 09:32, wrote: > > > * Jan Beulich wrote: > > > >> >>> On 11.04.18 at 13:53, wrote: > >> > * Jan Beulich wrote: > >> > > >> >> Additionally, x86

Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-04-12 Thread Jan Beulich
>>> On 12.04.18 at 09:32, wrote: > * Jan Beulich wrote: > >> >>> On 11.04.18 at 13:53, wrote: >> > * Jan Beulich wrote: >> > >> >> Additionally, x86 maintainers: is there a particular reason this (or >> >> any

Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-04-12 Thread Ingo Molnar
* Jan Beulich wrote: > >>> On 11.04.18 at 13:53, wrote: > > * Jan Beulich wrote: > > > >> Additionally, x86 maintainers: is there a particular reason this (or > >> any functionally equivalent patch) isn't upstream yet? As indicated > >>

Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-04-11 Thread Jan Beulich
>>> On 11.04.18 at 13:53, wrote: > * Jan Beulich wrote: > >> Additionally, x86 maintainers: is there a particular reason this (or >> any functionally equivalent patch) isn't upstream yet? As indicated >> before, I had not been able to find any discussion,

Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-04-11 Thread Ingo Molnar
* Jan Beulich wrote: > Additionally, x86 maintainers: is there a particular reason this (or > any functionally equivalent patch) isn't upstream yet? As indicated > before, I had not been able to find any discussion, and hence I > see no reason why this is a patch we

Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-04-11 Thread Jan Beulich
>>> On 11.04.18 at 09:08, wrote: > On 14/03/18 09:48, Jan Beulich wrote: > On 26.02.18 at 15:08, wrote: >>> @@ -35,6 +40,9 @@ void xen_arch_post_suspend(int cancelled) >>> >>> static void xen_vcpu_notify_restore(void *data) >>> { >>> + if

Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-04-11 Thread Juergen Gross
On 14/03/18 09:48, Jan Beulich wrote: On 26.02.18 at 15:08, wrote: >> @@ -35,6 +40,9 @@ void xen_arch_post_suspend(int cancelled) >> >> static void xen_vcpu_notify_restore(void *data) >> { >> +if (xen_pv_domain() && boot_cpu_has(X86_FEATURE_SPEC_CTRL)) >> +

Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-03-14 Thread Jan Beulich
>>> On 26.02.18 at 15:08, wrote: > @@ -35,6 +40,9 @@ void xen_arch_post_suspend(int cancelled) > > static void xen_vcpu_notify_restore(void *data) > { > + if (xen_pv_domain() && boot_cpu_has(X86_FEATURE_SPEC_CTRL)) > + wrmsrl(MSR_IA32_SPEC_CTRL,

Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-02-26 Thread Jan Beulich
>>> On 26.02.18 at 15:08, wrote: > Older Xen versions (4.5 and before) might have problems migrating pv > guests with MSR_IA32_SPEC_CTRL having a non-zero value. So before > suspending zero that MSR and restore it after being resumed. > > Cc: sta...@vger.kernel.org >