Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 11:36:40AM +0200, Roger Pau Monné wrote: > On Wed, Jul 11, 2018 at 11:11:05AM +0200, Daniel Kiper wrote: > > On Wed, Jul 11, 2018 at 10:59:20AM +0200, Roger Pau Monné wrote: > > > On Wed, Jul 11, 2018 at 10:55:56AM +0200, Daniel Kiper wrote: > > > > If this works in all case

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Roger Pau Monné
On Wed, Jul 11, 2018 at 11:11:05AM +0200, Daniel Kiper wrote: > On Wed, Jul 11, 2018 at 10:59:20AM +0200, Roger Pau Monné wrote: > > On Wed, Jul 11, 2018 at 10:55:56AM +0200, Daniel Kiper wrote: > > > If this works in all cases (build with tools with and without PE support, > > > xen.efi and xen.gz

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Jan Beulich
>>> On 11.07.18 at 11:02, wrote: > On Wed, Jul 11, 2018 at 02:48:25AM -0600, Jan Beulich wrote: >> >>> On 11.07.18 at 10:29, wrote: >> > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: >> >> Another possible thing to try might be to make the extern declaration >> >> of the symbol wea

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 10:59:20AM +0200, Roger Pau Monné wrote: > On Wed, Jul 11, 2018 at 10:55:56AM +0200, Daniel Kiper wrote: > > On Wed, Jul 11, 2018 at 02:48:25AM -0600, Jan Beulich wrote: > > > >>> On 11.07.18 at 10:29, wrote: > > > > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wro

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Roger Pau Monné
On Wed, Jul 11, 2018 at 02:48:25AM -0600, Jan Beulich wrote: > >>> On 11.07.18 at 10:29, wrote: > > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: > >> Another possible thing to try might be to make the extern declaration > >> of the symbol weak, and drop the offending line altogethe

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Roger Pau Monné
On Wed, Jul 11, 2018 at 10:55:56AM +0200, Daniel Kiper wrote: > On Wed, Jul 11, 2018 at 02:48:25AM -0600, Jan Beulich wrote: > > >>> On 11.07.18 at 10:29, wrote: > > > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: > > >> Another possible thing to try might be to make the extern decl

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 02:48:25AM -0600, Jan Beulich wrote: > >>> On 11.07.18 at 10:29, wrote: > > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: > >> Another possible thing to try might be to make the extern declaration > >> of the symbol weak, and drop the offending line altogethe

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Jan Beulich
>>> On 11.07.18 at 10:29, wrote: > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: >> Another possible thing to try might be to make the extern declaration >> of the symbol weak, and drop the offending line altogether. > > Oh, that didn't occur to me, and does seem to work. Below is

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Roger Pau Monné
On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 17:35, wrote: > > On Tue, Jul 10, 2018 at 08:09:06AM -0600, Jan Beulich wrote: > >> >>> On 10.07.18 at 15:49, wrote: > >> > On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: > >> >> >>> On 10.07.18 at 13:

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Jan Beulich
>>> On 10.07.18 at 17:35, wrote: > On Tue, Jul 10, 2018 at 08:09:06AM -0600, Jan Beulich wrote: >> >>> On 10.07.18 at 15:49, wrote: >> > On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: >> >> >>> On 10.07.18 at 13:00, wrote: >> >> > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Roger Pau Monné
On Tue, Jul 10, 2018 at 08:09:06AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 15:49, wrote: > > On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: > >> >>> On 10.07.18 at 13:00, wrote: > >> > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: > >> >> Sorry for asking s

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 15:49, wrote: > On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: >> >>> On 10.07.18 at 13:00, wrote: >> > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: >> >> Sorry for asking so many questions, but I would like to try to avoid >> >> the DEFINED co

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Roger Pau Monné
On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 13:00, wrote: > > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: > >> Sorry for asking so many questions, but I would like to try to avoid > >> the DEFINED conditional in the linker script if possib

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Daniel Kiper
On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 13:00, wrote: > > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: [...] > >> Sorry for asking so many questions, but I would like to try to avoid > >> the DEFINED conditional in the linker script i

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 13:00, wrote: > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: >> On Fri, Jul 06, 2018 at 03:48:39PM +0200, Daniel Kiper wrote: >> > On Thu, Jul 05, 2018 at 09:47:57AM +0200, Roger Pau Monné wrote: >> > > On Wed, Jul 04, 2018 at 12:49:00PM +0200, Daniel Kiper w

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Daniel Kiper
On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: > On Fri, Jul 06, 2018 at 03:48:39PM +0200, Daniel Kiper wrote: > > On Thu, Jul 05, 2018 at 09:47:57AM +0200, Roger Pau Monné wrote: > > > On Wed, Jul 04, 2018 at 12:49:00PM +0200, Daniel Kiper wrote: > > > > On Wed, Jul 04, 2018 at 0

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-09 Thread Roger Pau Monné
On Fri, Jul 06, 2018 at 03:48:39PM +0200, Daniel Kiper wrote: > On Thu, Jul 05, 2018 at 09:47:57AM +0200, Roger Pau Monné wrote: > > On Wed, Jul 04, 2018 at 12:49:00PM +0200, Daniel Kiper wrote: > > > On Wed, Jul 04, 2018 at 01:57:58AM -0600, Jan Beulich wrote: > > > > >>> On 03.07.18 at 18:02, wr

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-06 Thread Daniel Kiper
On Thu, Jul 05, 2018 at 09:47:57AM +0200, Roger Pau Monné wrote: > On Wed, Jul 04, 2018 at 12:49:00PM +0200, Daniel Kiper wrote: > > On Wed, Jul 04, 2018 at 01:57:58AM -0600, Jan Beulich wrote: > > > >>> On 03.07.18 at 18:02, wrote: > > > > On Thu, Jun 28, 2018 at 11:35:24PM -0600, Jan Beulich wro

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-05 Thread Roger Pau Monné
On Wed, Jul 04, 2018 at 12:49:00PM +0200, Daniel Kiper wrote: > On Wed, Jul 04, 2018 at 01:57:58AM -0600, Jan Beulich wrote: > > >>> On 03.07.18 at 18:02, wrote: > > > On Thu, Jun 28, 2018 at 11:35:24PM -0600, Jan Beulich wrote: > > >> >>> Roger Pau Monne 06/28/18 5:38 PM >>> > > >> >lld (the llv

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-04 Thread Daniel Kiper
On Wed, Jul 04, 2018 at 01:57:58AM -0600, Jan Beulich wrote: > >>> On 03.07.18 at 18:02, wrote: > > On Thu, Jun 28, 2018 at 11:35:24PM -0600, Jan Beulich wrote: > >> >>> Roger Pau Monne 06/28/18 5:38 PM >>> > >> >lld (the llvm linker) has some issues with Xen linker script. It > >> >doesn't under

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-04 Thread Jan Beulich
>>> On 03.07.18 at 18:02, wrote: > On Thu, Jun 28, 2018 at 11:35:24PM -0600, Jan Beulich wrote: >> >>> Roger Pau Monne 06/28/18 5:38 PM >>> >> >lld (the llvm linker) has some issues with Xen linker script. It >> >doesn't understand '||' in assert expressions: >> > >> >ld-melf_x86_64_fbsd -T

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-03 Thread Roger Pau Monné
On Tue, Jul 03, 2018 at 06:02:27PM +0200, Daniel Kiper wrote: > On Thu, Jun 28, 2018 at 11:35:24PM -0600, Jan Beulich wrote: > > >>> Roger Pau Monne 06/28/18 5:38 PM >>> > > >lld (the llvm linker) has some issues with Xen linker script. It > > >doesn't understand '||' in assert expressions: > > >

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-03 Thread Daniel Kiper
On Thu, Jun 28, 2018 at 11:35:24PM -0600, Jan Beulich wrote: > >>> Roger Pau Monne 06/28/18 5:38 PM >>> > >lld (the llvm linker) has some issues with Xen linker script. It > >doesn't understand '||' in assert expressions: > > > >ld-melf_x86_64_fbsd -T xen.lds -N prelink.o --build-id=sha1 \ >

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-06-28 Thread Roger Pau Monné
On Thu, Jun 28, 2018 at 11:35:24PM -0600, Jan Beulich wrote: > >>> Roger Pau Monne 06/28/18 5:38 PM >>> > >lld (the llvm linker) has some issues with Xen linker script. It > >doesn't understand '||' in assert expressions: > > > >ld-melf_x86_64_fbsd -T xen.lds -N prelink.o --build-id=sha1 \ >

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-06-28 Thread Jan Beulich
>>> Roger Pau Monne 06/28/18 5:38 PM >>> >lld (the llvm linker) has some issues with Xen linker script. It >doesn't understand '||' in assert expressions: > >ld-melf_x86_64_fbsd -T xen.lds -N prelink.o --build-id=sha1 \ >/root/src/xen/xen/common/symbols-dummy.o -o /root/src/xen/xen/.xen-syms.