Re: [Xen-devel] [PATCH 1/1] tools: reduce copies b/w ocaml Strings and Bytes

2018-04-06 Thread Wei Liu
On Thu, Apr 05, 2018 at 05:16:27PM +0100, Christian Lindig wrote: > I think this is a good patch as it reduces the amount of copying. I believe > it is safe as it is. There is one place where I am a little hesitant: > > @@ -291,7 +291,9 @@ let access_logging ~con ~tid ?(data="") ~level >

Re: [Xen-devel] [PATCH 1/1] tools: reduce copies b/w ocaml Strings and Bytes

2018-04-05 Thread Christian Lindig
I think this is a good patch as it reduces the amount of copying. I believe it is safe as it is. There is one place where I am a little hesitant: @@ -291,7 +291,9 @@ let access_logging ~con ~tid ?(data="") ~level access_type = let date = string_of_date() in