Re: [Xen-devel] [PATCH 4/4] xen/x86: Rework inclusion between struct pirq and struct hvm_pirq_dpci

2020-01-17 Thread Julien Grall
Hi Jan, On 15/01/2020 10:44, Jan Beulich wrote: On 14.01.2020 18:03, Julien Grall wrote: On 14/01/2020 16:50, Jan Beulich wrote: On 14.01.2020 17:26, Julien Grall wrote: On 14/01/2020 16:08, Jan Beulich wrote: On 13.01.2020 22:33, Julien Grall wrote: --- a/xen/arch/x86/hvm/irq.c +++ b/xen/a

Re: [Xen-devel] [PATCH 4/4] xen/x86: Rework inclusion between struct pirq and struct hvm_pirq_dpci

2020-01-15 Thread Jan Beulich
On 14.01.2020 18:03, Julien Grall wrote: > On 14/01/2020 16:50, Jan Beulich wrote: >> On 14.01.2020 17:26, Julien Grall wrote: >>> On 14/01/2020 16:08, Jan Beulich wrote: On 13.01.2020 22:33, Julien Grall wrote: > --- a/xen/arch/x86/hvm/irq.c > +++ b/xen/arch/x86/hvm/irq.c > @@ -29

Re: [Xen-devel] [PATCH 4/4] xen/x86: Rework inclusion between struct pirq and struct hvm_pirq_dpci

2020-01-14 Thread Julien Grall
Hi, On 14/01/2020 16:50, Jan Beulich wrote: On 14.01.2020 17:26, Julien Grall wrote: On 14/01/2020 16:08, Jan Beulich wrote: On 13.01.2020 22:33, Julien Grall wrote: --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -29,7 +29,8 @@ bool hvm_domain_use_pirq(const struct domain

Re: [Xen-devel] [PATCH 4/4] xen/x86: Rework inclusion between struct pirq and struct hvm_pirq_dpci

2020-01-14 Thread Jan Beulich
On 14.01.2020 17:26, Julien Grall wrote: > On 14/01/2020 16:08, Jan Beulich wrote: >> On 13.01.2020 22:33, Julien Grall wrote: >>> --- a/xen/arch/x86/hvm/irq.c >>> +++ b/xen/arch/x86/hvm/irq.c >>> @@ -29,7 +29,8 @@ >>> >>> bool hvm_domain_use_pirq(const struct domain *d, const struct pirq *pir

Re: [Xen-devel] [PATCH 4/4] xen/x86: Rework inclusion between struct pirq and struct hvm_pirq_dpci

2020-01-14 Thread Julien Grall
Hi Jan, On 14/01/2020 16:08, Jan Beulich wrote: On 13.01.2020 22:33, Julien Grall wrote: --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -29,7 +29,8 @@ bool hvm_domain_use_pirq(const struct domain *d, const struct pirq *pirq) { -return is_hvm_domain(d) && pirq && pirq->

Re: [Xen-devel] [PATCH 4/4] xen/x86: Rework inclusion between struct pirq and struct hvm_pirq_dpci

2020-01-14 Thread Jan Beulich
On 13.01.2020 22:33, Julien Grall wrote: > --- a/xen/arch/x86/hvm/irq.c > +++ b/xen/arch/x86/hvm/irq.c > @@ -29,7 +29,8 @@ > > bool hvm_domain_use_pirq(const struct domain *d, const struct pirq *pirq) > { > -return is_hvm_domain(d) && pirq && pirq->arch.hvm.emuirq != IRQ_UNBOUND; > +ret