Re: [Xen-devel] [PATCH 4/5] x86/pv: Remove deferred RDTSC{, P} handling in pv_emulate_privileged_op()

2018-02-23 Thread Jan Beulich
>>> On 20.02.18 at 12:58, wrote: > The handling of RDTSCP for PV guests has been broken (AFAICT forever). > > To start with, RDTSCP is hidden from PV guests so the MSR_TSC_AUX path should > be unreachable. However, this appears to be a "feature" of TSC_MODE_PVRDTSCP, > and the emulator doesn't p

Re: [Xen-devel] [PATCH 4/5] x86/pv: Remove deferred RDTSC{, P} handling in pv_emulate_privileged_op()

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 04:37:51PM +, Andrew Cooper wrote: > On 20/02/18 16:28, Roger Pau Monné wrote: > > On Tue, Feb 20, 2018 at 11:58:42AM +, Andrew Cooper wrote: > >> The handling of RDTSCP for PV guests has been broken (AFAICT forever). > >> > >> To start with, RDTSCP is hidden from PV

Re: [Xen-devel] [PATCH 4/5] x86/pv: Remove deferred RDTSC{, P} handling in pv_emulate_privileged_op()

2018-02-20 Thread Andrew Cooper
On 20/02/18 16:28, Roger Pau Monné wrote: > On Tue, Feb 20, 2018 at 11:58:42AM +, Andrew Cooper wrote: >> The handling of RDTSCP for PV guests has been broken (AFAICT forever). >> >> To start with, RDTSCP is hidden from PV guests so the MSR_TSC_AUX path should >> be unreachable. However, this

Re: [Xen-devel] [PATCH 4/5] x86/pv: Remove deferred RDTSC{, P} handling in pv_emulate_privileged_op()

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 11:58:42AM +, Andrew Cooper wrote: > The handling of RDTSCP for PV guests has been broken (AFAICT forever). > > To start with, RDTSCP is hidden from PV guests so the MSR_TSC_AUX path should > be unreachable. However, this appears to be a "feature" of TSC_MODE_PVRDTSCP,

Re: [Xen-devel] [PATCH 4/5] x86/pv: Remove deferred RDTSC{, P} handling in pv_emulate_privileged_op()

2018-02-20 Thread Wei Liu
On Tue, Feb 20, 2018 at 11:58:42AM +, Andrew Cooper wrote: > The handling of RDTSCP for PV guests has been broken (AFAICT forever). > > To start with, RDTSCP is hidden from PV guests so the MSR_TSC_AUX path should > be unreachable. However, this appears to be a "feature" of TSC_MODE_PVRDTSCP,