Re: [Xen-devel] [PATCH 6/7] xen/domain: Pass the full domctl_createdomain struct to create_domain()

2018-03-12 Thread Jan Beulich
>>> Andrew Cooper 03/09/18 6:06 PM >>> >On 09/03/18 17:00, Jan Beulich wrote: > On 09.03.18 at 14:18, wrote: >>> --- a/xen/arch/x86/domain.c >>> +++ b/xen/arch/x86/domain.c >>> @@ -426,8 +426,8 @@ static bool emulation_flags_ok(const struct domain *d, >>> uint32_t emflags) >>> return tr

Re: [Xen-devel] [PATCH 6/7] xen/domain: Pass the full domctl_createdomain struct to create_domain()

2018-03-11 Thread Julien Grall
Hi Andrew, On 03/09/2018 01:18 PM, Andrew Cooper wrote: In future patches, the structure will be extended with further information, and this is far cleaner than adding extra parameters. One minor tweak is that the setting of guest_type needs to be deferred until config is known-good to derefere

Re: [Xen-devel] [PATCH 6/7] xen/domain: Pass the full domctl_createdomain struct to create_domain()

2018-03-09 Thread Andrew Cooper
On 09/03/18 17:00, Jan Beulich wrote: On 09.03.18 at 14:18, wrote: >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -426,8 +426,8 @@ static bool emulation_flags_ok(const struct domain *d, >> uint32_t emflags) >> return true; >> } >> >> -int arch_domain_create(struc

Re: [Xen-devel] [PATCH 6/7] xen/domain: Pass the full domctl_createdomain struct to create_domain()

2018-03-09 Thread Jan Beulich
>>> On 09.03.18 at 14:18, wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -426,8 +426,8 @@ static bool emulation_flags_ok(const struct domain *d, > uint32_t emflags) > return true; > } > > -int arch_domain_create(struct domain *d, unsigned int domcr_flags, > -

Re: [Xen-devel] [PATCH 6/7] xen/domain: Pass the full domctl_createdomain struct to create_domain()

2018-03-09 Thread Wei Liu
On Fri, Mar 09, 2018 at 01:18:41PM +, Andrew Cooper wrote: > In future patches, the structure will be extended with further information, > and this is far cleaner than adding extra parameters. > > One minor tweak is that the setting of guest_type needs to be deferred until > config is known-go