>>> On 07.05.18 at 23:07, <janakarajan.natara...@amd.com> wrote:
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -64,6 +64,16 @@
> #include <asm/monitor.h>
> #include <asm/xstate.h>
>
> +static int parse_svm_param(const char *s);
This is unnecessary if you move ...
> +/*
> + * The 'svm' parameter en/dis-ables various SVM features.
> + * Optional comma separated value may contain:
> + *
> + * avic - Enable SVM Advanced Virtual Interrupt Controller (AVIC)
> + */
> +custom_param("svm", parse_svm_param);
... this after the function definition.
> @@ -89,6 +99,28 @@ static bool_t amd_erratum383_found __read_mostly;
> static uint64_t osvw_length, osvw_status;
> static DEFINE_SPINLOCK(osvw_lock);
>
> +static int __init parse_svm_param(const char *s)
> +{
> + char *ss;
> + int val;
> +
> + do {
> + val = !!strncmp(s, "no-", 3);
> + if ( !val )
> + s += 3;
Please use parse_boolean().
> + ss = strchr(s, ',');
> + if ( ss )
> + *ss = '\0';
> +
> + if ( !strcmp(s, "avic") )
> + svm_avic = val;
else
ret = -EINVAL;
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
