Re: [Xen-devel] [PATCH v2 4/9] x86/HVM: move NOFLUSH handling out of hvm_set_cr3()

2019-09-18 Thread Tamas K Lengyel
On Wed, Sep 18, 2019 at 3:29 AM Jan Beulich wrote: > > On 17.09.2019 21:31, Andrew Cooper wrote: > > On 17/09/2019 07:15, Jan Beulich wrote: > >> --- a/xen/arch/x86/hvm/hvm.c > >> +++ b/xen/arch/x86/hvm/hvm.c > >> @@ -2282,12 +2287,11 @@ int hvm_set_cr0(unsigned long value, boo > >> return

Re: [Xen-devel] [PATCH v2 4/9] x86/HVM: move NOFLUSH handling out of hvm_set_cr3()

2019-09-18 Thread Jan Beulich
On 17.09.2019 21:31, Andrew Cooper wrote: > On 17/09/2019 07:15, Jan Beulich wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -2282,12 +2287,11 @@ int hvm_set_cr0(unsigned long value, boo >> return X86EMUL_OKAY; >> } >> >> -int hvm_set_cr3(unsigned long value,

Re: [Xen-devel] [PATCH v2 4/9] x86/HVM: move NOFLUSH handling out of hvm_set_cr3()

2019-09-17 Thread Andrew Cooper
On 17/09/2019 07:15, Jan Beulich wrote: > The bit is meaningful only for MOV-to-CR3 insns, not anywhere else, in > particular not when loading nested guest state. I've found a footnote for "26.3.1.1 Checks on Guest Control Registers, Debug Registers, and MSRs" stating: "Bit 63 of the CR3 field

Re: [Xen-devel] [PATCH v2 4/9] x86/HVM: move NOFLUSH handling out of hvm_set_cr3()

2019-09-17 Thread Paul Durrant
risOstrovsky ; Paul Durrant ; Wei > Liu > Subject: Re: [Xen-devel] [PATCH v2 4/9] x86/HVM: move NOFLUSH handling out of > hvm_set_cr3() > > On 17.09.2019 14:45, Paul Durrant wrote: > >> From: Xen-devel On Behalf Of Jan > >> Beulich > >> Sent: 17 September 20

Re: [Xen-devel] [PATCH v2 4/9] x86/HVM: move NOFLUSH handling out of hvm_set_cr3()

2019-09-17 Thread Jan Beulich
On 17.09.2019 14:45, Paul Durrant wrote: >> From: Xen-devel On Behalf Of Jan >> Beulich >> Sent: 17 September 2019 07:15 >> >> --- a/xen/arch/x86/hvm/emulate.c >> +++ b/xen/arch/x86/hvm/emulate.c >> @@ -2080,6 +2080,8 @@ static int hvmemul_write_cr( >> HVMTRACE_LONG_2D(CR_WRITE, reg,

Re: [Xen-devel] [PATCH v2 4/9] x86/HVM: move NOFLUSH handling out of hvm_set_cr3()

2019-09-17 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of Jan > Beulich > Sent: 17 September 2019 07:15 > To: xen-devel@lists.xenproject.org > Cc: Kevin Tian ; Suravee Suthikulpanit > ; Wei Liu > ; Paul Durrant ; George Dunlap > ; Andrew Cooper > ; Jun Nakajima ; Boris > Ostrovsky > ; Roger