Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-04-12 Thread Oleksandr Andrushchenko

On 04/12/2018 05:31 PM, Konrad Rzeszutek Wilk wrote:

On Wed, Mar 21, 2018 at 09:15:36AM +0200, Oleksandr Andrushchenko wrote:

On 03/20/2018 10:22 PM, Takashi Iwai wrote:

On Mon, 19 Mar 2018 08:22:19 +0100,
Oleksandr Andrushchenko wrote:

From: Oleksandr Andrushchenko 

Hello, all!

In order to provide explicit synchronization between backend and
frontend the following changes are introduced in the protocol:
   - bump protocol version to 2
   - add new ring buffer for sending asynchronous events from
 backend to frontend to report number of bytes played by the
 frontend (XENSND_EVT_CUR_POS)
   - introduce trigger events for playback control: start/stop/pause/resume
   - add "req-" prefix to event-channel and ring-ref to unify naming
 of the Xen event channels for requests and events
   - add XENSND_OP_HW_PARAM_QUERY request to read/update
 stream configuration space: request passes desired intervals/formats for
 the stream parameters and the response returns allowed intervals and
 formats mask that can be used.

Changes since v2:
1. Konrad's r-b tag for version patch
2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all
 parameters at once, allowing to check all the configuration
 space.
4. Minor documentation cleanup (added missed "reserved" fields)

Changes since v1:

1. Changed protocol version definition from string to integer,
so it can easily be used in comparisons.
Konrad, I have removed your r-b tag for the reason of this change.

2. In order to provide explicit stream parameter negotiation between
backend and frontend the following changes are introduced in the protocol:
add XENSND_OP_HW_PARAM_QUERY request to read/update
configuration space for the parameter given: request passes
desired parameter interval (mask) and the response to this request
returns min/max interval (mask) for the parameter to be used.

Parameters supported by this request/response:
   - format mask
   - sample rate interval
   - number of channels interval
   - buffer size, interval, frames
   - period size, interval, frames

I can't judge exactly about the protocol without the actual FE/BE
implementations, but the change looks good to me, especially if you've
already tested something.

Thank you, I have tested the changes and need them to start upstreaming
the frontend driver used to test the protocol.
Do you mind if I put your Acked-by (or you prefer Reviewed-by?) tag to these
patches:

[PATCH v3 4/5] sndif: Add explicit back and front synchronization
[PATCH v3 5/5] sndif: Add explicit back and front parameter negotiation

Please note, that the changes first to be merged into Xen and then I'll
prepare
the same, but for the kernel

If other people have no concern, let's go ahead with FE/BE stuff.

Konrad, are you ok with the changes?

Yes. Thank you for your persistence.

Can you also add:

Reviewed-by: Konrad Rzeszutek Wilk 
Great, can you please add r-b tags while applying or you want me to 
resend with r-b tags?

Thank you!

thanks,

Takashi

Thank you,
Oleksandr



___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-04-12 Thread Konrad Rzeszutek Wilk
On Wed, Mar 21, 2018 at 09:15:36AM +0200, Oleksandr Andrushchenko wrote:
> On 03/20/2018 10:22 PM, Takashi Iwai wrote:
> > On Mon, 19 Mar 2018 08:22:19 +0100,
> > Oleksandr Andrushchenko wrote:
> > > From: Oleksandr Andrushchenko 
> > > 
> > > Hello, all!
> > > 
> > > In order to provide explicit synchronization between backend and
> > > frontend the following changes are introduced in the protocol:
> > >   - bump protocol version to 2
> > >   - add new ring buffer for sending asynchronous events from
> > > backend to frontend to report number of bytes played by the
> > > frontend (XENSND_EVT_CUR_POS)
> > >   - introduce trigger events for playback control: start/stop/pause/resume
> > >   - add "req-" prefix to event-channel and ring-ref to unify naming
> > > of the Xen event channels for requests and events
> > >   - add XENSND_OP_HW_PARAM_QUERY request to read/update
> > > stream configuration space: request passes desired intervals/formats 
> > > for
> > > the stream parameters and the response returns allowed intervals and
> > > formats mask that can be used.
> > > 
> > > Changes since v2:
> > > 1. Konrad's r-b tag for version patch
> > > 2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
> > > 3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all
> > > parameters at once, allowing to check all the configuration
> > > space.
> > > 4. Minor documentation cleanup (added missed "reserved" fields)
> > > 
> > > Changes since v1:
> > > 
> > > 1. Changed protocol version definition from string to integer,
> > > so it can easily be used in comparisons.
> > > Konrad, I have removed your r-b tag for the reason of this change.
> > > 
> > > 2. In order to provide explicit stream parameter negotiation between
> > > backend and frontend the following changes are introduced in the protocol:
> > > add XENSND_OP_HW_PARAM_QUERY request to read/update
> > > configuration space for the parameter given: request passes
> > > desired parameter interval (mask) and the response to this request
> > > returns min/max interval (mask) for the parameter to be used.
> > > 
> > > Parameters supported by this request/response:
> > >   - format mask
> > >   - sample rate interval
> > >   - number of channels interval
> > >   - buffer size, interval, frames
> > >   - period size, interval, frames
> > I can't judge exactly about the protocol without the actual FE/BE
> > implementations, but the change looks good to me, especially if you've
> > already tested something.
> Thank you, I have tested the changes and need them to start upstreaming
> the frontend driver used to test the protocol.
> Do you mind if I put your Acked-by (or you prefer Reviewed-by?) tag to these
> patches:
> 
> [PATCH v3 4/5] sndif: Add explicit back and front synchronization
> [PATCH v3 5/5] sndif: Add explicit back and front parameter negotiation
> 
> Please note, that the changes first to be merged into Xen and then I'll
> prepare
> the same, but for the kernel
> > 
> > If other people have no concern, let's go ahead with FE/BE stuff.
> Konrad, are you ok with the changes?

Yes. Thank you for your persistence.

Can you also add:

Reviewed-by: Konrad Rzeszutek Wilk 

Thank you!
> > 
> > thanks,
> > 
> > Takashi
> Thank you,
> Oleksandr

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-04-09 Thread Oleksandr Andrushchenko

Konrad?

On 04/03/2018 08:37 AM, Oleksandr Andrushchenko wrote:

ping

On 03/27/2018 08:41 AM, Oleksandr Andrushchenko wrote:

Hi, Konrad!

Could you please review?

Thank you,
Oleksandr

On 03/21/2018 09:25 AM, Oleksandr Andrushchenko wrote:

On 03/21/2018 09:20 AM, Takashi Iwai wrote:

On Wed, 21 Mar 2018 08:15:36 +0100,
Oleksandr Andrushchenko wrote:

On 03/20/2018 10:22 PM, Takashi Iwai wrote:

On Mon, 19 Mar 2018 08:22:19 +0100,
Oleksandr Andrushchenko wrote:

From: Oleksandr Andrushchenko 

Hello, all!

In order to provide explicit synchronization between backend and
frontend the following changes are introduced in the protocol:
   - bump protocol version to 2
   - add new ring buffer for sending asynchronous events from
 backend to frontend to report number of bytes played by the
 frontend (XENSND_EVT_CUR_POS)
   - introduce trigger events for playback control: 
start/stop/pause/resume
   - add "req-" prefix to event-channel and ring-ref to unify 
naming

 of the Xen event channels for requests and events
   - add XENSND_OP_HW_PARAM_QUERY request to read/update
 stream configuration space: request passes desired 
intervals/formats for
 the stream parameters and the response returns allowed 
intervals and

 formats mask that can be used.

Changes since v2:
1. Konrad's r-b tag for version patch
2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all
 parameters at once, allowing to check all the configuration
 space.
4. Minor documentation cleanup (added missed "reserved" fields)

Changes since v1:

1. Changed protocol version definition from string to integer,
so it can easily be used in comparisons.
Konrad, I have removed your r-b tag for the reason of this change.

2. In order to provide explicit stream parameter negotiation 
between
backend and frontend the following changes are introduced in the 
protocol:

add XENSND_OP_HW_PARAM_QUERY request to read/update
configuration space for the parameter given: request passes
desired parameter interval (mask) and the response to this request
returns min/max interval (mask) for the parameter to be used.

Parameters supported by this request/response:
   - format mask
   - sample rate interval
   - number of channels interval
   - buffer size, interval, frames
   - period size, interval, frames

I can't judge exactly about the protocol without the actual FE/BE
implementations, but the change looks good to me, especially if 
you've

already tested something.
Thank you, I have tested the changes and need them to start 
upstreaming

the frontend driver used to test the protocol.
Do you mind if I put your Acked-by (or you prefer Reviewed-by?) 
tag to

these patches:

[PATCH v3 4/5] sndif: Add explicit back and front synchronization
[PATCH v3 5/5] sndif: Add explicit back and front parameter 
negotiation

Sure, feel free to take my ack:
   Reviewed-by: Takashi Iwai 

Thank you


Takashi


Please note, that the changes first to be merged into Xen and then
I'll prepare
the same, but for the kernel

If other people have no concern, let's go ahead with FE/BE stuff.

Konrad, are you ok with the changes?

thanks,

Takashi

Thank you,
Oleksandr










___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-04-06 Thread Oleksandr Andrushchenko

On 04/06/2018 12:13 PM, Juergen Gross wrote:

On 19/03/18 08:22, Oleksandr Andrushchenko wrote:

From: Oleksandr Andrushchenko 

Hello, all!

In order to provide explicit synchronization between backend and
frontend the following changes are introduced in the protocol:
  - bump protocol version to 2
  - add new ring buffer for sending asynchronous events from
backend to frontend to report number of bytes played by the
frontend (XENSND_EVT_CUR_POS)
  - introduce trigger events for playback control: start/stop/pause/resume
  - add "req-" prefix to event-channel and ring-ref to unify naming
of the Xen event channels for requests and events
  - add XENSND_OP_HW_PARAM_QUERY request to read/update
stream configuration space: request passes desired intervals/formats for
the stream parameters and the response returns allowed intervals and
formats mask that can be used.

Changes since v2:
1. Konrad's r-b tag for version patch
2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all
parameters at once, allowing to check all the configuration
space.
4. Minor documentation cleanup (added missed "reserved" fields)

Changes since v1:

1. Changed protocol version definition from string to integer,
so it can easily be used in comparisons.
Konrad, I have removed your r-b tag for the reason of this change.

2. In order to provide explicit stream parameter negotiation between
backend and frontend the following changes are introduced in the protocol:
add XENSND_OP_HW_PARAM_QUERY request to read/update
configuration space for the parameter given: request passes
desired parameter interval (mask) and the response to this request
returns min/max interval (mask) for the parameter to be used.

Parameters supported by this request/response:
  - format mask
  - sample rate interval
  - number of channels interval
  - buffer size, interval, frames
  - period size, interval, frames

Oleksandr Andrushchenko (5):
   sndif: Introduce protocol version
   sndif: Fix missed "reserved" fields in comments
   sndif: Make requests and responses 64 octets long
   sndif: Add explicit back and front synchronization
   sndif: Add explicit back and front parameter negotiation

  xen/include/public/io/sndif.h | 322 +++---
  1 file changed, 306 insertions(+), 16 deletions(-)


With Konrad's ack you can have my:

Release-acked-by: Juergen Gross 

Thank you


even if the commit can't be done before the freeze. The header isn't
used inside Xen so the risk for the release is zero.

This is true


Juergen

Thank you,
Oleksandr

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-04-06 Thread Juergen Gross
On 19/03/18 08:22, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko 
> 
> Hello, all!
> 
> In order to provide explicit synchronization between backend and
> frontend the following changes are introduced in the protocol:
>  - bump protocol version to 2
>  - add new ring buffer for sending asynchronous events from
>backend to frontend to report number of bytes played by the
>frontend (XENSND_EVT_CUR_POS)
>  - introduce trigger events for playback control: start/stop/pause/resume
>  - add "req-" prefix to event-channel and ring-ref to unify naming
>of the Xen event channels for requests and events
>  - add XENSND_OP_HW_PARAM_QUERY request to read/update
>stream configuration space: request passes desired intervals/formats for
>the stream parameters and the response returns allowed intervals and
>formats mask that can be used.
> 
> Changes since v2:
> 1. Konrad's r-b tag for version patch
> 2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
> 3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all 
>parameters at once, allowing to check all the configuration
>space.
> 4. Minor documentation cleanup (added missed "reserved" fields)
> 
> Changes since v1:
> 
> 1. Changed protocol version definition from string to integer,
> so it can easily be used in comparisons.
> Konrad, I have removed your r-b tag for the reason of this change.
> 
> 2. In order to provide explicit stream parameter negotiation between
> backend and frontend the following changes are introduced in the protocol:
> add XENSND_OP_HW_PARAM_QUERY request to read/update
> configuration space for the parameter given: request passes
> desired parameter interval (mask) and the response to this request
> returns min/max interval (mask) for the parameter to be used.
> 
> Parameters supported by this request/response:
>  - format mask
>  - sample rate interval
>  - number of channels interval
>  - buffer size, interval, frames
>  - period size, interval, frames
> 
> Oleksandr Andrushchenko (5):
>   sndif: Introduce protocol version
>   sndif: Fix missed "reserved" fields in comments
>   sndif: Make requests and responses 64 octets long
>   sndif: Add explicit back and front synchronization
>   sndif: Add explicit back and front parameter negotiation
> 
>  xen/include/public/io/sndif.h | 322 
> +++---
>  1 file changed, 306 insertions(+), 16 deletions(-)
> 

With Konrad's ack you can have my:

Release-acked-by: Juergen Gross 

even if the commit can't be done before the freeze. The header isn't
used inside Xen so the risk for the release is zero.


Juergen

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-04-02 Thread Oleksandr Andrushchenko

ping

On 03/27/2018 08:41 AM, Oleksandr Andrushchenko wrote:

Hi, Konrad!

Could you please review?

Thank you,
Oleksandr

On 03/21/2018 09:25 AM, Oleksandr Andrushchenko wrote:

On 03/21/2018 09:20 AM, Takashi Iwai wrote:

On Wed, 21 Mar 2018 08:15:36 +0100,
Oleksandr Andrushchenko wrote:

On 03/20/2018 10:22 PM, Takashi Iwai wrote:

On Mon, 19 Mar 2018 08:22:19 +0100,
Oleksandr Andrushchenko wrote:

From: Oleksandr Andrushchenko 

Hello, all!

In order to provide explicit synchronization between backend and
frontend the following changes are introduced in the protocol:
   - bump protocol version to 2
   - add new ring buffer for sending asynchronous events from
 backend to frontend to report number of bytes played by the
 frontend (XENSND_EVT_CUR_POS)
   - introduce trigger events for playback control: 
start/stop/pause/resume

   - add "req-" prefix to event-channel and ring-ref to unify naming
 of the Xen event channels for requests and events
   - add XENSND_OP_HW_PARAM_QUERY request to read/update
 stream configuration space: request passes desired 
intervals/formats for
 the stream parameters and the response returns allowed 
intervals and

 formats mask that can be used.

Changes since v2:
1. Konrad's r-b tag for version patch
2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all
 parameters at once, allowing to check all the configuration
 space.
4. Minor documentation cleanup (added missed "reserved" fields)

Changes since v1:

1. Changed protocol version definition from string to integer,
so it can easily be used in comparisons.
Konrad, I have removed your r-b tag for the reason of this change.

2. In order to provide explicit stream parameter negotiation between
backend and frontend the following changes are introduced in the 
protocol:

add XENSND_OP_HW_PARAM_QUERY request to read/update
configuration space for the parameter given: request passes
desired parameter interval (mask) and the response to this request
returns min/max interval (mask) for the parameter to be used.

Parameters supported by this request/response:
   - format mask
   - sample rate interval
   - number of channels interval
   - buffer size, interval, frames
   - period size, interval, frames

I can't judge exactly about the protocol without the actual FE/BE
implementations, but the change looks good to me, especially if 
you've

already tested something.
Thank you, I have tested the changes and need them to start 
upstreaming

the frontend driver used to test the protocol.
Do you mind if I put your Acked-by (or you prefer Reviewed-by?) tag to
these patches:

[PATCH v3 4/5] sndif: Add explicit back and front synchronization
[PATCH v3 5/5] sndif: Add explicit back and front parameter 
negotiation

Sure, feel free to take my ack:
   Reviewed-by: Takashi Iwai 

Thank you


Takashi


Please note, that the changes first to be merged into Xen and then
I'll prepare
the same, but for the kernel

If other people have no concern, let's go ahead with FE/BE stuff.

Konrad, are you ok with the changes?

thanks,

Takashi

Thank you,
Oleksandr








___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-03-26 Thread Oleksandr Andrushchenko

Hi, Konrad!

Could you please review?

Thank you,
Oleksandr

On 03/21/2018 09:25 AM, Oleksandr Andrushchenko wrote:

On 03/21/2018 09:20 AM, Takashi Iwai wrote:

On Wed, 21 Mar 2018 08:15:36 +0100,
Oleksandr Andrushchenko wrote:

On 03/20/2018 10:22 PM, Takashi Iwai wrote:

On Mon, 19 Mar 2018 08:22:19 +0100,
Oleksandr Andrushchenko wrote:

From: Oleksandr Andrushchenko 

Hello, all!

In order to provide explicit synchronization between backend and
frontend the following changes are introduced in the protocol:
   - bump protocol version to 2
   - add new ring buffer for sending asynchronous events from
 backend to frontend to report number of bytes played by the
 frontend (XENSND_EVT_CUR_POS)
   - introduce trigger events for playback control: 
start/stop/pause/resume

   - add "req-" prefix to event-channel and ring-ref to unify naming
 of the Xen event channels for requests and events
   - add XENSND_OP_HW_PARAM_QUERY request to read/update
 stream configuration space: request passes desired 
intervals/formats for
 the stream parameters and the response returns allowed 
intervals and

 formats mask that can be used.

Changes since v2:
1. Konrad's r-b tag for version patch
2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all
 parameters at once, allowing to check all the configuration
 space.
4. Minor documentation cleanup (added missed "reserved" fields)

Changes since v1:

1. Changed protocol version definition from string to integer,
so it can easily be used in comparisons.
Konrad, I have removed your r-b tag for the reason of this change.

2. In order to provide explicit stream parameter negotiation between
backend and frontend the following changes are introduced in the 
protocol:

add XENSND_OP_HW_PARAM_QUERY request to read/update
configuration space for the parameter given: request passes
desired parameter interval (mask) and the response to this request
returns min/max interval (mask) for the parameter to be used.

Parameters supported by this request/response:
   - format mask
   - sample rate interval
   - number of channels interval
   - buffer size, interval, frames
   - period size, interval, frames

I can't judge exactly about the protocol without the actual FE/BE
implementations, but the change looks good to me, especially if you've
already tested something.

Thank you, I have tested the changes and need them to start upstreaming
the frontend driver used to test the protocol.
Do you mind if I put your Acked-by (or you prefer Reviewed-by?) tag to
these patches:

[PATCH v3 4/5] sndif: Add explicit back and front synchronization
[PATCH v3 5/5] sndif: Add explicit back and front parameter negotiation

Sure, feel free to take my ack:
   Reviewed-by: Takashi Iwai 

Thank you


Takashi


Please note, that the changes first to be merged into Xen and then
I'll prepare
the same, but for the kernel

If other people have no concern, let's go ahead with FE/BE stuff.

Konrad, are you ok with the changes?

thanks,

Takashi

Thank you,
Oleksandr






___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-03-21 Thread Oleksandr Andrushchenko

On 03/21/2018 09:20 AM, Takashi Iwai wrote:

On Wed, 21 Mar 2018 08:15:36 +0100,
Oleksandr Andrushchenko wrote:

On 03/20/2018 10:22 PM, Takashi Iwai wrote:

On Mon, 19 Mar 2018 08:22:19 +0100,
Oleksandr Andrushchenko wrote:

From: Oleksandr Andrushchenko 

Hello, all!

In order to provide explicit synchronization between backend and
frontend the following changes are introduced in the protocol:
   - bump protocol version to 2
   - add new ring buffer for sending asynchronous events from
 backend to frontend to report number of bytes played by the
 frontend (XENSND_EVT_CUR_POS)
   - introduce trigger events for playback control: start/stop/pause/resume
   - add "req-" prefix to event-channel and ring-ref to unify naming
 of the Xen event channels for requests and events
   - add XENSND_OP_HW_PARAM_QUERY request to read/update
 stream configuration space: request passes desired intervals/formats for
 the stream parameters and the response returns allowed intervals and
 formats mask that can be used.

Changes since v2:
1. Konrad's r-b tag for version patch
2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all
 parameters at once, allowing to check all the configuration
 space.
4. Minor documentation cleanup (added missed "reserved" fields)

Changes since v1:

1. Changed protocol version definition from string to integer,
so it can easily be used in comparisons.
Konrad, I have removed your r-b tag for the reason of this change.

2. In order to provide explicit stream parameter negotiation between
backend and frontend the following changes are introduced in the protocol:
add XENSND_OP_HW_PARAM_QUERY request to read/update
configuration space for the parameter given: request passes
desired parameter interval (mask) and the response to this request
returns min/max interval (mask) for the parameter to be used.

Parameters supported by this request/response:
   - format mask
   - sample rate interval
   - number of channels interval
   - buffer size, interval, frames
   - period size, interval, frames

I can't judge exactly about the protocol without the actual FE/BE
implementations, but the change looks good to me, especially if you've
already tested something.

Thank you, I have tested the changes and need them to start upstreaming
the frontend driver used to test the protocol.
Do you mind if I put your Acked-by (or you prefer Reviewed-by?) tag to
these patches:

[PATCH v3 4/5] sndif: Add explicit back and front synchronization
[PATCH v3 5/5] sndif: Add explicit back and front parameter negotiation

Sure, feel free to take my ack:
   Reviewed-by: Takashi Iwai 

Thank you


Takashi


Please note, that the changes first to be merged into Xen and then
I'll prepare
the same, but for the kernel

If other people have no concern, let's go ahead with FE/BE stuff.

Konrad, are you ok with the changes?

thanks,

Takashi

Thank you,
Oleksandr




___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-03-21 Thread Takashi Iwai
On Wed, 21 Mar 2018 08:15:36 +0100,
Oleksandr Andrushchenko wrote:
> 
> On 03/20/2018 10:22 PM, Takashi Iwai wrote:
> > On Mon, 19 Mar 2018 08:22:19 +0100,
> > Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko 
> >>
> >> Hello, all!
> >>
> >> In order to provide explicit synchronization between backend and
> >> frontend the following changes are introduced in the protocol:
> >>   - bump protocol version to 2
> >>   - add new ring buffer for sending asynchronous events from
> >> backend to frontend to report number of bytes played by the
> >> frontend (XENSND_EVT_CUR_POS)
> >>   - introduce trigger events for playback control: start/stop/pause/resume
> >>   - add "req-" prefix to event-channel and ring-ref to unify naming
> >> of the Xen event channels for requests and events
> >>   - add XENSND_OP_HW_PARAM_QUERY request to read/update
> >> stream configuration space: request passes desired intervals/formats 
> >> for
> >> the stream parameters and the response returns allowed intervals and
> >> formats mask that can be used.
> >>
> >> Changes since v2:
> >> 1. Konrad's r-b tag for version patch
> >> 2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
> >> 3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all
> >> parameters at once, allowing to check all the configuration
> >> space.
> >> 4. Minor documentation cleanup (added missed "reserved" fields)
> >>
> >> Changes since v1:
> >>
> >> 1. Changed protocol version definition from string to integer,
> >> so it can easily be used in comparisons.
> >> Konrad, I have removed your r-b tag for the reason of this change.
> >>
> >> 2. In order to provide explicit stream parameter negotiation between
> >> backend and frontend the following changes are introduced in the protocol:
> >> add XENSND_OP_HW_PARAM_QUERY request to read/update
> >> configuration space for the parameter given: request passes
> >> desired parameter interval (mask) and the response to this request
> >> returns min/max interval (mask) for the parameter to be used.
> >>
> >> Parameters supported by this request/response:
> >>   - format mask
> >>   - sample rate interval
> >>   - number of channels interval
> >>   - buffer size, interval, frames
> >>   - period size, interval, frames
> > I can't judge exactly about the protocol without the actual FE/BE
> > implementations, but the change looks good to me, especially if you've
> > already tested something.
> Thank you, I have tested the changes and need them to start upstreaming
> the frontend driver used to test the protocol.
> Do you mind if I put your Acked-by (or you prefer Reviewed-by?) tag to
> these patches:
> 
> [PATCH v3 4/5] sndif: Add explicit back and front synchronization
> [PATCH v3 5/5] sndif: Add explicit back and front parameter negotiation

Sure, feel free to take my ack:
  Reviewed-by: Takashi Iwai 


Takashi

> 
> Please note, that the changes first to be merged into Xen and then
> I'll prepare
> the same, but for the kernel
> >
> > If other people have no concern, let's go ahead with FE/BE stuff.
> Konrad, are you ok with the changes?
> >
> > thanks,
> >
> > Takashi
> Thank you,
> Oleksandr
> 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-03-21 Thread Oleksandr Andrushchenko

On 03/20/2018 10:22 PM, Takashi Iwai wrote:

On Mon, 19 Mar 2018 08:22:19 +0100,
Oleksandr Andrushchenko wrote:

From: Oleksandr Andrushchenko 

Hello, all!

In order to provide explicit synchronization between backend and
frontend the following changes are introduced in the protocol:
  - bump protocol version to 2
  - add new ring buffer for sending asynchronous events from
backend to frontend to report number of bytes played by the
frontend (XENSND_EVT_CUR_POS)
  - introduce trigger events for playback control: start/stop/pause/resume
  - add "req-" prefix to event-channel and ring-ref to unify naming
of the Xen event channels for requests and events
  - add XENSND_OP_HW_PARAM_QUERY request to read/update
stream configuration space: request passes desired intervals/formats for
the stream parameters and the response returns allowed intervals and
formats mask that can be used.

Changes since v2:
1. Konrad's r-b tag for version patch
2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all
parameters at once, allowing to check all the configuration
space.
4. Minor documentation cleanup (added missed "reserved" fields)

Changes since v1:

1. Changed protocol version definition from string to integer,
so it can easily be used in comparisons.
Konrad, I have removed your r-b tag for the reason of this change.

2. In order to provide explicit stream parameter negotiation between
backend and frontend the following changes are introduced in the protocol:
add XENSND_OP_HW_PARAM_QUERY request to read/update
configuration space for the parameter given: request passes
desired parameter interval (mask) and the response to this request
returns min/max interval (mask) for the parameter to be used.

Parameters supported by this request/response:
  - format mask
  - sample rate interval
  - number of channels interval
  - buffer size, interval, frames
  - period size, interval, frames

I can't judge exactly about the protocol without the actual FE/BE
implementations, but the change looks good to me, especially if you've
already tested something.

Thank you, I have tested the changes and need them to start upstreaming
the frontend driver used to test the protocol.
Do you mind if I put your Acked-by (or you prefer Reviewed-by?) tag to 
these patches:


[PATCH v3 4/5] sndif: Add explicit back and front synchronization
[PATCH v3 5/5] sndif: Add explicit back and front parameter negotiation

Please note, that the changes first to be merged into Xen and then I'll 
prepare

the same, but for the kernel


If other people have no concern, let's go ahead with FE/BE stuff.

Konrad, are you ok with the changes?


thanks,

Takashi

Thank you,
Oleksandr

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-03-20 Thread Takashi Iwai
On Mon, 19 Mar 2018 08:22:19 +0100,
Oleksandr Andrushchenko wrote:
> 
> From: Oleksandr Andrushchenko 
> 
> Hello, all!
> 
> In order to provide explicit synchronization between backend and
> frontend the following changes are introduced in the protocol:
>  - bump protocol version to 2
>  - add new ring buffer for sending asynchronous events from
>backend to frontend to report number of bytes played by the
>frontend (XENSND_EVT_CUR_POS)
>  - introduce trigger events for playback control: start/stop/pause/resume
>  - add "req-" prefix to event-channel and ring-ref to unify naming
>of the Xen event channels for requests and events
>  - add XENSND_OP_HW_PARAM_QUERY request to read/update
>stream configuration space: request passes desired intervals/formats for
>the stream parameters and the response returns allowed intervals and
>formats mask that can be used.
> 
> Changes since v2:
> 1. Konrad's r-b tag for version patch
> 2. MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
> 3. Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all 
>parameters at once, allowing to check all the configuration
>space.
> 4. Minor documentation cleanup (added missed "reserved" fields)
> 
> Changes since v1:
> 
> 1. Changed protocol version definition from string to integer,
> so it can easily be used in comparisons.
> Konrad, I have removed your r-b tag for the reason of this change.
> 
> 2. In order to provide explicit stream parameter negotiation between
> backend and frontend the following changes are introduced in the protocol:
> add XENSND_OP_HW_PARAM_QUERY request to read/update
> configuration space for the parameter given: request passes
> desired parameter interval (mask) and the response to this request
> returns min/max interval (mask) for the parameter to be used.
> 
> Parameters supported by this request/response:
>  - format mask
>  - sample rate interval
>  - number of channels interval
>  - buffer size, interval, frames
>  - period size, interval, frames

I can't judge exactly about the protocol without the actual FE/BE
implementations, but the change looks good to me, especially if you've
already tested something.

If other people have no concern, let's go ahead with FE/BE stuff.


thanks,

Takashi

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel