Re: [Xen-devel] [PATCH v3 20/25] x86emul: correctly handle CMPXCHG* comparison failures

On 05/02/18 08:07, Jan Beulich wrote: > >>> + >>> +memcpy(p_old, , bytes); >> This is redundant with ... >> >>> + >>> +return rc; >>> } >>> >>> static const struct x86_emulate_ops hvm_shadow_emulator_ops = { >>> --- a/xen/arch/x86/mm/shadow/multi.c >>> +++

Re: [Xen-devel] [PATCH v3 20/25] x86emul: correctly handle CMPXCHG* comparison failures

>>> On 02.02.18 at 15:49, wrote: > On 07/12/17 14:15, Jan Beulich wrote: >> --- a/xen/arch/x86/mm/shadow/common.c >> +++ b/xen/arch/x86/mm/shadow/common.c >> @@ -302,8 +302,12 @@ hvm_emulate_cmpxchg(enum x86_segment seg >> memcpy(, p_old, bytes); >> memcpy(,

Re: [Xen-devel] [PATCH v3 20/25] x86emul: correctly handle CMPXCHG* comparison failures

On 07/12/17 14:15, Jan Beulich wrote: > If the ->cmpxchg() hook finds a mismatch, we should deal with this the > same way as when the "manual" comparison reports a mismatch. > > This involves reverting bfce0e62c3 ("x86/emul: Drop > X86EMUL_CMPXCHG_FAILED"), albeit with X86EMUL_CMPXCHG_FAILED now >