Re: [Xen-devel] [PATCH v3 21/25] x86emul: add read-modify-write hook

2018-02-05 Thread Andrew Cooper
On 05/02/18 08:22, Jan Beulich wrote: On 02.02.18 at 17:13, wrote: >> On 07/12/17 14:16, Jan Beulich wrote: >>> In order to correctly emulate read-modify-write insns, especially >>> LOCKed ones, we should not issue reads and writes separately. Use a >>> new hook to

Re: [Xen-devel] [PATCH v3 21/25] x86emul: add read-modify-write hook

2018-02-05 Thread Jan Beulich
>>> On 02.02.18 at 17:13, wrote: > On 07/12/17 14:16, Jan Beulich wrote: >> In order to correctly emulate read-modify-write insns, especially >> LOCKed ones, we should not issue reads and writes separately. Use a >> new hook to combine both, and don't uniformly read the

Re: [Xen-devel] [PATCH v3 21/25] x86emul: add read-modify-write hook

2018-02-02 Thread Andrew Cooper
On 07/12/17 14:16, Jan Beulich wrote: > In order to correctly emulate read-modify-write insns, especially > LOCKed ones, we should not issue reads and writes separately. Use a > new hook to combine both, and don't uniformly read the memory > destination anymore. Instead, DstMem opcodes without Mov