Re: [Xen-devel] [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration

2018-06-12 Thread Oleksandr Andrushchenko 

On 06/13/2018 01:07 AM, Dmitry Torokhov wrote:

On Tue, Jun 12, 2018 at 10:48:56AM +0300, Oleksandr Andrushchenko wrote:
  
+	if (!(with_kbd | with_ptr | with_mtouch)) {

I changed this to logical "OR" and applied, thank you.

Yes, that's better, thank you

+   ret = -ENXIO;
+   goto error;
+   }
+
ret = xenkbd_connect_backend(dev, info);
if (ret < 0)
goto error;
--
2.17.1




___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration

2018-06-12 Thread Dmitry Torokhov 
On Tue, Jun 12, 2018 at 10:48:56AM +0300, Oleksandr Andrushchenko wrote:
>  
> + if (!(with_kbd | with_ptr | with_mtouch)) {

I changed this to logical "OR" and applied, thank you.

> + ret = -ENXIO;
> + goto error;
> + }
> +
>   ret = xenkbd_connect_backend(dev, info);
>   if (ret < 0)
>   goto error;
> -- 
> 2.17.1
> 

-- 
Dmitry

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration

2018-06-12 Thread Juergen Gross 
On 12/06/18 09:48, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko 
> 
> It is now only possible to control if multi-touch virtual device
> is created or not (via the corresponding XenStore entries),
> but keyboard and pointer devices are always created.
> In some cases this is not desirable. For example, if virtual
> keyboard device is exposed to Android then the latter won't
> automatically show on-screen keyboard as it expects that a
> physical keyboard device can be used for typing.
> 
> Utilize keyboard and pointer device XenStore feature fields to
> configure which virtual devices are created:
>  - set "feature-disable-keyboard" to 1 if no keyboard device
>needs to be created
>  - set "feature-disable-pointer" to 1 if no pointer device
>needs to be created
> Keep old behavior by default.
> 
> Signed-off-by: Oleksandr Andrushchenko 
> Suggested-by: Andrii Chepurnyi 
> Tested-by: Andrii Chepurnyi 

Reviewed-by: Juergen Gross 


Juergen

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel