Re: [Xen-devel] [RFC v4 6/8] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-02-09 Thread Julien Grall
Hi, I am slightly confused. I receive your answer on this e-mail after you resend a version. So were the comments on RFC v4 was addressed? On 02/09/2018 05:56 PM, Sameer Goel wrote:     /* Request interrupt lines */   irq = smmu->evtq.q.irq; @@ -2316,9 +2782,13 @@ static int arm_smm

Re: [Xen-devel] [RFC v4 6/8] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-02-09 Thread Sameer Goel
On 1/23/2018 8:18 AM, Julien Grall wrote: > Hi Sameer, > > On 19/12/17 03:17, Sameer Goel wrote: >> +    if (!dtprop) >> +    return -EINVAL; >> + >> +    if (!dtprop->value) >> +    return -ENODATA; >> +    } >> + >> +    return ret; >> +} >> + >> +/* >> + * Xen: Helpers

Re: [Xen-devel] [RFC v4 6/8] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-01-23 Thread Julien Grall
Hi Sameer, On 19/12/17 03:17, Sameer Goel wrote: This driver follows an approach similar to smmu driver. The intent here is to reuse as much Linux code as possible. - Glue code has been introduced to bridge the API calls. - Called Linux functions from the Xen IOMMU function calls. - Xen modifica

Re: [Xen-devel] [RFC v4 6/8] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-01-16 Thread Julien Grall
Hi, On 16/01/18 12:37, Manish Jaggi wrote: On 01/16/2018 02:04 AM, Julien Grall wrote: On 01/03/2018 05:47 AM, Manish Jaggi wrote: +int devm_request_threaded_irq(struct device *dev, unsigned int irq, irq_handler_t handler, +  irq_handler_t thread_fn, unsigned long irqflags, + 

Re: [Xen-devel] [RFC v4 6/8] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-01-16 Thread Manish Jaggi
Hi Julien, On 01/16/2018 02:04 AM, Julien Grall wrote: On 01/03/2018 05:47 AM, Manish Jaggi wrote: Hi Sameer, Hi Manish, + +/* Xen: Type definitions for iommu_domain */ +#define IOMMU_DOMAIN_UNMANAGED 0 +#define IOMMU_DOMAIN_DMA 1 +#define IOMMU_DOMAIN_IDENTITY 2 + +/* Xen: Dummy iommu_

Re: [Xen-devel] [RFC v4 6/8] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-01-16 Thread Julien Grall
On 01/03/2018 05:47 AM, Manish Jaggi wrote: Hi Sameer, Hi Manish, + +/* Xen: Type definitions for iommu_domain */ +#define IOMMU_DOMAIN_UNMANAGED 0 +#define IOMMU_DOMAIN_DMA 1 +#define IOMMU_DOMAIN_IDENTITY 2 + +/* Xen: Dummy iommu_domain */ +struct iommu_domain { +    /* Runtime SMMU conf

Re: [Xen-devel] [RFC v4 6/8] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-01-02 Thread Manish Jaggi
Hi Sameer, Comments on this patch are only for nomenclature... On 12/19/2017 08:47 AM, Sameer Goel wrote: This driver follows an approach similar to smmu driver. The intent here is to reuse as much Linux code as possible. - Glue code has been introduced to bridge the API calls. - Called Linux