Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-15 Thread Wei Liu
On Mon, Oct 14, 2019 at 05:59:26PM +0100, Anthony PERARD wrote: > On Mon, Oct 14, 2019 at 05:09:24PM +0100, Ian Jackson wrote: > > Paul Durrant writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: > > Overhaul passthrough setting logic"): > > > On Fri,

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-14 Thread Anthony PERARD
On Mon, Oct 14, 2019 at 05:09:24PM +0100, Ian Jackson wrote: > Paul Durrant writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: > Overhaul passthrough setting logic"): > > On Fri, 11 Oct 2019 at 17:34, Ian Jackson wrote: > > > > > > Jürgen Groß

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-14 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): > On Mon, Oct 14, 2019 at 05:09:24PM +0100, Ian Jackson wrote: > > Bikeshed colour Paul Juergen George Ian Anthony Wei #already > > > > unknown

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-14 Thread Wei Liu
On Mon, Oct 14, 2019 at 05:09:24PM +0100, Ian Jackson wrote: > Paul Durrant writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: > Overhaul passthrough setting logic"): > > On Fri, 11 Oct 2019 at 17:34, Ian Jackson wrote: > > > > > > Jürgen Groß

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-14 Thread Ian Jackson
Paul Durrant writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): > On Fri, 11 Oct 2019 at 17:34, Ian Jackson wrote: > > > > Jürgen Groß writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: > >

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-14 Thread Paul Durrant
On Fri, 11 Oct 2019 at 17:34, Ian Jackson wrote: > > Jürgen Groß writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: > Overhaul passthrough setting logic"): > > On 11.10.19 15:31, Ian Jackson wrote: > > > I do not have a strong opinion about this.

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Ian Jackson
Jürgen Groß writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): > On 11.10.19 15:31, Ian Jackson wrote: > > I do not have a strong opinion about this. I would be happy with > > "auto" (or "default" mayb

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Jürgen Groß
On 11.10.19 15:31, Ian Jackson wrote: George Dunlap writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): On Thu, Oct 10, 2019 at 4:12 PM Ian Jackson wrote: LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): > libxl treats Arm guest as PVH now. Note that we seamlessly convert > PV to PVH in libxl__arch_domain_{build, create}_info_setdefault(). > > So as long as th

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): > On Thu, Oct 10, 2019 at 4:12 PM Ian Jackson wrote: > > LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted > > version of t

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread George Dunlap
On Thu, Oct 10, 2019 at 4:12 PM Ian Jackson wrote: > > LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted > version of this code) is doing double duty. We actually need all of > the following to be specificable: > * default ("unknown"): enable PT iff we have devices to > pas

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Julien Grall
Hi, On 11/10/2019 10:47, Andrew Cooper wrote: On 10/10/2019 16:11, Ian Jackson wrote: diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index 69971c97b6..fccb6a6271 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -968,6 +957,50 @@ int libxl__domain

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Ian Jackson
Andrew Cooper writes ("Re: [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): > On 10/10/2019 16:11, Ian Jackson wrote: > > +if (c_info->passthrough == LIBXL_PASSTHROUGH_DISABLED && need_pt) { > > +LOGD(ERROR, domid, > > + "passthrough disabled but

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Andrew Cooper
On 10/10/2019 16:11, Ian Jackson wrote: > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > index 69971c97b6..fccb6a6271 100644 > --- a/tools/libxl/libxl_create.c > +++ b/tools/libxl/libxl_create.c > @@ -968,6 +957,50 @@ int libxl__domain_config_setdefault(libxl__gc *gc, >

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Wei Liu
On Thu, Oct 10, 2019 at 04:11:11PM +0100, Ian Jackson wrote: > LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted > version of this code) is doing double duty. We actually need all of > the following to be specificable: > * default ("unknown"): enable PT iff we have devices to >