Re: [Xen-ia64-devel] [PATCH] xenctx, add dummy print_stack()

[Tristan Gingold]

Le Lundi 19 Juin 2006 23:07, Alex Williamson a écrit :
The patch below consolidates the NO_TRANSLATION xenctx code to avoid
 additional #ifdef/#endif code blocks.  Comments?  Thanks,
Sure it's better !

Tristan.

___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

[Xen-ia64-devel] [PATCH] xenctx, add dummy print_stack()

[Alex Williamson]

   The patch below consolidates the NO_TRANSLATION xenctx code to avoid
additional #ifdef/#endif code blocks.  Comments?  Thanks,

Alex

-- 
Alex Williamson HP Open Source  Linux Org.
# HG changeset patch
# User [EMAIL PROTECTED]
# Node ID c974a6e3f517e695521e49bb767663631a2b8364
# Parent  ea306829506c657565937916d0922aeab211f494
[IA64] dummy print_stack() func for NO_TRANSLATION path

Signed-off-by: Alex Williamson [EMAIL PROTECTED]

diff -r ea306829506c -r c974a6e3f517 tools/xentrace/xenctx.c
--- a/tools/xentrace/xenctx.c	Mon Jun 19 13:45:42 2006 -0600
+++ b/tools/xentrace/xenctx.c	Mon Jun 19 14:55:13 2006 -0600
@@ -428,6 +428,8 @@ void print_stack(vcpu_guest_context_t *c
 }
 }
 }
+#else
+#define print_stack(ctx, vcpu)
 #endif
 
 void dump_ctx(int vcpu)
@@ -451,10 +453,8 @@ void dump_ctx(int vcpu)
 }
 
 print_ctx(ctx);
-#ifndef NO_TRANSLATION
 if (is_kernel_text(INSTR_POINTER((ctx.user_regs
 print_stack(ctx, vcpu);
-#endif
 
 ret = xc_domain_unpause(xc_handle, domid);
 if (ret  0) {
___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] xenctx, add dummy print_stack()

[Akio Takebe]

Hi, Alex

How about my patch?
I remove NO_TRANSLATION. NO_TRANSLATION is used by only ia64.

Signed-off-by: Akio Takebe [EMAIL PROTECTED]

Best Regards,

Akio Takebe


   The patch below consolidates the NO_TRANSLATION xenctx code to avoid
additional #ifdef/#endif code blocks.  Comments?  Thanks,

   Alex

-- 
Alex Williamson HP Open Source  Linux Org.

---text/plain---
___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel


cleanup_xenctx.patch
Description: Binary data
___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] xenctx, add dummy print_stack()

[Akio Takebe]

Hi, Alex

I also actually think your patch is better.
I only proposed another way. :-)

Best Regards,

Akio Takebe

On Tue, 2006-06-20 at 10:00 +0900, Akio Takebe wrote:
 Hi, Alex
 
 How about my patch?
 I remove NO_TRANSLATION. NO_TRANSLATION is used by only ia64.

Hi Akio,

   I actually prefer the NO_TRANSLATION define instead of using an
architecture define.  It's a bit more generic.  I just thought it might
be nice to get rid of the one extra #ifdef/#endif around the call to
print_stack().  Thanks,

   Alex

-- 
Alex Williamson HP Open Source  Linux Org.



___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel