Re: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
On Thu, 2008-12-11 at 11:05 +0900, Isaku Yamahata wrote: Just to make sure. Is fpswa.efi installed in hvm domain? You can also confirm it by dh command in efi shell. Argh, that was it. I loaded fpswa.efi into my EFI partition after the tests started failing, but I didn't have it in the right location for elilo to pick it up automatically. Running load fpswa.efi makes it work, and copying fpswa.efi to \efi\intel firmware\fpswa.efi also works. I'll add your panic fix and let it run for a while, seems like it's running well now. Thanks, Alex -- Alex Williamson HP Open Source Linux Org. ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Re: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
On Thu, 2008-12-11 at 09:04 -0700, Alex Williamson wrote: On Thu, 2008-12-11 at 11:05 +0900, Isaku Yamahata wrote: Just to make sure. Is fpswa.efi installed in hvm domain? You can also confirm it by dh command in efi shell. Argh, that was it. I loaded fpswa.efi into my EFI partition after the tests started failing, but I didn't have it in the right location for elilo to pick it up automatically. Running load fpswa.efi makes it work, and copying fpswa.efi to \efi\intel firmware\fpswa.efi also works. I'll add your panic fix and let it run for a while, seems like it's running well now. Thanks, One other comment on the patches, I'd recommend removing both instances of this: printk(ia64_handle_reflection: handling FP trap\n); from ia64_handle_reflection(). If we're properly handling the trap, this is just unnecessary noise. Thanks, Alex -- Alex Williamson HP Open Source Linux Org. ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Re: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
On Thu, Dec 11, 2008 at 09:07:15AM -0700, Alex Williamson wrote: On Thu, 2008-12-11 at 09:04 -0700, Alex Williamson wrote: On Thu, 2008-12-11 at 11:05 +0900, Isaku Yamahata wrote: Just to make sure. Is fpswa.efi installed in hvm domain? You can also confirm it by dh command in efi shell. Argh, that was it. I loaded fpswa.efi into my EFI partition after the tests started failing, but I didn't have it in the right location for elilo to pick it up automatically. Running load fpswa.efi makes it work, and copying fpswa.efi to \efi\intel firmware\fpswa.efi also works. I'll add your panic fix and let it run for a while, seems like it's running well now. Thanks, Thank you for testing. I'll commit my patches with some clean up. One other comment on the patches, I'd recommend removing both instances of this: printk(ia64_handle_reflection: handling FP trap\n); from ia64_handle_reflection(). If we're properly handling the trap, this is just unnecessary noise. Thanks, Agreed. It should be quietened somehow. -- yamahata ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
RE: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
Isaku Yamahata wrote: On Thu, Dec 11, 2008 at 09:07:15AM -0700, Alex Williamson wrote: On Thu, 2008-12-11 at 09:04 -0700, Alex Williamson wrote: On Thu, 2008-12-11 at 11:05 +0900, Isaku Yamahata wrote: Just to make sure. Is fpswa.efi installed in hvm domain? You can also confirm it by dh command in efi shell. Argh, that was it. I loaded fpswa.efi into my EFI partition after the tests started failing, but I didn't have it in the right location for elilo to pick it up automatically. Running load fpswa.efi makes it work, and copying fpswa.efi to \efi\intel firmware\fpswa.efi also works. I'll add your panic fix and let it run for a while, seems like it's running well now. Thanks, Thank you for testing. I'll commit my patches with some clean up. One other comment on the patches, I'd recommend removing both instances of this: printk(ia64_handle_reflection: handling FP trap\n); from ia64_handle_reflection(). If we're properly handling the trap, this is just unnecessary noise. Thanks, Agreed. It should be quietened somehow. Good news indeed! Xiantao ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Re: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
On Fri, 2008-12-12 at 10:22 +0900, Isaku Yamahata wrote: Thank you for testing. I'll commit my patches with some clean up. Testing update; I've had 2 PV domains, 2 HVM domains, and dom0 all running the test program for over 10 hours. Everything looks good. Thanks, Alex -- Alex Williamson HP Open Source Linux Org. ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Re: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
On Tue, 2008-12-09 at 21:23 -0700, Alex Williamson wrote: On Wed, 2008-12-10 at 10:51 +0800, Zhang, Xiantao wrote: I've been testing this for a few hours today (over 25k iterations) and it seems to fix the problem for me. Thanks! Hi, Alex Have you verified vmx domain as well ? Good point, no I was just testing in dom0. Adding in Isaku's last patch and testing on an HVM domain, it doesn't take long to hit problems. 4-way/4G HVM guest running 4 instances of the test program in parallel will eventually get this in the guest kernel: handle_fpu_swa: fp_emulate() returned -1 and the test program gets killed with a SIGFPE. -- Alex Williamson HP Open Source Linux Org. ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Re: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
On Wed, Dec 10, 2008 at 10:43:01AM -0700, Alex Williamson wrote: On Tue, 2008-12-09 at 21:23 -0700, Alex Williamson wrote: On Wed, 2008-12-10 at 10:51 +0800, Zhang, Xiantao wrote: I've been testing this for a few hours today (over 25k iterations) and it seems to fix the problem for me. Thanks! Hi, Alex Have you verified vmx domain as well ? Good point, no I was just testing in dom0. Adding in Isaku's last patch and testing on an HVM domain, it doesn't take long to hit problems. 4-way/4G HVM guest running 4 instances of the test program in parallel will eventually get this in the guest kernel: handle_fpu_swa: fp_emulate() returned -1 and the test program gets killed with a SIGFPE. Just to make sure. Is fpswa.efi installed in hvm domain? You can also confirm it by dh command in efi shell. -- yamahata ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
RE: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
Isaku Yamahata wrote: On Wed, Dec 10, 2008 at 10:43:01AM -0700, Alex Williamson wrote: On Tue, 2008-12-09 at 21:23 -0700, Alex Williamson wrote: On Wed, 2008-12-10 at 10:51 +0800, Zhang, Xiantao wrote: I've been testing this for a few hours today (over 25k iterations) and it seems to fix the problem for me. Thanks! Hi, Alex Have you verified vmx domain as well ? Good point, no I was just testing in dom0. Adding in Isaku's last patch and testing on an HVM domain, it doesn't take long to hit problems. 4-way/4G HVM guest running 4 instances of the test program in parallel will eventually get this in the guest kernel: handle_fpu_swa: fp_emulate() returned -1 and the test program gets killed with a SIGFPE. Just to make sure. Is fpswa.efi installed in hvm domain? You can also confirm it by dh command in efi shell. Yes, I think it should be installed by default in OS distros. Before handing the trap in hypervisor, all traps are injected to guests, and handing it in hypervisor is just an optimization. Xiantao ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Re: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
On Thu, Dec 11, 2008 at 10:14:12AM +0800, Zhang, Xiantao wrote:
Isaku Yamahata wrote:
On Wed, Dec 10, 2008 at 10:43:01AM -0700, Alex Williamson wrote:
On Tue, 2008-12-09 at 21:23 -0700, Alex Williamson wrote:
On Wed, 2008-12-10 at 10:51 +0800, Zhang, Xiantao wrote:
I've been testing this for a few hours today (over 25k
iterations) and it seems to fix the problem for me. Thanks!
Hi, Alex
Have you verified vmx domain as well ?
Good point, no I was just testing in dom0.
Adding in Isaku's last patch and testing on an HVM domain, it doesn't
take long to hit problems. 4-way/4G HVM guest running 4 instances of
the test program in parallel will eventually get this in the guest
kernel:
handle_fpu_swa: fp_emulate() returned -1
and the test program gets killed with a SIGFPE.
Just to make sure. Is fpswa.efi installed in hvm domain?
You can also confirm it by dh command in efi shell.
Yes, I think it should be installed by default in OS distros. Before handing
the trap in hypervisor, all traps are injected to guests, and handing it in
hypervisor is just an optimization.
Yeah.
Although I haven't been able to reproduce, what I essentially touched
for HVM domain is only the following hunk.
So I'm suspecting hidden bug or missing fpswa.efi.
diff --git a/xen/arch/ia64/vmx/vmx_fault.c b/xen/arch/ia64/vmx/vmx_fault.c
--- a/xen/arch/ia64/vmx/vmx_fault.c
+++ b/xen/arch/ia64/vmx/vmx_fault.c
@@ -122,8 +122,7 @@ void vmx_reflect_interruption(u64 ifa, u
if (!status) {
vcpu_increment_iip(vcpu);
return;
-} else if (IA64_RETRY == status)
-return;
+}
break;
case 33: // IA64_FP_TRAP_VECTOR
@@ -133,10 +132,6 @@ void vmx_reflect_interruption(u64 ifa, u
status = handle_fpu_swa(0, regs, isr);
if (!status)
return;
-else if (IA64_RETRY == status) {
-vcpu_decrement_iip(vcpu);
-return;
-}
break;
case 29: // IA64_DEBUG_VECTOR
--
yamahata
___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel
[Xen-ia64-devel] Re: [PATCH 0/5] fix fpswa and related issues.
On Tue, 2008-12-09 at 18:29 +0900, Isaku Yamahata wrote: Hi. This patch series addresses the bug reported as http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1392 Please test it. It includes some clean ups and a reimplementation of fpswa hypercall. When fp fault/trap occurs, xen vmm tries to get a bundle in question from guest virtual address space. It sometimes fails because of I/D tlb cache. In that case inject the fault/trap into a guest and let a guest to call fpswa hypercall. Hi Isaku, I've been testing this for a few hours today (over 25k iterations) and it seems to fix the problem for me. Thanks! Alex -- Alex Williamson HP Open Source Linux Org. ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
[Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
Alex Williamson wrote: On Tue, 2008-12-09 at 18:29 +0900, Isaku Yamahata wrote: Hi. This patch series addresses the bug reported as http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1392 Please test it. It includes some clean ups and a reimplementation of fpswa hypercall. When fp fault/trap occurs, xen vmm tries to get a bundle in question from guest virtual address space. It sometimes fails because of I/D tlb cache. In that case inject the fault/trap into a guest and let a guest to call fpswa hypercall. Hi Isaku, I've been testing this for a few hours today (over 25k iterations) and it seems to fix the problem for me. Thanks! Hi, Alex Have you verified vmx domain as well ? Xiantao ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
[Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
On Wed, 2008-12-10 at 10:51 +0800, Zhang, Xiantao wrote: I've been testing this for a few hours today (over 25k iterations) and it seems to fix the problem for me. Thanks! Hi, Alex Have you verified vmx domain as well ? Good point, no I was just testing in dom0. Alex -- Alex Williamson HP Open Source Linux Org. ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Re: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.
On Tue, Dec 09, 2008 at 09:23:01PM -0700, Alex Williamson wrote: On Wed, 2008-12-10 at 10:51 +0800, Zhang, Xiantao wrote: I've been testing this for a few hours today (over 25k iterations) and it seems to fix the problem for me. Thanks! Hi, Alex Have you verified vmx domain as well ? Good point, no I was just testing in dom0. You may want to test with two PV guest because of eager safe/lazy restore fp. I wrote the code to address it, but it hasn't been tested very well. -- yamahata ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
