[Xen-ia64-devel] Re: [PATCH] kexec: framework and i386 (Take XIV)

2006-09-01 Thread Akio Takebe
Hi, Horms That seems like a good idea to me. Though I think you are missing { }. Can you test to see if this works? Oops, You're right. But I think unknown_nmi_error() is not called, because crash_kexec() is called before that. Yes, I'll test it. :-) --- a/xen/arch/x86/traps.c 2006-09-01

[Xen-ia64-devel] Re: [PATCH] kexec: framework and i386 (Take XIV)

2006-08-31 Thread Akio Takebe
Hi, Horms and Magnus Good work. :-) I have one commet. I believe crash_kexec should be directly called when unknown NMI is occurred. In your patch, crash_kexec is called as the bellow. 1. unknown NMI is occurred. (e.g. by pushing NMI botton) 2. xen recieved NMI and call do_nmi. 3. xen