RE: [Xen-ia64-devel] Fix a missing return value check.

2009-03-26 Thread Zhang, Xiantao
We had better push it into Xen's next release. 
Xiantao

Isaku Yamahata wrote:
> Hi, thank you for the patch.
> 
> This is for xen-unstable.hg? not for xen-ia64-unstable.hg.
> xen-ia64-unstable.hg already has the change set of 19207:c4c4ba857d8b
> which includes your patch.
> 
> Is this for the next release? Then, I'll request Keir to pull the
> ia64 repo. 
> 
> thanks,
> 
> 
> On Thu, Mar 26, 2009 at 02:12:02PM +0800, Zhang, Xiantao wrote:
>> Fixed the missing return value check.
>> 
>> Signed-off-by: Xiantao Zhang 
>> 
>> diff -r b432c632ebe8 xen/arch/ia64/linux-xen/irq_ia64.c
>> --- a/xen/arch/ia64/linux-xen/irq_ia64.c Fri Feb 13 19:11:38 2009
>> +0900 +++ b/xen/arch/ia64/linux-xen/irq_ia64.c   Thu Mar 26 14:04:41
>> 2009 +0800 @@ -295,7 +295,7 @@ int request_irq_vector(unsigned int
>>  vectaction->handler = handler; action->name = devname;
>>  action->dev_id = dev_id;
>> -setup_vector(vector, action);
>> +retval = setup_vector(vector, action);
>>  if (retval)
>>  xfree(action);
>> 
> 
>> ___
>> Xen-ia64-devel mailing list
>> Xen-ia64-devel@lists.xensource.com
>> http://lists.xensource.com/xen-ia64-devel


___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel


Re: [Xen-ia64-devel] Fix a missing return value check.

2009-03-25 Thread Isaku Yamahata
Hi, thank you for the patch.

This is for xen-unstable.hg? not for xen-ia64-unstable.hg.
xen-ia64-unstable.hg already has the change set of 19207:c4c4ba857d8b which
includes your patch.

Is this for the next release? Then, I'll request Keir to pull the ia64 repo.

thanks,


On Thu, Mar 26, 2009 at 02:12:02PM +0800, Zhang, Xiantao wrote:
> Fixed the missing return value check.
> 
> Signed-off-by: Xiantao Zhang 
> 
> diff -r b432c632ebe8 xen/arch/ia64/linux-xen/irq_ia64.c
> --- a/xen/arch/ia64/linux-xen/irq_ia64.c  Fri Feb 13 19:11:38 2009 +0900
> +++ b/xen/arch/ia64/linux-xen/irq_ia64.c  Thu Mar 26 14:04:41 2009 +0800
> @@ -295,7 +295,7 @@ int request_irq_vector(unsigned int vect
>   action->handler = handler;
>   action->name = devname;
>   action->dev_id = dev_id;
> - setup_vector(vector, action);
> + retval = setup_vector(vector, action);
>   if (retval)
>   xfree(action);
>  

> ___
> Xen-ia64-devel mailing list
> Xen-ia64-devel@lists.xensource.com
> http://lists.xensource.com/xen-ia64-devel

-- 
yamahata

___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel


[Xen-ia64-devel] Fix a missing return value check.

2009-03-25 Thread Zhang, Xiantao
Fixed the missing return value check.

Signed-off-by: Xiantao Zhang 

diff -r b432c632ebe8 xen/arch/ia64/linux-xen/irq_ia64.c
--- a/xen/arch/ia64/linux-xen/irq_ia64.cFri Feb 13 19:11:38 2009 +0900
+++ b/xen/arch/ia64/linux-xen/irq_ia64.cThu Mar 26 14:04:41 2009 +0800
@@ -295,7 +295,7 @@ int request_irq_vector(unsigned int vect
action->handler = handler;
action->name = devname;
action->dev_id = dev_id;
-   setup_vector(vector, action);
+   retval = setup_vector(vector, action);
if (retval)
xfree(action);
 

check_ret_value_for_setup_vector.patch
Description: check_ret_value_for_setup_vector.patch
___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel