RE: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-20 Thread Xu, Anthony
Isaku Yamahata wrote: On Fri, Oct 17, 2008 at 05:36:58PM +0800, Xu, Anthony wrote: It's correct that xen VMM doesn't fully understand io area. However the VMM know all about RAM. Thanks for your explanation, see my comment. So far !mfn_valid() has sufficed for the current implementation

Re: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-20 Thread Isaku Yamahata
On Mon, Oct 20, 2008 at 02:49:57PM +0800, Xu, Anthony wrote: Isaku Yamahata wrote: On Fri, Oct 17, 2008 at 05:36:58PM +0800, Xu, Anthony wrote: It's correct that xen VMM doesn't fully understand io area. However the VMM know all about RAM. Thanks for your explanation, see my comment.

RE: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-20 Thread Xu, Anthony
Isaku Yamahata wrote: On Mon, Oct 20, 2008 at 02:49:57PM +0800, Xu, Anthony wrote: Isaku Yamahata wrote: On Fri, Oct 17, 2008 at 05:36:58PM +0800, Xu, Anthony wrote: It's correct that xen VMM doesn't fully understand io area. However the VMM know all about RAM. Thanks for your explanation,

Re: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-19 Thread Isaku Yamahata
On Fri, Oct 17, 2008 at 05:36:58PM +0800, Xu, Anthony wrote: Isaku Yamahata wrote: On Fri, Oct 17, 2008 at 05:58:45PM +0900, Isaku Yamahata wrote: On Fri, Oct 17, 2008 at 04:45:09PM +0800, Xu, Anthony wrote: Hi isaku, If I remembered correctly, last time I encountered issue at line

RE: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-17 Thread Xu, Anthony
Isaku Yamahata wrote: On Thu, Oct 16, 2008 at 07:37:51PM +0800, Xu, Anthony wrote: use VTD to assing device, guest port may not be equal to host port. Change ioports_permit_access interface add deassign_domain_mmio_page interface Signed-off-by; Anthony Xu [EMAIL PROTECTED] Some comments.

Re: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-17 Thread Isaku Yamahata
On Fri, Oct 17, 2008 at 03:22:18PM +0800, Xu, Anthony wrote: Isaku Yamahata wrote: On Thu, Oct 16, 2008 at 07:37:51PM +0800, Xu, Anthony wrote: use VTD to assing device, guest port may not be equal to host port. Change ioports_permit_access interface add deassign_domain_mmio_page

RE: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-17 Thread Xu, Anthony
Isaku Yamahata wrote: In x86 side, only it is identity mapping, guest can access the port directly. If it is not identity mapping, guest can not access the port directly, at this situation, xen will intercept io port access first, and xen access the corresponding physical port. In ia64

[PATCH]RE: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-17 Thread Xu, Anthony
use VTD to assing device, guest port may not be equal to host port. Change ioports_permit_access interface Signed-off-by; Anthony Xu [EMAIL PROTECTED] Isaku Yamahata wrote: On Fri, Oct 17, 2008 at 03:22:18PM +0800, Xu, Anthony wrote: Isaku Yamahata wrote: On Thu, Oct 16, 2008 at

RE: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-17 Thread Xu, Anthony
Hi isaku, If I remembered correctly, last time I encountered issue at line page = mfn_to_page(mfn); Page returns 0. I suspect if page_info for IOPORTs is initialized. Any idea? Thanks, Anthony mm_teardown_pte(struct domain* d, volatile pte_t* pte, unsigned long offset) { pte_t old_pte;

Re: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-17 Thread Isaku Yamahata
On Fri, Oct 17, 2008 at 04:45:09PM +0800, Xu, Anthony wrote: Hi isaku, If I remembered correctly, last time I encountered issue at line page = mfn_to_page(mfn); Page returns 0. Which line do you have trouble? Do you mean that mfn_to_page(mfn) returned NULL? or Did you hit

Re: [PATCH]RE: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-17 Thread Isaku Yamahata
Applied, thanks. On Fri, Oct 17, 2008 at 04:17:08PM +0800, Xu, Anthony wrote: use VTD to assing device, guest port may not be equal to host port. Change ioports_permit_access interface Signed-off-by; Anthony Xu [EMAIL PROTECTED] Isaku Yamahata wrote: On Fri, Oct 17, 2008 at

RE: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-17 Thread Xu, Anthony
Isaku Yamahata wrote: On Fri, Oct 17, 2008 at 05:58:45PM +0900, Isaku Yamahata wrote: On Fri, Oct 17, 2008 at 04:45:09PM +0800, Xu, Anthony wrote: Hi isaku, If I remembered correctly, last time I encountered issue at line page = mfn_to_page(mfn); Page returns 0. Which line do you have

Re: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-17 Thread Isaku Yamahata
On Fri, Oct 17, 2008 at 05:58:45PM +0900, Isaku Yamahata wrote: On Fri, Oct 17, 2008 at 04:45:09PM +0800, Xu, Anthony wrote: Hi isaku, If I remembered correctly, last time I encountered issue at line page = mfn_to_page(mfn); Page returns 0. Which line do you have trouble? Do you

RE: [Xen-ia64-devel][PATCH][VTD]change ioports_permit_access interface

2008-10-17 Thread Xu, Anthony
Isaku Yamahata wrote: On Fri, Oct 17, 2008 at 04:45:09PM +0800, Xu, Anthony wrote: Hi isaku, If I remembered correctly, last time I encountered issue at line page = mfn_to_page(mfn); Page returns 0. Which line do you have trouble? Do you mean that mfn_to_page(mfn) returned NULL? Yes it