Re: [Xen-ia64-devel][PATCH]a virt_to_maddr fix

2008-10-17 Thread Isaku Yamahata
applied, thanks. On Thu, Oct 16, 2008 at 06:02:28PM +0800, Xu, Anthony wrote: > Putting IA64_MAX_PHYS_BITS to pgtable.h is to avoid compilation error. > > Anthony > > Isaku Yamahata wrote: > > Yes, IA64_MAX_PHYS_BITS makes sense. > > It seems better that the comment is in xenpage.h. > > > > Did

RE: [Xen-ia64-devel][PATCH]a virt_to_maddr fix

2008-10-16 Thread Xu, Anthony
Putting IA64_MAX_PHYS_BITS to pgtable.h is to avoid compilation error. Anthony Isaku Yamahata wrote: > Yes, IA64_MAX_PHYS_BITS makes sense. > It seems better that the comment is in xenpage.h. > > Did you compile it? I got the following. > (note:crash_debug=y verbose=y vti_debug=y debug=y perfc=y

Re: [Xen-ia64-devel][PATCH]a virt_to_maddr fix

2008-10-15 Thread Isaku Yamahata
Yes, IA64_MAX_PHYS_BITS makes sense. It seems better that the comment is in xenpage.h. Did you compile it? I got the following. (note:crash_debug=y verbose=y vti_debug=y debug=y perfc=y perfc_arrays=y) ia64-linux-gnu-gcc -O1 -fno-optimize-sibling-calls -g -fno-strict-aliasing -std=gnu99 -Wall -W

RE: [Xen-ia64-devel][PATCH]a virt_to_maddr fix

2008-10-15 Thread Xu, Anthony
Updated one per your comments Anthony Isaku Yamahata wrote: > On Mon, Oct 13, 2008 at 03:29:54PM +0800, Xu, Anthony wrote: >> virt_to_maddr fix >> The significant 8 bits of va are used by Xen, >> such as 0xf2 is used as uncache mapping. >> >> In function ioports_permit_access, >> mach_start = m

Re: [Xen-ia64-devel][PATCH]a virt_to_maddr fix

2008-10-15 Thread Isaku Yamahata
On Mon, Oct 13, 2008 at 03:29:54PM +0800, Xu, Anthony wrote: > virt_to_maddr fix > The significant 8 bits of va are used by Xen, > such as 0xf2 is used as uncache mapping. > > In function ioports_permit_access, > mach_start = mmio_start | __pa(space->mmio_base); > Mach_start gets wrong physical a