Re: [XenPPC] Re: [Xen-devel] [PATCH 6 of 6] [XEN][LINUX] Add 32-bit privcmd ioctlconversion for 64-b
Which structures do you think need further conversion? We've already fixed all the shared structures (e.g. sysctl) to use explicitly-sized types, so the PowerPC port has always had proper interfaces. For example, look at the definition of xen_ulong_t on the different architectures. The x86 interfaces were frozen too early, cementing this problem for you. Oh, sorry, I forgot that you had this taken care of implicitly on PPC. I had hoped we could leverage the code you are adding for x86, but - no luck. Jan ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
[XenPPC] Re: [Xen-devel] [PATCH 2 of 6] [XEN][LINUX] Create Xen-specificinterface for xlate_dev_mem_*
--- a/include/asm-i386/mach-xen/asm/io.h Thu Jul 05 16:58:26 2007 -0500 +++ b/include/asm-i386/mach-xen/asm/io.h Thu Jul 05 16:58:26 2007 -0500 @@ -53,8 +53,8 @@ * Convert a physical pointer to a virtual kernel pointer for /dev/mem * access */ -#define xlate_dev_mem_ptr(p, sz) ioremap(p, sz) -#define xlate_dev_mem_ptr_unmap(p)iounmap(p) +#define xen_xlate_dev_mem_ptr(p, sz) ioremap(p, sz) +#define xen_xlate_dev_mem_ptr_unmap(p)iounmap(p) /* * Convert a virtual cached pointer to an uncached pointer Isn't the same adjustment needed to include/asm-x86_64/mach-xen/asm/io.h? Jan ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
[XenPPC] Re: [Xen-devel] [PATCH 5 of 6] [XEN][LINUX] Refactor grant tableallocation into arch-specific code
--- a/drivers/xen/core/gnttab.cThu Jul 05 16:58:26 2007 -0500
+++ b/drivers/xen/core/gnttab.cThu Jul 05 17:25:47 2007 -0500
@@ -430,7 +430,7 @@ static inline unsigned int max_nr_grant_
#ifdef CONFIG_XEN
-#ifndef __ia64__
+#ifdef __x86__
static int map_pte_fn(pte_t *pte, struct page *pmd_page,
unsigned long addr, void *data)
{
#ifdef CONFIG_X86, just like you did one or two hunks later?
Jan
___
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel
Re: [XenPPC] Re: [Xen-devel] [PATCH 6 of 6] [XEN][LINUX] Add 32-bit privcmd ioctlconversion for 64-b
Hollis Blanchard [EMAIL PROTECTED] 06.07.07 17:44 Where does the hypercall argument translation happen? It happens inside privcmd_hypercall(). See http://xenbits.xensource.com/ext/linux-ppc-2.6.hg?file/04f6ad5d9232/arch/powerpc/platforms/xen/hcall.c (In that tree, the function is named arch_privcmd_hypercall.) IA64 and PPC both implement this function now; only x86 is left with #ifdefs in drivers/xen/privcmd/privcmd.c . COMPATIBLE_IOCTL is just about the ioctl itself, not the sub-structures. Hmm, I can't really see any structures being translated there, all I see is guest handles getting dereferenced. So I'm still unclear where you do the 32-bit layout to 64-bit layout conversion, but obviously I must be missing something. Jan ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
[XenPPC] [Xen-devel] Re: [patch] make ELF functions static
Ian Campbell [EMAIL PROTECTED] 30.08.06 09:03 On Tue, 2006-08-29 at 16:15 -0500, Hollis Blanchard wrote: Hi Ian, these functions should be static. It would only be a style issue except PowerPC actually #includes elf.c twice, to support both 32- and 64-bit ELF binaries. Please apply. Unfortunately they are referenced from outside this file (xen/arch/x86/domain_build.c). I'm not sure what a good short term fix for you would be. Perhaps some preprocessor/CFLAGS magic to name them xen_elfnote32_foo and xen_elfnote64_foo when compiling powerpc? Hopefully long term the 32-on-64 work that is going on will lead to ELF code which doesn't need to be multiply compiled. Why? It's simpler to compile it twice. I already posted draft patches to do this, simply introducing an elf32.c that #define-s the relevant symbols to alternative names and that only gets compiled when 64-bit arches need it for supporting 32-bit binaries. Jan ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
