Re: [XenPPC] [PATCH] [RFC] Xencomm patch to fix modules

2007-01-19 Thread Hollis Blanchard
On Thu, 2007-01-18 at 17:16 -0500, Jimi Xenidis wrote: On Jan 18, 2007, at 4:26 PM, Hollis Blanchard wrote: On Thu, 2007-01-18 at 16:18 -0500, Jimi Xenidis wrote: Hey, wouldn't virt_addr_valid() do? I can pass a perfectly valid virtual address that is within a physically

Re: [XenPPC] [PATCH] [RFC] Xencomm patch to fix modules

2007-01-18 Thread Hollis Blanchard
On Wed, 2007-01-17 at 21:20 -0600, Jerone Young wrote: I haven't had a chance to fully test this patch. As I have been having problems with my blade today. But here is the code for review. I'll get back to the list once it is fully tested. This looks pretty good; just a couple issues left...

Re: [XenPPC] [PATCH] [RFC] Xencomm patch to fix modules

2007-01-18 Thread Jimi Xenidis
On Jan 18, 2007, at 1:55 PM, Hollis Blanchard wrote: On Thu, 2007-01-18 at 12:17 -0500, Jimi Xenidis wrote: I agree with most of Hollis's comments, but have some of my own. First, I do not think that the implementation of is_phys_contiguous() answers the question in its name and IMNSHO is

Re: [XenPPC] [PATCH] [RFC] Xencomm patch to fix modules

2007-01-18 Thread Hollis Blanchard
On Thu, 2007-01-18 at 16:18 -0500, Jimi Xenidis wrote: On Jan 18, 2007, at 1:55 PM, Hollis Blanchard wrote: On Thu, 2007-01-18 at 12:17 -0500, Jimi Xenidis wrote: I agree with most of Hollis's comments, but have some of my own. First, I do not think that the implementation of

Re: [XenPPC] [PATCH] [RFC] Xencomm patch to fix modules

2007-01-18 Thread Jimi Xenidis
On Jan 18, 2007, at 4:26 PM, Hollis Blanchard wrote: On Thu, 2007-01-18 at 16:18 -0500, Jimi Xenidis wrote: Hey, wouldn't virt_addr_valid() do? I can pass a perfectly valid virtual address that is within a physically discontiguous area of memory, and this function would return 0. hmm,

[XenPPC] [PATCH] [RFC] Xencomm patch to fix modules

2007-01-17 Thread Jerone Young
I haven't had a chance to fully test this patch. As I have been having problems with my blade today. But here is the code for review. I'll get back to the list once it is fully tested. Signed-off-by: Jerone Young [EMAIL PROTECTED] diff -r e5962db17966 arch/powerpc/platforms/xen/gnttab.c ---