Re: [XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-16 Thread Ryan Harper
* Hollis Blanchard [EMAIL PROTECTED] [2007-01-15 20:44]: On Mon, 2007-01-15 at 21:29 -0500, Jimi Xenidis wrote: On Jan 15, 2007, at 8:20 PM, Hollis Blanchard wrote: On Mon, 2007-01-15 at 17:25 -0500, Jimi Xenidis wrote: +int make_devtree( [snip] Any ideas what this reservation is

Re: [XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-16 Thread Jimi Xenidis
On Jan 16, 2007, at 10:05 AM, Ryan Harper wrote: * Hollis Blanchard [EMAIL PROTECTED] [2007-01-15 20:44]: On Mon, 2007-01-15 at 21:29 -0500, Jimi Xenidis wrote: On Jan 15, 2007, at 8:20 PM, Hollis Blanchard wrote: On Mon, 2007-01-15 at 17:25 -0500, Jimi Xenidis wrote: +int make_devtree(

Re: [XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-16 Thread Jimi Xenidis
Scratch this! I do not think this entry is for the devtree, I think it is the bogus entry that we create to optionally reserve the memory for the initrd, this was a side effect of creating the devtree in the python tree. So now that its in libxc we can clean it up. We must have made it

Re: [XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-15 Thread Ryan Harper
* Jimi Xenidis [EMAIL PROTECTED] [2007-01-11 16:53]: Ok there are a few things here. Respun with fixes: - preserve and return errno where approriate - using open/close and read/write instead of f* - dropped vcpu argument, only fill out one cpu in devtree - dropped regexp requirment, use a

Re: [XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-15 Thread Jimi Xenidis
On Jan 15, 2007, at 1:51 PM, Ryan Harper wrote: * Jimi Xenidis [EMAIL PROTECTED] [2007-01-11 16:53]: Ok there are a few things here. BTW: some of these issues existed in the original python, but they are yours now :) Respun with fixes: - preserve and return errno where approriate -

Re: [XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-15 Thread Jimi Xenidis
On Jan 15, 2007, at 4:13 PM, Ryan Harper wrote: * Jimi Xenidis [EMAIL PROTECTED] [2007-01-15 14:53]: On Jan 15, 2007, at 1:51 PM, Ryan Harper wrote: * Jimi Xenidis [EMAIL PROTECTED] [2007-01-11 16:53]: [snip] - renamed find_first_cpu to find_cpu, we don't care which cpu we find I

Re: [XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-15 Thread Hollis Blanchard
On Mon, 2007-01-15 at 17:25 -0500, Jimi Xenidis wrote: +int make_devtree( [snip] Any ideas what this reservation is for? is it for the flat-devtree itself? Nope. +/* root.reserve(0x100, 0x1000) */ +val[0] = cpu_to_be64((u64) 0x100); +val[1] =

Re: [XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-15 Thread Jimi Xenidis
On Jan 15, 2007, at 8:20 PM, Hollis Blanchard wrote: On Mon, 2007-01-15 at 17:25 -0500, Jimi Xenidis wrote: +int make_devtree( [snip] Any ideas what this reservation is for? is it for the flat-devtree itself? Nope. +/* root.reserve(0x100, 0x1000) */ +val[0] =

Re: [XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-15 Thread Hollis Blanchard
On Mon, 2007-01-15 at 21:29 -0500, Jimi Xenidis wrote: On Jan 15, 2007, at 8:20 PM, Hollis Blanchard wrote: On Mon, 2007-01-15 at 17:25 -0500, Jimi Xenidis wrote: +int make_devtree( [snip] Any ideas what this reservation is for? is it for the flat-devtree itself? Nope. +/*

[XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-11 Thread Ryan Harper
7 files changed, 617 insertions(+), 17 deletions(-) tools/libxc/powerpc64/Makefile |1 tools/libxc/powerpc64/mk_flatdevtree.c | 520 tools/libxc/powerpc64/mk_flatdevtree.h | 48 ++ tools/libxc/powerpc64/xc_linux_build.c | 44 ++ tools/libxc/xenguest.h

Re: [XenPPC] [PATCH 3 of 4] [PATCH] Move flat device tree construction from python to libxc for xc_linux_build()

2007-01-11 Thread Jimi Xenidis
Ok there are a few things here. On Jan 11, 2007, at 1:42 PM, Ryan Harper wrote: 7 files changed, 617 insertions(+), 17 deletions(-) tools/libxc/powerpc64/Makefile |1 tools/libxc/powerpc64/mk_flatdevtree.c | 520 ++ ++