Re: [XenPPC] [PATCH] Fix up potential memory leaks introduced by xencomm patch

2007-02-08 Thread Jimi Xenidis
mostly Linux Kernel style NITS On Feb 7, 2007, at 4:26 PM, Jerone Young wrote: With some of the logic change from the Xencomm patch. In a few hypercalls introduces a situation where you can potentially have memory leaks if something fails. This patch address these issues. Signed-off-by:

Re: [XenPPC] [PATCH 2/2] linux: build start_info_t from devtree only

2007-02-08 Thread Jimi Xenidis
some comments On Feb 7, 2007, at 6:34 PM, Ryan Harper wrote: This patch cleans up xen_init_early() to construct a start_info_t only from the devtree as Patch1 fixes xen to no longer create a start_info_t for dom0. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin,

Re: [XenPPC] [PATCH 1/2] xen: remove start_info_t from dom0 building

2007-02-08 Thread Ryan Harper
* Jimi Xenidis [EMAIL PROTECTED] [2007-02-08 06:30]: Just 2 things. (1) I really do not want OFD code to compute anything so please pass in the shared page address for ofd_dom0_fixup() heh, unlike how it was calculating start-info ? =) (2) I'm pretty sure the all of the #define RMA_* can

Re: [XenPPC] [PATCH 2/2] linux: build start_info_t from devtree only

2007-02-08 Thread Ryan Harper
* Jimi Xenidis [EMAIL PROTECTED] [2007-02-08 06:48]: some comments On Feb 7, 2007, at 6:34 PM, Ryan Harper wrote: This patch cleans up xen_init_early() to construct a start_info_t only from the devtree as Patch1 fixes xen to no longer create a start_info_t for dom0. -- Ryan Harper

Re: [XenPPC] [PATCH 1/2] xen: remove start_info_t from dom0 building

2007-02-08 Thread Jimi Xenidis
On Feb 8, 2007, at 8:40 AM, Ryan Harper wrote: * Jimi Xenidis [EMAIL PROTECTED] [2007-02-08 06:30]: Just 2 things. (1) I really do not want OFD code to compute anything so please pass in the shared page address for ofd_dom0_fixup() heh, unlike how it was calculating start-info ? =) This

Re: [XenPPC] [PATCH 2/2] linux: build start_info_t from devtree only

2007-02-08 Thread Jimi Xenidis
On Feb 8, 2007, at 8:45 AM, Ryan Harper wrote: * Jimi Xenidis [EMAIL PROTECTED] [2007-02-08 06:48]: some comments On Feb 7, 2007, at 6:34 PM, Ryan Harper wrote: This patch cleans up xen_init_early() to construct a start_info_t only from the devtree as Patch1 fixes xen to no longer create

Re: [XenPPC] [PATCH] Fix up potential memory leaks introduced by xencomm patch

2007-02-08 Thread Jerone Young
On Thu, 2007-02-08 at 07:18 -0500, Jimi Xenidis wrote: mostly Linux Kernel style NITS On Feb 7, 2007, at 4:26 PM, Jerone Young wrote: With some of the logic change from the Xencomm patch. In a few hypercalls introduces a situation where you can potentially have memory leaks if

[XenPPC] [xenppc-unstable] [LIBXC][POWERPC] use O_CREAT on open call for DTB_FILE

2007-02-08 Thread Xen patchbot-xenppc-unstable
# HG changeset patch # User Jimi Xenidis [EMAIL PROTECTED] # Node ID 51ca40884ed825b0d7fdf81a1e078e32451b4d22 # Parent 20e5f508accc21f6aaf9ade60d9a5510512cb289 [LIBXC][POWERPC] use O_CREAT on open call for DTB_FILE This fixes a bug in the creating of the flat dev tree. If open is used and

[XenPPC] [xenppc-unstable] [LIBXC][POWERPC] make sure DTB is truncated and has a decent mode

2007-02-08 Thread Xen patchbot-xenppc-unstable
# HG changeset patch # User Jimi Xenidis [EMAIL PROTECTED] # Node ID 059beff4129bc0fc44032a95a8756c6ca89f6b21 # Parent 51ca40884ed825b0d7fdf81a1e078e32451b4d22 [LIBXC][POWERPC] make sure DTB is truncated and has a decent mode Also, since we only write to this FD, we mau as well use creat(2)

[XenPPC] [PATCH] [RESEND] Fix up potential memory leaks introduced by xencomm

2007-02-08 Thread Jerone Young
With some of the logic change from the Xencomm patch. In a few hypercalls introduces a situation where you can potentially have memory leaks if something fails. This patch address these issues. Signed-off-by: Jerone Young [EMAIL PROTECTED] diff -r 37ea4cf1281a arch/powerpc/platforms/xen/hcall.c

[XenPPC] [PATCH 1/2][2nd try] xen: remove start_info_t from dom0 building

2007-02-08 Thread Ryan Harper
Updated: - pass in shared_info guest physical to ofd_dom0_fixup() - only reserve shared info page in dom0 devtree - kill rma_addr() - kill RMA_* defines in public header - update xc_linux_build() to use last page of RMA as shared_info - update xc_linux_build() to choose a console/store page

[XenPPC] [PATCH 2/2][2nd try] linux: build start_info_t from devtree only

2007-02-08 Thread Ryan Harper
Updated: - made start_info_t xsi static -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 [EMAIL PROTECTED] diffstat output: setup.c | 35 --- 1 files changed, 16 insertions(+), 19 deletions(-)