On Thu, 2007-01-18 at 17:16 -0500, Jimi Xenidis wrote:
> On Jan 18, 2007, at 4:26 PM, Hollis Blanchard wrote:
>
> > On Thu, 2007-01-18 at 16:18 -0500, Jimi Xenidis wrote:
> >>
> >> Hey, wouldn't virt_addr_valid() do?
> >
> > I can pass a perfectly "valid" virtual address that is within a
> > physi
On Jan 18, 2007, at 4:26 PM, Hollis Blanchard wrote:
On Thu, 2007-01-18 at 16:18 -0500, Jimi Xenidis wrote:
Hey, wouldn't virt_addr_valid() do?
I can pass a perfectly "valid" virtual address that is within a
physically discontiguous area of memory, and this function would
return
0.
hmm
On Thu, 2007-01-18 at 16:18 -0500, Jimi Xenidis wrote:
> On Jan 18, 2007, at 1:55 PM, Hollis Blanchard wrote:
>
> > On Thu, 2007-01-18 at 12:17 -0500, Jimi Xenidis wrote:
> >> I agree with most of Hollis's comments, but have some of my own.
> >>
> >> First, I do not think that the implementation o
On Jan 18, 2007, at 1:55 PM, Hollis Blanchard wrote:
On Thu, 2007-01-18 at 12:17 -0500, Jimi Xenidis wrote:
I agree with most of Hollis's comments, but have some of my own.
First, I do not think that the implementation of is_phys_contiguous()
answers the question in its name and IMNSHO is bogu
On Thu, 2007-01-18 at 12:17 -0500, Jimi Xenidis wrote:
> I agree with most of Hollis's comments, but have some of my own.
>
> First, I do not think that the implementation of is_phys_contiguous()
> answers the question in its name and IMNSHO is bogus. Perhaps
> something like:
>mm/sparse.c va
I agree with most of Hollis's comments, but have some of my own.
First, I do not think that the implementation of is_phys_contiguous()
answers the question in its name and IMNSHO is bogus. Perhaps
something like:
mm/sparse.c vaddr_in_vmalloc_area 232 static int
vaddr_in_vmalloc_area(void
On Wed, 2007-01-17 at 21:20 -0600, Jerone Young wrote:
> I haven't had a chance to fully test this patch. As I have been having
> problems with my blade today. But here is the code for review. I'll get
> back to the list once it is fully tested.
This looks pretty good; just a couple issues left...
I haven't had a chance to fully test this patch. As I have been having
problems with my blade today. But here is the code for review. I'll get
back to the list once it is fully tested.
Signed-off-by: Jerone Young <[EMAIL PROTECTED]>
diff -r e5962db17966 arch/powerpc/platforms/xen/gnttab.c
--- a/a