Re: [XenPPC] [PATCH] fix debug print in boot_of_alloc_init

2007-01-08 Thread Jimi Xenidis 


On Jan 8, 2007, at 5:46 PM, Yoder Stuart-B08248 wrote:



This is a minor bug in a debug print that most likely will never
be seen, as start is typically 0, but it is something I noticed.


thanks, but this patch is incorrect, see below


Signed-off-by: Stuart Yoder [EMAIL PROTECTED]


diff -r db52c7d043bb xen/arch/powerpc/boot_of.c
--- a/xen/arch/powerpc/boot_of.cTue Dec 19 09:20:58 2006 -0500
+++ b/xen/arch/powerpc/boot_of.cMon Jan 08 16:43:09 2007 -0600
@@ -419,7 +419,7 @@ static void boot_of_alloc_init(int m, ui
 start = ALIGN_UP(start, PAGE_SIZE);


start is in bytes here


 DBG(%s: marking 0x%x - 0x%lx\n, __func__,
-pg  PAGE_SHIFT, start);
+pg  PAGE_SHIFT, start  PAGE_SHIFT);


becomes in pages here

 start = PAGE_SHIFT;
 while (pg  MEM_AVAILABLE_PAGES  pg  start) {



-JX



___
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel

RE: [XenPPC] [PATCH] fix debug print in boot_of_alloc_init

2007-01-08 Thread Yoder Stuart-B08248 

 -Original Message-
 From: Hollis Blanchard [mailto:[EMAIL PROTECTED] 
 Sent: Monday, January 08, 2007 4:55 PM
 
 Thanks Stuart. However, the patch I just sent out an hour ago is going
 to remove this code entirely. :)
 
 I haven't checked it in yet though: I'd appreciate it if you 
 could test
 it on systemsim, and please let me know if you have any comments as
 well.

Hollis,

Something is broke with systemsim.

Log message is below:

25923: (25925): ---
29591: (29593): OF: Xen/PPC version 3.0-unstable (b08248@) (gcc version
3.4.1) Mon Jan  8 17:30:28 CST 2007
32814: (32817): boot_of_init args: 0x0 0x0 0xf000 0x0 0x0
33540: (33543): boot msr: 0x10003000
36100: (36103): boot_of_init: _start 0040 _end
0088ba18 0x0
38296: (38299): Physical RAM map:
WARNING: 39059: GetProp: We didn't find the property device_type in
parent /cpus:8
WARNING: 40784: GetProp: We didn't find the property device_type in
parent /chosen:27
44858: (44862):   : 2000
WARNING: 45883: GetProp: We didn't find the property device_type in
parent /options:45
WARNING: 46611: GetProp: We didn't find the property device_type in
parent /rtas:50
WARNING: 48337: GetProp: We didn't find the property device_type in
parent /systemsim:79
WARNING: 49065: GetProp: We didn't find the property device_type in
parent /mambo:83
56459: (56464): max_page: 0x2
57652: (57657): nr_pages: 0x2
59004: (59009): Total memory: 524288 KiB
60652: (60658): searching for 0x4000 bytes for bitmap:
WARNING: 61415: GetProp: We didn't find the property device_type in
parent /cpus:8
WARNING: 63141: GetProp: We didn't find the property device_type in
parent /chosen:27
67193: (67199):   : 2000 -- found
WARNING: 68781: GetProp: We didn't find the property device_type in
parent /options:45
WARNING: 69509: GetProp: We didn't find the property device_type in
parent /rtas:50
WARNING: 71234: GetProp: We didn't find the property device_type in
parent /systemsim:79
WARNING: 71962: GetProp: We didn't find the property device_type in
parent /mambo:83
79660: (79667): couldn't find space for allocator bitmap
80400: (80408): HANG

Stuart

___
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel

RE: [XenPPC] [PATCH] fix debug print in boot_of_alloc_init

2007-01-08 Thread Yoder Stuart-B08248 
 

 -Original Message-
 From: Jimi Xenidis [mailto:[EMAIL PROTECTED] 

 start is in bytes here
 
   DBG(%s: marking 0x%x - 0x%lx\n, __func__,
  -pg  PAGE_SHIFT, start);
  +pg  PAGE_SHIFT, start  PAGE_SHIFT);
 
 becomes in pages here
   start = PAGE_SHIFT;
   while (pg  MEM_AVAILABLE_PAGES  pg  start) {
 

I see... Thanks.  There was a similar bug (for real) in code
removed by an earlier patch that led me to jump to the
conclusion the same shift was needed there.

Stuart

___
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel