Re: [XenPPC] [PATCH]fix xencomm_copy_{from, to}_guest.
Keir, can you commit this patch to the tree. It has been tested and does not appear to cause any issues. Signed-off-by: Jerone Young [EMAIL PROTECTED] On Fri, 2007-01-05 at 12:19 +0900, Isaku Yamahata wrote: fix xencomm_copy_{from, to}_guest. It should not call paddr_to_maddr() with invalid address. Originally this issue was found in xen/ia64 xencomm code and in fact I didn't test this patch because currently ia64 xencomm forked from common code. They should be consolidated somehow. -- yamahata ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel # HG changeset patch # User [EMAIL PROTECTED] # Date 1167966417 -32400 # Node ID 25cdcc5f21f8147371aed5fb8f56d93479df0ca8 # Parent 338ceb7b1f0993bf9735c0c1c5d21e39c381cf2f fix xencomm_copy_{from, to}_guest. It should not call paddr_to_maddr() with invalid address. PATCHNAME: fix_xencomm_copy_tofrom_guest Signed-off-by: Isaku Yamahata [EMAIL PROTECTED] diff -r 338ceb7b1f09 -r 25cdcc5f21f8 xen/common/xencomm.c --- a/xen/common/xencomm.c Thu Jan 04 10:58:01 2007 + +++ b/xen/common/xencomm.c Fri Jan 05 12:06:57 2007 +0900 @@ -119,7 +119,7 @@ xencomm_copy_from_guest(void *to, const chunksz -= chunk_skip; skip -= chunk_skip; -if (skip == 0) { +if (skip == 0 chunksz 0) { unsigned long src_maddr; unsigned long dest = (unsigned long)to + to_pos; unsigned int bytes = min(chunksz, n - to_pos); @@ -225,7 +225,7 @@ xencomm_copy_to_guest(void *to, const vo chunksz -= chunk_skip; skip -= chunk_skip; -if (skip == 0) { +if (skip == 0 chunksz 0) { unsigned long dest_maddr; unsigned long source = (unsigned long)from + from_pos; unsigned int bytes = min(chunksz, n - from_pos); ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
Re: [XenPPC] [PATCH]fix xencomm_copy_{from, to}_guest.
On Fri, 2007-01-05 at 12:19 +0900, Isaku Yamahata wrote: fix xencomm_copy_{from, to}_guest. It should not call paddr_to_maddr() with invalid address. Thanks Yamahata-san! I've asked Jerone (CCed) to give this a quick test. Originally this issue was found in xen/ia64 xencomm code and in fact I didn't test this patch because currently ia64 xencomm forked from common code. They should be consolidated somehow. I couldn't agree more. I've posted comments on that before; please let me know if anybody on the ia64 side has questions about it. -- Hollis Blanchard IBM Linux Technology Center ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
Re: [XenPPC] [PATCH]fix xencomm_copy_{from, to}_guest.
Just quickly tried it out and my js20 blade boots without issue with this patch. On Mon, 2007-01-08 at 16:51 -0600, Hollis Blanchard wrote: On Fri, 2007-01-05 at 12:19 +0900, Isaku Yamahata wrote: fix xencomm_copy_{from, to}_guest. It should not call paddr_to_maddr() with invalid address. Thanks Yamahata-san! I've asked Jerone (CCed) to give this a quick test. Originally this issue was found in xen/ia64 xencomm code and in fact I didn't test this patch because currently ia64 xencomm forked from common code. They should be consolidated somehow. I couldn't agree more. I've posted comments on that before; please let me know if anybody on the ia64 side has questions about it. -- Hollis Blanchard IBM Linux Technology Center ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
[XenPPC] [PATCH]fix xencomm_copy_{from, to}_guest.
fix xencomm_copy_{from, to}_guest. It should not call paddr_to_maddr() with invalid address. Originally this issue was found in xen/ia64 xencomm code and in fact I didn't test this patch because currently ia64 xencomm forked from common code. They should be consolidated somehow. -- yamahata # HG changeset patch # User [EMAIL PROTECTED] # Date 1167966417 -32400 # Node ID 25cdcc5f21f8147371aed5fb8f56d93479df0ca8 # Parent 338ceb7b1f0993bf9735c0c1c5d21e39c381cf2f fix xencomm_copy_{from, to}_guest. It should not call paddr_to_maddr() with invalid address. PATCHNAME: fix_xencomm_copy_tofrom_guest Signed-off-by: Isaku Yamahata [EMAIL PROTECTED] diff -r 338ceb7b1f09 -r 25cdcc5f21f8 xen/common/xencomm.c --- a/xen/common/xencomm.c Thu Jan 04 10:58:01 2007 + +++ b/xen/common/xencomm.c Fri Jan 05 12:06:57 2007 +0900 @@ -119,7 +119,7 @@ xencomm_copy_from_guest(void *to, const chunksz -= chunk_skip; skip -= chunk_skip; -if (skip == 0) { +if (skip == 0 chunksz 0) { unsigned long src_maddr; unsigned long dest = (unsigned long)to + to_pos; unsigned int bytes = min(chunksz, n - to_pos); @@ -225,7 +225,7 @@ xencomm_copy_to_guest(void *to, const vo chunksz -= chunk_skip; skip -= chunk_skip; -if (skip == 0) { +if (skip == 0 chunksz 0) { unsigned long dest_maddr; unsigned long source = (unsigned long)from + from_pos; unsigned int bytes = min(chunksz, n - from_pos); ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel