Re: [Xen-devel] Re: [XenPPC] [PATCH 2/7] xencomm take 3: xen side preparetion for consolidation.

2007-08-15 Thread Hollis Blanchard
On Wed, 2007-08-15 at 12:46 +0900, Isaku Yamahata wrote: > On Tue, Aug 14, 2007 at 09:48:00AM -0500, Hollis Blanchard wrote: > > > However, there are a few places below where you call memcpy() without > > checking the result of xencomm_maddr_to_vaddr(). Actually, I see the > > same issue in the or

Re: [Xen-devel] Re: [XenPPC] [PATCH 2/7] xencomm take 3: xen side preparetion for consolidation.

2007-08-14 Thread Isaku Yamahata
On Tue, Aug 14, 2007 at 09:48:00AM -0500, Hollis Blanchard wrote: > However, there are a few places below where you call memcpy() without > checking the result of xencomm_maddr_to_vaddr(). Actually, I see the > same issue in the original code in a few places... We should be very > very careful her

Re: [XenPPC] [PATCH 2/7] xencomm take 3: xen side preparetion for consolidation.

2007-08-14 Thread Hollis Blanchard
This is definitely needed and I apologize for my maddr/vaddr confusion in the first place. However, there are a few places below where you call memcpy() without checking the result of xencomm_maddr_to_vaddr(). Actually, I see the same issue in the original code in a few places... We should be very

[XenPPC] [PATCH 2/7] xencomm take 3: xen side preparetion for consolidation.

2007-08-14 Thread Isaku Yamahata
# HG changeset patch # User [EMAIL PROTECTED] # Date 1187077583 -32400 # Node ID 4dbbedee6bb8d594287940470a61b8c0c56daf9c # Parent 68867379b785a9a6fd37ca75be64fa7b5e3b8a2b [xen, xencomm] preparetion for xencomm consolidation. Xen/powerpc runs in real mode so that it uses maddr interchangably with