Re: [XenPPC] [patch] multiboot2 support

2007-01-09 Thread Hollis Blanchard
On Thu, 2007-01-04 at 15:56 -0500, Jimi Xenidis wrote: We did a lot of work here so that stuff could be placed anywhere. I admit it was not pretty but I'd expect this patch to replace/improve not remove. The memmove below means this logic is unnecessary. I'd prefer some logic over

Re: [XenPPC] [patch] multiboot2 support

2007-01-09 Thread Jimi Xenidis
On Jan 9, 2007, at 12:09 PM, Hollis Blanchard wrote: On Thu, 2007-01-04 at 15:56 -0500, Jimi Xenidis wrote: We did a lot of work here so that stuff could be placed anywhere. I admit it was not pretty but I'd expect this patch to replace/improve not remove. The memmove below means this

Re: [XenPPC] [patch] multiboot2 support

2007-01-09 Thread Jimi Xenidis
On Jan 9, 2007, at 12:34 PM, Segher Boessenkool wrote: Wait a minute, doesn't systemsim has a passthrough call for memmove? If we should wire that up then this won't impact performance at all. We were/are trying to eliminate all simulator specific passthrus in the Xen core code. That

Re: [XenPPC] [patch] multiboot2 support

2007-01-04 Thread Jimi Xenidis
On Jan 3, 2007, at 12:32 PM, Hollis Blanchard wrote: Xen on x86 uses GRUB's multiboot capabilities to load an arbitrary number of images, including Xen, dom0 kernel, dom0 initrd, and ACM policy. On PowerPC, we've had to build Xen, the dom0 kernel and the dom0 initrd all into the same file to

Re: [XenPPC] [patch] multiboot2 support

2007-01-04 Thread Hollis Blanchard
Hi Jimi, thanks for the comments. I'm really not interested in reworking all this stuff, which is why I took shortcuts like relocating the modules rather than spending effort on your preferred solution. Unfortunately, all this code was intimately linked with the multiboot structure, so I had to

Re: [XenPPC] [patch] multiboot2 support

2007-01-04 Thread Jimi Xenidis
On Jan 4, 2007, at 3:02 PM, Hollis Blanchard wrote: Hi Jimi, thanks for the comments. I'm really not interested in reworking all this stuff, which is why I took shortcuts like relocating the modules rather than spending effort on your preferred solution. Ok, then it can wait till grub is

[XenPPC] [patch] multiboot2 support

2007-01-03 Thread Hollis Blanchard
Xen on x86 uses GRUB's multiboot capabilities to load an arbitrary number of images, including Xen, dom0 kernel, dom0 initrd, and ACM policy. On PowerPC, we've had to build Xen, the dom0 kernel and the dom0 initrd all into the same file to get them loaded. Since we currently boot directly from