[XenPPC] Re: [PATCH 1/6] bootwrapper: arch/powerpc/boot code reorg
On Sun, Aug 06, 2006 at 07:21:51PM -0500, Hollis Blanchard wrote: > On Wed, 2006-07-19 at 16:00 -0700, an unknown sender wrote: > > diff --git a/arch/powerpc/boot/types.h b/arch/powerpc/boot/types.h > > new file mode 100644 > > index 000..2a2fa2b > > --- /dev/null > > +++ b/arch/powerpc/boot/types.h > > @@ -0,0 +1,29 @@ > > +#ifndef _TYPES_H_ > > +#define _TYPES_H_ > > + > > +#defineCOMMAND_LINE_SIZE 512 > > +#defineMAX_PATH_LEN256 > > +#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) > > + > > +typedef unsigned char u8; > > +typedef unsigned short u16; > > +typedef unsigned int u32; > > +#ifdef __powerpc64__ > > +typedef unsigned long u64; > > +#else > > +typedef unsigned long long u64; > > +#endif > > As long as we're adding new typedefs, could we please use the stdint.h > ones (e.g. uint32_t)? For Xen, I need to do flat tree munging in > userspace, so using real types would help with code reuse. Sure, I can do that unless someone objects. Mark ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
[XenPPC] Re: [PATCH 1/6] bootwrapper: arch/powerpc/boot code reorg
On Wed, 2006-07-19 at 16:00 -0700, an unknown sender wrote: > diff --git a/arch/powerpc/boot/types.h b/arch/powerpc/boot/types.h > new file mode 100644 > index 000..2a2fa2b > --- /dev/null > +++ b/arch/powerpc/boot/types.h > @@ -0,0 +1,29 @@ > +#ifndef _TYPES_H_ > +#define _TYPES_H_ > + > +#defineCOMMAND_LINE_SIZE 512 > +#defineMAX_PATH_LEN256 > +#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) > + > +typedef unsigned char u8; > +typedef unsigned short u16; > +typedef unsigned int u32; > +#ifdef __powerpc64__ > +typedef unsigned long u64; > +#else > +typedef unsigned long long u64; > +#endif As long as we're adding new typedefs, could we please use the stdint.h ones (e.g. uint32_t)? For Xen, I need to do flat tree munging in userspace, so using real types would help with code reuse. -- Hollis Blanchard IBM Linux Technology Center ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
