Re: [XenPPC] copy_page speedup using dcbz on target

2006-12-18 Thread poff
On Sat, 16 Dec 2006 11:34, Jimi Xenidis wrote: If you really want to explore mem/page copy for XenPPC then you have to understand that since we run without an MMU, profiling code with MMU on, _including_ RMA, is not helpful because the access is guarded ... Please run your experiments

[XenPPC] copy_page speedup using dcbz on target

2006-12-15 Thread poff
Using dcbz avoids first reading a cache line from memory before writing to the line. Timing results (starting with clean cache, ie no write-backs for dirty lines): JS20: elapsed time: 0x9f5e elapsed time using dcbz: 0x569e elapsed time: 0x9fe9 elapsed time

Re: [XenPPC] copy_page speedup using dcbz on target

2006-12-15 Thread Hollis Blanchard
On Fri, 2006-12-15 at 11:50 -0500, poff wrote: Using dcbz avoids first reading a cache line from memory before writing to the line. Timing results (starting with clean cache, ie no write-backs for dirty lines): So do you have a patch for copy_page()? -- Hollis Blanchard IBM Linux Technology

Re: [XenPPC] copy_page speedup using dcbz on target

2006-12-15 Thread poff
So do you have a patch for copy_page()? In Xen for PPC, the only copy_page() is in arch/powerpc/mm.c: extern void copy_page(void *dp, void *sp) { if (on_systemsim()) { systemsim_memcpy(dp, sp, PAGE_SIZE); } else { memcpy(dp, sp, PAGE_SIZE); } } 1) Also copy_page is

Re: [XenPPC] copy_page speedup using dcbz on target

2006-12-15 Thread Hollis Blanchard
On Fri, 2006-12-15 at 16:40 -0500, poff wrote: So do you have a patch for copy_page()? In Xen for PPC, the only copy_page() is in arch/powerpc/mm.c: extern void copy_page(void *dp, void *sp) { if (on_systemsim()) { systemsim_memcpy(dp, sp, PAGE_SIZE); } else {

Re: [XenPPC] copy_page speedup using dcbz on target

2006-12-15 Thread poff
3) Useful when PPC must do page copies in place of 'page flipping'. So you're saying we should worry about it later? For the future, copy_page using dcbz: diff -r 7669fca80bfc xen/arch/powerpc/mm.c --- a/xen/arch/powerpc/mm.c Mon Dec 04 11:46:53 2006 -0500 +++ b/xen/arch/powerpc/mm.c

Re: [XenPPC] copy_page speedup using dcbz on target

2006-12-15 Thread Hollis Blanchard
On Fri, 2006-12-15 at 17:50 -0500, poff wrote: 3) Useful when PPC must do page copies in place of 'page flipping'. So you're saying we should worry about it later? For the future, copy_page using dcbz: diff -r 7669fca80bfc xen/arch/powerpc/mm.c --- a/xen/arch/powerpc/mm.c Mon Dec