Re: [PATCH] Re: [XenPPC] XenPPC: redundancy definition of __trap_to_gdb with CRASH_DEBUG
I think hollis nailed correctly, does it work for everyone? # HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Node ID c3312bbd598a50b3c48955a8f4c9dba6330fc7d8 # Parent d1f6d0f820d890ac6075f47ad1ba6e38012167b4 [POWERPC][XEN] Move gmfn_to_mfn() from page.h to mm.h to avoid recursive header dependencies. Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] -JX On Oct 4, 2006, at 12:50 AM, Tony Breeds wrote: On Tue, Oct 03, 2006 at 02:56:14PM -0400, Amos Waterland wrote: I'm not positive of this, but I'm pretty sure that this is caused by improper dependency checking. I suspect that you changed from debug=n to debug=y and got this. I'd suggest doing a `make clean' and trying again without your patch. I came accross the same probelm with a clean build. The patch below fixes it for me. Reorder includes to help the complier and avoid redundat definition of __trap_to_gdb. Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- xen/arch/powerpc/gdbstub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff -r d1374d869111 xen/arch/powerpc/gdbstub.c --- a/xen/arch/powerpc/gdbstub.cWed Oct 04 13:44:07 2006 +1000 +++ b/xen/arch/powerpc/gdbstub.cWed Oct 04 14:46:07 2006 +1000 @@ -20,12 +20,12 @@ #include xen/types.h #include xen/lib.h -#include xen/gdbstub.h #include public/xen.h #include asm/msr.h #include asm/bitops.h #include asm/cache.h #include asm/debugger.h +#include xen/gdbstub.h #include asm/processor.h asm(.globl trap_instruction\n Yours Tony linux.conf.au http://linux.conf.au/ || http:// lca2007.linux.org.au/ Jan 15-20 2007 The Australian Linux Technical Conference! ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
Re: [PATCH] Re: [XenPPC] XenPPC: redundancy definition of __trap_to_gdb with CRASH_DEBUG
On Wed, Oct 04, 2006 at 07:36:08AM -0400, Jimi Xenidis wrote: I think hollis nailed correctly, does it work for everyone? Works for me. Yours Tony linux.conf.au http://linux.conf.au/ || http://lca2007.linux.org.au/ Jan 15-20 2007 The Australian Linux Technical Conference! ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
Re: [PATCH] Re: [XenPPC] XenPPC: redundancy definition of __trap_to_gdb with CRASH_DEBUG
On Thu, Oct 05, 2006 at 01:52:39PM +1000, Tony Breeds wrote: On Wed, Oct 04, 2006 at 07:36:08AM -0400, Jimi Xenidis wrote: I think hollis nailed correctly, does it work for everyone? Works for me. Did you try building with debug=y, then with debug=n, with no intervening `make clean'? ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
Re: [PATCH] Re: [XenPPC] XenPPC: redundancy definition of __trap_to_gdb with CRASH_DEBUG
On Wed, Oct 04, 2006 at 11:57:45PM -0400, Amos Waterland wrote: Did you try building with debug=y, then with debug=n, with no intervening `make clean'? Yup. [EMAIL PROTECTED]:~/Xen/xenppc-unstable.hg.working$ history | egrep dist-xen snip Older stuff 562 make clean; PATH=/usr/bin:/bin make dist-xen 563 make clean; PATH=/usr/bin:/bin make debug=y dist-xen 564 make clean; PATH=/usr/bin:/bin make debug=y crash_debug=y dist-xen where xenppc-unstable.hg.working is 1b759b2522cd tip Yours Tony linux.conf.au http://linux.conf.au/ || http://lca2007.linux.org.au/ Jan 15-20 2007 The Australian Linux Technical Conference! ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
Re: [XenPPC] XenPPC: redundancy definition of __trap_to_gdb with CRASH_DEBUG
Not sure what the redundancy is?
I see 2 prototypes and you have added one.
please explain.
-JX
On Oct 3, 2006, at 12:23 PM, Yi Ge wrote:
It looks like the compiler's problem: it makes a implicit
definition of __trap_to_gdb on the asm/debugger.h. This will
cause the redundancy definition warning and stop the build process
in default compiling setting.
diff -r d1f6d0f820d8 xen/include/asm-powerpc/debugger.h
--- a/xen/include/asm-powerpc/debugger.h Mon Oct 02 21:43:09 2006
-0400
+++ b/xen/include/asm-powerpc/debugger.h Tue Oct 03 11:49:57 2006
-0400
@@ -74,6 +74,10 @@ extern void __warn(char *file, int line)
#include xen/gdbstub.h
+#ifndef TRAP_TO_GDB
+extern int __trap_to_gdb(struct cpu_user_regs *regs, unsigned long
cookie);
+#define TRAP_TO_GDB
+#endif
static inline int debugger_trap_fatal(
unsigned int vector, struct cpu_user_regs *regs)
{
diff -r d1f6d0f820d8 xen/include/xen/gdbstub.h
--- a/xen/include/xen/gdbstub.h Mon Oct 02 21:43:09 2006 -0400
+++ b/xen/include/xen/gdbstub.h Tue Oct 03 11:50:50 2006 -0400
@@ -56,8 +56,10 @@ void gdb_send_reply(const char *buf, str
void gdb_send_reply(const char *buf, struct gdb_context *ctx);
/* gdb stub trap handler: entry point */
+#ifndef TRAP_TO_GDB
int __trap_to_gdb(struct cpu_user_regs *regs, unsigned long cookie);
-
+#define TRAP_TO_GDB
+#endif
/* arch specific routines */
u16 gdb_arch_signal_num(
struct cpu_user_regs *regs, unsigned long cookie);
Best Regards,
Yi Ge
___
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel
___
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel
Re: [XenPPC] XenPPC: redundancy definition of __trap_to_gdb with CRASH_DEBUG
On Tue, Oct 03, 2006 at 02:53:02PM -0400, Yi Ge wrote: It seems the gcc couldn't find the prototype of __trap_to_gdb when make the function call in debugger_trap_fatal(). So I added an extern prototype here with ifndef macro. I'm not positive of this, but I'm pretty sure that this is caused by improper dependency checking. I suspect that you changed from debug=n to debug=y and got this. I'd suggest doing a `make clean' and trying again without your patch. ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
[PATCH] Re: [XenPPC] XenPPC: redundancy definition of __trap_to_gdb with CRASH_DEBUG
On Tue, Oct 03, 2006 at 02:56:14PM -0400, Amos Waterland wrote: I'm not positive of this, but I'm pretty sure that this is caused by improper dependency checking. I suspect that you changed from debug=n to debug=y and got this. I'd suggest doing a `make clean' and trying again without your patch. I came accross the same probelm with a clean build. The patch below fixes it for me. Reorder includes to help the complier and avoid redundat definition of __trap_to_gdb. Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- xen/arch/powerpc/gdbstub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff -r d1374d869111 xen/arch/powerpc/gdbstub.c --- a/xen/arch/powerpc/gdbstub.cWed Oct 04 13:44:07 2006 +1000 +++ b/xen/arch/powerpc/gdbstub.cWed Oct 04 14:46:07 2006 +1000 @@ -20,12 +20,12 @@ #include xen/types.h #include xen/lib.h -#include xen/gdbstub.h #include public/xen.h #include asm/msr.h #include asm/bitops.h #include asm/cache.h #include asm/debugger.h +#include xen/gdbstub.h #include asm/processor.h asm(.globl trap_instruction\n Yours Tony linux.conf.au http://linux.conf.au/ || http://lca2007.linux.org.au/ Jan 15-20 2007 The Australian Linux Technical Conference! ___ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
