Re: [Xenomai] [PATCH] cobalt: fcntl uses void* instead of int

2018-12-05 Thread Philippe Gerum via Xenomai
On 12/4/18 4:51 PM, Lange Norbert wrote: > To close this up, > > is there anything expected from my side? I am not able to fix up the kernel > side, esp. with the x32 API, > and my disagreement with long vs void*/uintptr_t likely won't end up getting > us anywhere. > The kernel patch is on its

RE: [Xenomai] [PATCH] cobalt: fcntl uses void* instead of int

2018-12-04 Thread Lange Norbert via Xenomai
Sent: Mittwoch, 17. Oktober 2018 17:27 > To: Lange Norbert ; xenomai@xenomai.org > Subject: Re: [Xenomai] [PATCH] cobalt: fcntl uses void* instead of int > > E-MAIL FROM A NON-ANDRITZ SOURCE: AS A SECURITY MEASURE, PLEASE > EXERCISE CAUTION WITH E-MAIL CONTENT AND ANY LINKS OR > ATT

Re: [Xenomai] [PATCH] cobalt: fcntl uses void* instead of int

2018-10-17 Thread Philippe Gerum
On 10/17/2018 01:30 PM, Lange Norbert wrote: >>> @@ -139,11 +139,11 @@ static int do_ioctl(int fd, unsigned int >>> request, void *arg) COBALT_IMPL(int, fcntl, (int fd, int cmd, ...)) >>> { >>> va_list ap; >>> - int arg; >>> + void *arg; >>> int ret; >>> >>> va_start(ap,

Re: [Xenomai] [PATCH] cobalt: fcntl uses void* instead of int

2018-10-17 Thread Lange Norbert
> > @@ -139,11 +139,11 @@ static int do_ioctl(int fd, unsigned int > > request, void *arg) COBALT_IMPL(int, fcntl, (int fd, int cmd, ...)) > > { > > va_list ap; > > - int arg; > > + void *arg; > > int ret; > > > > va_start(ap, cmd); > > - arg = va_arg(ap, int); > > +

Re: [Xenomai] [PATCH] cobalt: fcntl uses void* instead of int

2018-10-17 Thread Philippe Gerum
On 10/16/2018 12:34 PM, Norbert Lange wrote: > this is consistent with glibc internals, > and fixes truncation when passing 64bit pointers > --- > lib/cobalt/rtdm.c | 4 ++-- > lib/cobalt/wrappers.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/cobalt/rtdm.