Re: [PATCH 04/18] drivers/ipc: bufp: fix read-write, write-write preemption cases

2019-02-25 Thread Jan Kiszka via Xenomai
On 26.02.19 08:03, Philippe Gerum via Xenomai wrote: On 2/25/19 7:17 PM, Jan Kiszka wrote: On 05.02.19 12:20, Philippe Gerum via Xenomai wrote: On 2/4/19 7:55 PM, Jan Kiszka wrote: - * Release the lock while copying the data to - * keep latency low. + * We

Re: [PATCH 04/18] drivers/ipc: bufp: fix read-write, write-write preemption cases

2019-02-25 Thread Philippe Gerum via Xenomai
On 2/25/19 7:17 PM, Jan Kiszka wrote: > On 05.02.19 12:20, Philippe Gerum via Xenomai wrote: >> On 2/4/19 7:55 PM, Jan Kiszka wrote: - * Release the lock while copying the data to - * keep latency low. + * We have to drop the lock while reading in

Re: [PATCH 04/18] drivers/ipc: bufp: fix read-write, write-write preemption cases

2019-02-25 Thread Jan Kiszka via Xenomai
On 05.02.19 12:20, Philippe Gerum via Xenomai wrote: On 2/4/19 7:55 PM, Jan Kiszka wrote: - * Release the lock while copying the data to - * keep latency low. + * We have to drop the lock while reading in + * data, but we can't rollback on bad

Re: [PATCH 04/18] drivers/ipc: bufp: fix read-write, write-write preemption cases

2019-02-04 Thread Jan Kiszka via Xenomai
On 04.02.19 11:56, Philippe Gerum wrote: The token-based approach for detecting preemption while data is being moved into or out of the ring only protects from read vs read races, not from races involving a write side. For instance, a reader might read dirty data being changed by a writer