[PATCH] arm: ipipe: omap-gpio: Fix interrupts delivering

2021-09-11 Thread Dario Binacchi via Xenomai
If you set the irq trigger as edge rising or falling the interrupts are no longer delivered to the upper layers. The gpiokeys driver, for example, no longer detects the change in the state of the pins mapped to the buttons. Fixes: c041e938312b ("arm: ipipe: Fix up the omap-gpio driver to deliver

[RESEND PATCH] arm: ipipe: omap-gpio: Fix interrupts delivering

2021-09-26 Thread Dario Binacchi via Xenomai
If you set the irq trigger as edge rising or falling the interrupts are no longer delivered to the upper layers. The gpiokeys driver, for example, no longer detects the change in the state of the pins mapped to the buttons. Fixes: c041e938312b ("arm: ipipe: Fix up the omap-gpio driver to deliver

[PATCH v2 6/6] drivers/can: add support for Bosch C_CAN controller

2021-11-29 Thread Dario Binacchi via Xenomai
Bosch C_CAN controller is a full-CAN implementation which is compliant to CAN protocol version 2.0 part A and B. Starting from the RTDM porting [1] by Stephen Battazzo, Michael applied some fixes for proper driver operation. Then I ported the commits from Linux kernel version 5.12 and finally I

[PATCH v2 5/6] drivers/can: fix updating of tx_count statistics

2021-11-29 Thread Dario Binacchi via Xenomai
As in the Linux kernel, the counter is updated only after the message has been really transmitted. Signed-off-by: Dario Binacchi --- (no changes since v1) kernel/drivers/can/mscan/rtcan_mscan.c | 1 + kernel/drivers/can/rtcan_flexcan.c | 1 + kernel/drivers/can/rtcan_raw.c

[PATCH v2 4/6] drivers/can: add a minimal support to ethtool API

2021-11-29 Thread Dario Binacchi via Xenomai
Like in the Linux kernel, the API allows to get/set device controller parameters. For now it only supports: - ETHTOOL_GDRVINFO: get general driver and device information - ETHTOOL_GRINGPARAM: get RX/TX ring parameters It allows the userspace to know the number of messages managed by the

[PATCH v2 1/6] drivers/can: add multi message support to sendmsg

2021-11-29 Thread Dario Binacchi via Xenomai
The `user_msghdr' structure is designed to send multiple messages as well, so rtcan_raw_sendmsg() can also send multiple messages. This avoids having to add the sendmmsg system call which requires more extensive Xenomai changes. Signed-off-by: Dario Binacchi --- (no changes since v1)

[PATCH v2 2/6] drivers/can: add CAN_ERR_CRTL_ACTIVE info status

2021-11-29 Thread Dario Binacchi via Xenomai
To be used in case of recovered to error active state. Signed-off-by: Dario Binacchi --- (no changes since v1) include/rtdm/uapi/can.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/rtdm/uapi/can.h b/include/rtdm/uapi/can.h index 8d0d837d5..1c35a9b9d 100644 ---

[PATCH v2 0/6] drivers/can: add support for Bosch C_CAN controller

2021-11-29 Thread Dario Binacchi via Xenomai
The series was created to optimize the use of the C_CAN controller (maximum number of message objects, use of FIFO, ...) to get the best possible RX/TX throughput from hardware. To emphasize the purpose of the series I also added the patch which adds multi-message support to `sendmsg ', rather

[PATCH v2 3/6] drivers/can: add len field to can frame structures

2021-11-29 Thread Dario Binacchi via Xenomai
As mentioned in Linux, can_dlc is a misleading name that suggests a code instead of a length. Adding the len field can_dlc becomes deprecated too. Signed-off-by: Dario Binacchi --- (no changes since v1) include/rtdm/uapi/can.h | 5 - kernel/drivers/can/rtcan_socket.h | 5 -

[PATCH v5 8/8] drivers/can: add support for Bosch C_CAN controller

2021-12-19 Thread Dario Binacchi via Xenomai
Bosch C_CAN controller is a full-CAN implementation which is compliant to CAN protocol version 2.0 part A and B. Starting from the RTDM porting [1] by Stephen Battazzo, Michael applied some fixes for proper driver operation. Then I ported the commits from Linux kernel version 5.12 and finally I

[PATCH v5 4/8] drivers/can: add multi message support to sendmsg

2021-12-19 Thread Dario Binacchi via Xenomai
The `user_msghdr' structure is designed to send multiple messages as well, so rtcan_raw_sendmsg() can also send multiple messages. This avoids having to add the sendmmsg system call which requires more extensive Xenomai changes. Signed-off-by: Dario Binacchi --- (no changes since v1)

[PATCH v5 3/8] testsuite/smokey: add virtual CAN testsuite

2021-12-19 Thread Dario Binacchi via Xenomai
Add a minimal test for the virtual CAN driver, checking that sent messages are received correctly. The timeout on read operations has been wired to 1 s in order not to fail the test in case the verbose option is enabled. Signed-off-by: Dario Binacchi --- Changes in v5: - Check

[PATCH v5 7/8] drivers/can: add a minimal support to ethtool API

2021-12-19 Thread Dario Binacchi via Xenomai
Like in the Linux kernel, the API allows to get/set device controller parameters. For now it only supports: - ETHTOOL_GDRVINFO: get general driver and device information - ETHTOOL_GRINGPARAM: get RX/TX ring parameters It allows the userspace to know the number of messages managed by the

[PATCH v5 2/8] lib/smokey: add smokey_{modprobe,rmmod} helpers

2021-12-19 Thread Dario Binacchi via Xenomai
Both functions, implemented and used for the net, are general purpose and therefore can be useful in other parts of the application with the application of minimal changes. Signed-off-by: Dario Binacchi --- Changes in v5: - smokey_modprobe(): check the `name' parameter. - smokey_modprobe():

[PATCH v5 5/8] drivers/can: add CAN_ERR_CRTL_ACTIVE info status

2021-12-19 Thread Dario Binacchi via Xenomai
To be used in case of recovered to error active state. Signed-off-by: Dario Binacchi --- (no changes since v1) include/rtdm/uapi/can.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/rtdm/uapi/can.h b/include/rtdm/uapi/can.h index 8d0d837d5..1c35a9b9d 100644 ---

[PATCH v5 1/8] drivers/can: add corectl to retrieve configuration

2021-12-19 Thread Dario Binacchi via Xenomai
Signed-off-by: Dario Binacchi --- Changes in v5: - Add the patch to the series. include/cobalt/uapi/corectl.h | 2 ++ kernel/drivers/can/Makefile | 4 +-- kernel/drivers/can/corectl.c | 41 +++ kernel/drivers/can/rtcan_module.c | 6 + 4 files

[PATCH v5 0/8] drivers/can: add support for Bosch C_CAN controller

2021-12-19 Thread Dario Binacchi via Xenomai
The series was created to optimize the use of the C_CAN controller (maximum number of message objects, use of FIFO, ...) to get the best possible RX/TX throughput from hardware. To emphasize the purpose of the series I also added the patch which adds multi-message support to `sendmsg ', rather

[PATCH v5 6/8] drivers/can: add len field to can frame structures

2021-12-19 Thread Dario Binacchi via Xenomai
As mentioned in Linux, can_dlc is a misleading name that suggests a code instead of a length. Adding the len field can_dlc becomes deprecated too. Signed-off-by: Dario Binacchi --- (no changes since v1) include/rtdm/uapi/can.h | 5 - kernel/drivers/can/rtcan_socket.h | 5 -

Re: [PATCH 6/6] drivers/can: add support for Bosch C_CAN controller

2021-11-27 Thread Dario Binacchi via Xenomai
Hi Jan, > Il 25/11/2021 11:43 Jan Kiszka ha scritto: > > > On 25.11.21 00:46, Dario Binacchi wrote: > > Bosch C_CAN controller is a full-CAN implementation which is compliant > > to CAN protocol version 2.0 part A and B. > > > > Starting from the RTDM porting [1] by Stephen Battazzo, Michael

Re: [PATCH 4/6] drivers/can: add a minimal support to ethtool API

2021-11-27 Thread Dario Binacchi via Xenomai
Hi Jan, > Il 25/11/2021 11:26 Jan Kiszka ha scritto: > > > On 25.11.21 00:46, Dario Binacchi wrote: > > Like in the Linux kernel, the API allows to get/set device controller > > parameters. > > For now it only supports: > > - ETHTOOL_GDRVINFO: get general driver and device information > > -

Re: [PATCH 5/6] drivers/can: fix updating of tx_count statistics

2021-11-27 Thread Dario Binacchi via Xenomai
Hi Jan, > Il 25/11/2021 11:28 Jan Kiszka ha scritto: > > > On 25.11.21 00:46, Dario Binacchi wrote: > > As in the Linux kernel, the counter is updated only after the message > > has been really transmitted. > > > > Signed-off-by: Dario Binacchi > > --- > > > >

Re: [PATCH 5/6] drivers/can: fix updating of tx_count statistics

2021-11-29 Thread Dario Binacchi via Xenomai
Hi Jan, > Il 29/11/2021 08:50 Jan Kiszka ha scritto: > > > On 27.11.21 16:50, Dario Binacchi wrote: > > Hi Jan, > > > >> Il 25/11/2021 11:28 Jan Kiszka ha scritto: > >> > >> > >> On 25.11.21 00:46, Dario Binacchi wrote: > >>> As in the Linux kernel, the counter is updated only after the

[PATCH 6/6] drivers/can: add support for Bosch C_CAN controller

2021-11-24 Thread Dario Binacchi via Xenomai
Bosch C_CAN controller is a full-CAN implementation which is compliant to CAN protocol version 2.0 part A and B. Starting from the RTDM porting [1] by Stephen Battazzo, Michael applied some fixes for proper driver operation. Then I ported the commits from Linux kernel version 5.12 and finally I

[PATCH 4/6] drivers/can: add a minimal support to ethtool API

2021-11-24 Thread Dario Binacchi via Xenomai
Like in the Linux kernel, the API allows to get/set device controller parameters. For now it only supports: - ETHTOOL_GDRVINFO: get general driver and device information - ETHTOOL_GRINGPARAM: get RX/TX ring parameters Signed-off-by: Dario Binacchi --- kernel/drivers/can/Makefile| 2

[PATCH 0/6] drivers/can: add support for Bosch C_CAN controller

2021-11-24 Thread Dario Binacchi via Xenomai
The series was created to optimize the use of the C_CAN controller (maximum number of message objects, use of FIFO, ...) to get the best possible RX/TX throughput from hardware. To emphasize the purpose of the series I also added the patch which adds multi-message support to `sendmsg ', rather

[PATCH 5/6] drivers/can: fix updating of tx_count statistics

2021-11-24 Thread Dario Binacchi via Xenomai
As in the Linux kernel, the counter is updated only after the message has been really transmitted. Signed-off-by: Dario Binacchi --- kernel/drivers/can/mscan/rtcan_mscan.c | 1 + kernel/drivers/can/rtcan_flexcan.c | 1 + kernel/drivers/can/rtcan_raw.c | 1 -

[PATCH 2/6] drivers/can: add CAN_ERR_CRTL_ACTIVE info status

2021-11-24 Thread Dario Binacchi via Xenomai
To be used in case of recovered to error active state. Signed-off-by: Dario Binacchi --- include/rtdm/uapi/can.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/rtdm/uapi/can.h b/include/rtdm/uapi/can.h index 8d0d837d5..1c35a9b9d 100644 --- a/include/rtdm/uapi/can.h +++

[PATCH 3/6] drivers/can: add len field to can frame structures

2021-11-24 Thread Dario Binacchi via Xenomai
As mentioned in Linux, can_dlc is a misleading name that suggests a code instead of a length. Adding the len field can_dlc becomes deprecated too. Signed-off-by: Dario Binacchi --- include/rtdm/uapi/can.h | 5 - kernel/drivers/can/rtcan_socket.h | 5 - 2 files changed, 8

[PATCH 1/6] drivers/can: add multi message support to sendmsg

2021-11-24 Thread Dario Binacchi via Xenomai
The `user_msghdr' structure is designed to send multiple messages as well, so rtcan_raw_sendmsg() can also send multiple messages. This avoids having to add the sendmmsg system call which requires more extensive Xenomai changes. Signed-off-by: Dario Binacchi --- kernel/drivers/can/rtcan_raw.c

Re: [PATCH v2 1/6] drivers/can: add multi message support to sendmsg

2021-12-01 Thread Dario Binacchi via Xenomai
Hi Jan, > Il 01/12/2021 07:15 Jan Kiszka ha scritto: > > > On 30.11.21 09:33, Jan Kiszka via Xenomai wrote: > > On 29.11.21 23:07, Dario Binacchi wrote: > >> The `user_msghdr' structure is designed to send multiple messages as > >> well, so rtcan_raw_sendmsg() can also send multiple messages.

[PATCH v4 8/8] drivers/can: add support for Bosch C_CAN controller

2021-12-12 Thread Dario Binacchi via Xenomai
Bosch C_CAN controller is a full-CAN implementation which is compliant to CAN protocol version 2.0 part A and B. Starting from the RTDM porting [1] by Stephen Battazzo, Michael applied some fixes for proper driver operation. Then I ported the commits from Linux kernel version 5.12 and finally I

[PATCH v4 2/8] testsuite/smokey: add virtual CAN testsuite

2021-12-12 Thread Dario Binacchi via Xenomai
Add a minimal test for the virtual CAN driver, checking that sent messages are received correctly. The timeout on read operations has been wired to 1 s in order not to fail the test in case the verbose option is enabled. Signed-off-by: Dario Binacchi --- Changes in v4: - Load/unload the CAN

[PATCH v4 5/8] drivers/can: add len field to can frame structures

2021-12-12 Thread Dario Binacchi via Xenomai
As mentioned in Linux, can_dlc is a misleading name that suggests a code instead of a length. Adding the len field can_dlc becomes deprecated too. Signed-off-by: Dario Binacchi --- (no changes since v1) include/rtdm/uapi/can.h | 5 - kernel/drivers/can/rtcan_socket.h | 5 -

[PATCH v4 7/8] drivers/can: fix updating of tx_count statistics

2021-12-12 Thread Dario Binacchi via Xenomai
As in the Linux kernel, the counter is updated only after the message has been really transmitted. Signed-off-by: Dario Binacchi --- (no changes since v1) kernel/drivers/can/mscan/rtcan_mscan.c | 1 + kernel/drivers/can/rtcan_flexcan.c | 1 + kernel/drivers/can/rtcan_raw.c

[PATCH v4 1/8] lib/smokey: add smokey_{modprobe,rmmod} helpers

2021-12-12 Thread Dario Binacchi via Xenomai
Both functions, implemented and used for the net, are general purpose and therefore can be useful in other parts of the application with the application of minimal changes. Signed-off-by: Dario Binacchi --- Changes in v4: - Add the patch to the series. include/smokey/smokey.h |

[PATCH v4 3/8] drivers/can: add multi message support to sendmsg

2021-12-12 Thread Dario Binacchi via Xenomai
The `user_msghdr' structure is designed to send multiple messages as well, so rtcan_raw_sendmsg() can also send multiple messages. This avoids having to add the sendmmsg system call which requires more extensive Xenomai changes. Signed-off-by: Dario Binacchi --- (no changes since v1)

[PATCH v4 6/8] drivers/can: add a minimal support to ethtool API

2021-12-12 Thread Dario Binacchi via Xenomai
Like in the Linux kernel, the API allows to get/set device controller parameters. For now it only supports: - ETHTOOL_GDRVINFO: get general driver and device information - ETHTOOL_GRINGPARAM: get RX/TX ring parameters It allows the userspace to know the number of messages managed by the

[PATCH v4 0/8] drivers/can: add support for Bosch C_CAN controller

2021-12-12 Thread Dario Binacchi via Xenomai
The series was created to optimize the use of the C_CAN controller (maximum number of message objects, use of FIFO, ...) to get the best possible RX/TX throughput from hardware. To emphasize the purpose of the series I also added the patch which adds multi-message support to `sendmsg ', rather

[PATCH v4 4/8] drivers/can: add CAN_ERR_CRTL_ACTIVE info status

2021-12-12 Thread Dario Binacchi via Xenomai
To be used in case of recovered to error active state. Signed-off-by: Dario Binacchi --- (no changes since v1) include/rtdm/uapi/can.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/rtdm/uapi/can.h b/include/rtdm/uapi/can.h index 8d0d837d5..1c35a9b9d 100644 ---

[PATCH v3 0/7] drivers/can: add support for Bosch C_CAN controller

2021-12-05 Thread Dario Binacchi via Xenomai
The series was created to optimize the use of the C_CAN controller (maximum number of message objects, use of FIFO, ...) to get the best possible RX/TX throughput from hardware. To emphasize the purpose of the series I also added the patch which adds multi-message support to `sendmsg ', rather

[PATCH v3 2/7] drivers/can: add multi message support to sendmsg

2021-12-05 Thread Dario Binacchi via Xenomai
The `user_msghdr' structure is designed to send multiple messages as well, so rtcan_raw_sendmsg() can also send multiple messages. This avoids having to add the sendmmsg system call which requires more extensive Xenomai changes. Signed-off-by: Dario Binacchi --- (no changes since v1)

[PATCH v3 5/7] drivers/can: add a minimal support to ethtool API

2021-12-05 Thread Dario Binacchi via Xenomai
Like in the Linux kernel, the API allows to get/set device controller parameters. For now it only supports: - ETHTOOL_GDRVINFO: get general driver and device information - ETHTOOL_GRINGPARAM: get RX/TX ring parameters It allows the userspace to know the number of messages managed by the

[PATCH v3 6/7] drivers/can: fix updating of tx_count statistics

2021-12-05 Thread Dario Binacchi via Xenomai
As in the Linux kernel, the counter is updated only after the message has been really transmitted. Signed-off-by: Dario Binacchi --- (no changes since v1) kernel/drivers/can/mscan/rtcan_mscan.c | 1 + kernel/drivers/can/rtcan_flexcan.c | 1 + kernel/drivers/can/rtcan_raw.c

[PATCH v3 7/7] drivers/can: add support for Bosch C_CAN controller

2021-12-05 Thread Dario Binacchi via Xenomai
Bosch C_CAN controller is a full-CAN implementation which is compliant to CAN protocol version 2.0 part A and B. Starting from the RTDM porting [1] by Stephen Battazzo, Michael applied some fixes for proper driver operation. Then I ported the commits from Linux kernel version 5.12 and finally I

[PATCH v3 1/7] testsuite/smokey: add virtual CAN testsuite

2021-12-05 Thread Dario Binacchi via Xenomai
Add a minimal test for the virtual CAN driver, checking that sent messages are received correctly. The timeout on read operations has been wired to 1 s in order not to fail the test in case the verbose option is enabled. Signed-off-by: Dario Binacchi --- (no changes since v1) configure.ac

[PATCH v3 4/7] drivers/can: add len field to can frame structures

2021-12-05 Thread Dario Binacchi via Xenomai
As mentioned in Linux, can_dlc is a misleading name that suggests a code instead of a length. Adding the len field can_dlc becomes deprecated too. Signed-off-by: Dario Binacchi --- (no changes since v1) include/rtdm/uapi/can.h | 5 - kernel/drivers/can/rtcan_socket.h | 5 -

[PATCH v3 3/7] drivers/can: add CAN_ERR_CRTL_ACTIVE info status

2021-12-05 Thread Dario Binacchi via Xenomai
To be used in case of recovered to error active state. Signed-off-by: Dario Binacchi --- (no changes since v1) include/rtdm/uapi/can.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/rtdm/uapi/can.h b/include/rtdm/uapi/can.h index 8d0d837d5..1c35a9b9d 100644 ---

Re: [PATCH v4 1/8] lib/smokey: add smokey_{modprobe,rmmod} helpers

2021-12-13 Thread Dario Binacchi via Xenomai
Hi Jan, > Il 13/12/2021 13:11 Jan Kiszka ha scritto: > > > On 13.12.21 11:43, Jan Kiszka via Xenomai wrote: > > On 12.12.21 12:56, Dario Binacchi wrote: > >> Both functions, implemented and used for the net, are general purpose > >> and therefore can be useful in other parts of the