Re: [Xenomai-core] [PATCH] Add support for sharing kernel/userland data between Xenomai and Linux

2009-12-22 Thread Gilles Chanteperdrix
wolfgang.maue...@siemens.com wrote: From: Wolfgang Mauerer wolfgang.maue...@siemens.com A new structure (struct xnshared) is introduced. It allows us to share generic data between user and kernel of Linux and Xenomai; a bitmap of feature flags located at the beginning of the structure

Re: [Xenomai-core] [PATCH] Add support for sharing kernel/userland data between Xenomai and Linux

2009-12-22 Thread Gilles Chanteperdrix
Gilles Chanteperdrix wrote: wolfgang.maue...@siemens.com wrote: +/* + * We re-use the global semaphore heap to provide a multi-purpose shared + * memory area between Xenomai and Linux - for both kernel and userland + */ +void __init xnheap_init_shared(void) +{ +xnshared = (struct

Re: [Xenomai-core] [PATCH] Add support for sharing kernel/userland data between Xenomai and Linux

2009-12-22 Thread Wolfgang Mauerer
Gilles Chanteperdrix wrote: wolfgang.maue...@siemens.com wrote: From: Wolfgang Mauerer wolfgang.maue...@siemens.com A new structure (struct xnshared) is introduced. It allows us to share generic data between user and kernel of Linux and Xenomai; a bitmap of feature flags located at the

Re: [Xenomai-core] [PATCH] Add support for sharing kernel/userland data between Xenomai and Linux

2009-12-22 Thread Gilles Chanteperdrix
Wolfgang Mauerer wrote: +enum xnshared_features { +/* XNSHARED_FEAT_A = 1, + XNSHARED_FEAT_B, */ + XNSHARED_MAX_FEATURES, +}; Xenomai style is to use defines bit with the bit shifted directly, so, XNSHARED_FEAT_A would rather be 0x0001, and I am not sure an enum can be 64

Re: [Xenomai-core] [PATCH] Add support for sharing kernel/userland data between Xenomai and Linux

2009-12-22 Thread Wolfgang Mauerer
Gilles Chanteperdrix wrote: Wolfgang Mauerer wrote: +enum xnshared_features { +/*XNSHARED_FEAT_A = 1, + XNSHARED_FEAT_B, */ + XNSHARED_MAX_FEATURES, +}; Xenomai style is to use defines bit with the bit shifted directly, so, XNSHARED_FEAT_A would rather be 0x0001, and

Re: [Xenomai-core] [PATCH] Add support for sharing kernel/userland data between Xenomai and Linux

2009-12-22 Thread Gilles Chanteperdrix
Wolfgang Mauerer wrote: Gilles Chanteperdrix wrote: Wolfgang Mauerer wrote: +enum xnshared_features { +/* XNSHARED_FEAT_A = 1, + XNSHARED_FEAT_B, */ + XNSHARED_MAX_FEATURES, +}; Xenomai style is to use defines bit with the bit shifted directly, so, XNSHARED_FEAT_A would rather be

Re: [Xenomai-core] [PATCH] Add support for sharing kernel/userland data between Xenomai and Linux

2009-12-22 Thread Wolfgang Mauerer
Gilles Chanteperdrix wrote: Wolfgang Mauerer wrote: Gilles Chanteperdrix wrote: Wolfgang Mauerer wrote: +enum xnshared_features { +/* XNSHARED_FEAT_A = 1, +XNSHARED_FEAT_B, */ +XNSHARED_MAX_FEATURES, +}; Xenomai style is to use defines bit with the bit shifted

Re: [Xenomai-core] [PATCH] Add support for sharing kernel/userland data between Xenomai and Linux

2009-12-22 Thread Gilles Chanteperdrix
Wolfgang Mauerer wrote: Gilles Chanteperdrix wrote: Wolfgang Mauerer wrote: Gilles Chanteperdrix wrote: Wolfgang Mauerer wrote: +enum xnshared_features { +/* XNSHARED_FEAT_A = 1, + XNSHARED_FEAT_B, */ + XNSHARED_MAX_FEATURES, +}; Xenomai style is to use defines bit with

Re: [Xenomai-core] [PATCH] Add support for sharing kernel/userland data between Xenomai and Linux

2009-12-22 Thread Wolfgang Mauerer
Gilles Chanteperdrix wrote: Wolfgang Mauerer wrote: Gilles Chanteperdrix wrote: Wolfgang Mauerer wrote: Gilles Chanteperdrix wrote: Wolfgang Mauerer wrote: (...) Would it therefore make sense to restrict the data exchange to the global heap semaphore, and add an architecture-specific

[Xenomai-core] [PATCH] Add support for sharing kernel/userland data between Xenomai and Linux

2009-12-21 Thread wolfgang . mauerer
From: Wolfgang Mauerer wolfgang.maue...@siemens.com A new structure (struct xnshared) is introduced. It allows us to share generic data between user and kernel of Linux and Xenomai; a bitmap of feature flags located at the beginning of the structure identifies which data are shared. The structure