Re: [Xenomai-core] Patch for RTDM recvmsg bug
Sebastian Smolorz wrote: Hi, here's a patch for a bug in skins/rtdm/syscall.c. The msghdr was not copied to user space upon completion of a recvmsg() call if the return value was not equal to zero. But recvmsg shall return the length of the message in bytes (according to IEEE Std 1003.1). Applied, thanks. I have the permission from Jan to patch his code. ;-) Sebastian --- xenomai/skins/rtdm/syscall.c2005-11-10 16:45:24.0 +0100 +++ syscall.c 2005-11-10 16:27:08.0 +0100 @@ -99,7 +99,7 @@ static int sys_rtdm_recvmsg(struct task_ ret = _rtdm_recvmsg(curr, __xn_reg_arg1(regs), krnl_msg, __xn_reg_arg3(regs)); -if (!ret) +if (ret = 0) __xn_copy_to_user(curr, (void __user *)__xn_reg_arg2(regs), krnl_msg, sizeof(krnl_msg)); ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core -- Philippe. ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
[Xenomai-core] Xenomai homepage
Hi, just to bring this topic in mind again: what is currently preventing to activate Bruno's nice page as the main Xenomai site? I see no significant features lacking, fine-tuning can still be done later. This project deserves a more representative portal than the Gna site! ;) Jan signature.asc Description: OpenPGP digital signature
Re: [Xenomai-core] Patch for RTDM recvmsg bug
Sebastian Smolorz wrote: Hi, here's a patch for a bug in skins/rtdm/syscall.c. The msghdr was not copied to user space upon completion of a recvmsg() call if the return value was not equal to zero. But recvmsg shall return the length of the message in bytes (according to IEEE Std 1003.1). Applied, thanks. I have the permission from Jan to patch his code. ;-) Sebastian --- xenomai/skins/rtdm/syscall.c2005-11-10 16:45:24.0 +0100 +++ syscall.c 2005-11-10 16:27:08.0 +0100 @@ -99,7 +99,7 @@ static int sys_rtdm_recvmsg(struct task_ ret = _rtdm_recvmsg(curr, __xn_reg_arg1(regs), krnl_msg, __xn_reg_arg3(regs)); -if (!ret) +if (ret = 0) __xn_copy_to_user(curr, (void __user *)__xn_reg_arg2(regs), krnl_msg, sizeof(krnl_msg)); ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core -- Philippe.
