Re: [Xenomai-core] [PATCH] hal: Ensure atomicity of rthal_local_irq_disabled

2009-11-10 Thread Jan Kiszka
Philippe Gerum wrote: > On Tue, 2009-11-10 at 12:33 +0100, Jan Kiszka wrote: >> Philippe Gerum wrote: >>> On Tue, 2009-11-10 at 11:43 +0100, Jan Kiszka wrote: >> [...] Oh, *_hw_smp is new, isn't it? Do we need to wrap it for older I-pipes? >>> Yes, it was introduced to solve the SMP migration

Re: [Xenomai-core] [PATCH] hal: Ensure atomicity of rthal_local_irq_disabled

2009-11-10 Thread Philippe Gerum
On Tue, 2009-11-10 at 12:33 +0100, Jan Kiszka wrote: > Philippe Gerum wrote: > > On Tue, 2009-11-10 at 11:43 +0100, Jan Kiszka wrote: > [...] > >> Oh, *_hw_smp is new, isn't it? Do we need to wrap it for older I-pipes? > > > > Yes, it was introduced to solve the SMP migration issue actually, so we

Re: [Xenomai-core] [PATCH] hal: Ensure atomicity of rthal_local_irq_disabled

2009-11-10 Thread Jan Kiszka
Philippe Gerum wrote: > On Tue, 2009-11-10 at 11:43 +0100, Jan Kiszka wrote: [...] >> Oh, *_hw_smp is new, isn't it? Do we need to wrap it for older I-pipes? > > Yes, it was introduced to solve the SMP migration issue actually, so we > need a wrapper. The advantage of having that wrapper instead o

Re: [Xenomai-core] [PATCH] hal: Ensure atomicity of rthal_local_irq_disabled

2009-11-10 Thread Philippe Gerum
On Tue, 2009-11-10 at 11:43 +0100, Jan Kiszka wrote: > Philippe Gerum wrote: > > On Tue, 2009-11-10 at 01:34 +0100, Gilles Chanteperdrix wrote: > >> Jan Kiszka wrote: > >>> [Patch is now also available in 'for-upstream'] > >>> > >>> ipipe_test_pipeline_from is not atomic /wrt reading the current cp

Re: [Xenomai-core] [PATCH] hal: Ensure atomicity of rthal_local_irq_disabled

2009-11-10 Thread Jan Kiszka
Philippe Gerum wrote: > On Tue, 2009-11-10 at 01:34 +0100, Gilles Chanteperdrix wrote: >> Jan Kiszka wrote: >>> [Patch is now also available in 'for-upstream'] >>> >>> ipipe_test_pipeline_from is not atomic /wrt reading the current cpu >>> number (or an offset for the per-cpu area) and actually rea

Re: [Xenomai-core] [PATCH] hal: Ensure atomicity of rthal_local_irq_disabled

2009-11-10 Thread Philippe Gerum
On Tue, 2009-11-10 at 11:28 +0100, Philippe Gerum wrote: > On Tue, 2009-11-10 at 01:34 +0100, Gilles Chanteperdrix wrote: > > Jan Kiszka wrote: > > > [Patch is now also available in 'for-upstream'] > > > > > > ipipe_test_pipeline_from is not atomic /wrt reading the current cpu > > > number (or an

Re: [Xenomai-core] [PATCH] hal: Ensure atomicity of rthal_local_irq_disabled

2009-11-10 Thread Philippe Gerum
On Tue, 2009-11-10 at 01:34 +0100, Gilles Chanteperdrix wrote: > Jan Kiszka wrote: > > [Patch is now also available in 'for-upstream'] > > > > ipipe_test_pipeline_from is not atomic /wrt reading the current cpu > > number (or an offset for the per-cpu area) and actually reading the > > virtualized

Re: [Xenomai-core] [PATCH] hal: Ensure atomicity of rthal_local_irq_disabled

2009-11-09 Thread Jan Kiszka
Gilles Chanteperdrix wrote: > Jan Kiszka wrote: >> [Patch is now also available in 'for-upstream'] >> >> ipipe_test_pipeline_from is not atomic /wrt reading the current cpu >> number (or an offset for the per-cpu area) and actually reading the >> virtualized interrupt state. Work around this by dis

Re: [Xenomai-core] [PATCH] hal: Ensure atomicity of rthal_local_irq_disabled

2009-11-09 Thread Gilles Chanteperdrix
Jan Kiszka wrote: > [Patch is now also available in 'for-upstream'] > > ipipe_test_pipeline_from is not atomic /wrt reading the current cpu > number (or an offset for the per-cpu area) and actually reading the > virtualized interrupt state. Work around this by disabling hard IRQs > while accessing

[Xenomai-core] [PATCH] hal: Ensure atomicity of rthal_local_irq_disabled

2009-11-09 Thread Jan Kiszka
[Patch is now also available in 'for-upstream'] ipipe_test_pipeline_from is not atomic /wrt reading the current cpu number (or an offset for the per-cpu area) and actually reading the virtualized interrupt state. Work around this by disabling hard IRQs while accessing this service. This fixes fal