[Xenomai-core] Re: [PATCH] Shared interrupts (yet another movie :)

[Philippe Gerum]

Dmitry Adamushko wrote:


Hi there,

I have explicitly cc'ed Gilles as this patch affects the posix skin.

In the light of the recent discussions, the AUTOENA flag has been 
converted to NOAUTOENA and the IRQ line is re-enabled on return from 
xnintr_irq_handler() and shirq brothers by default.

Also XN_ISR_CHAINED -> XN_ISR_PROPAGATE.

I'm still not sutisfied with results, namely - return values of ISR. 
But, well, this is a quite separate question to the shirq support so the 
later one should not remain in pending status only because of that.


I still would like to see something along scalar values : NONE, HANDLED, 
PROPAGATE and xnintr_disable() being called in ISR to defer IRQ line 
enabling (not .ending -> PROPAGATE does it).

(*)

Currently, there is a XN_ISR_NOENABLE bit which asks the real-time layer 
to defer the IRQ line, Warning!, .ending (and not just enabling) until 
later. In common case, xnarch_end_irq() must be called by the rt_task 
that stands for a bottom half (and not just xnintr_enable() - this may 
not work on ppc).
This adds a bit of confusion and we will avoid it with (*) scheme. So 
this is a subject to change in the future.
As I pointed out in another message, the implementation for PPC is not 
yet clear at the moment. That's it...




That's great.


Ok, are there any objections as to the current patch? If no, please apply.



Applied, thanks.

CHANGELOG.patch is here 
https://mail.gna.org/public/xenomai-core/2006-02/msg00154.html


--
Best regards,
Dmitry Adamushko



--

Philippe.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core

[Xenomai-core] Re: [PATCH] Shared interrupts (yet another movie :)

[Philippe Gerum]

Dmitry Adamushko wrote:


On 28/02/06, *Jan Kiszka* <[EMAIL PROTECTED] > 
wrote:


Dmitry Adamushko wrote:
 > ...
 > Ok, are there any objections as to the current patch? If no,
please apply.
 >

Oops, I found a minor problem:

make[2]: Entering directory `/usr/src/xenomai/build/doc/doxygen'
doxygen
/usr/src/xenomai/ksrc/skins/native/intr.c:523: Warning: no matching file
member found for
int rt_intr_create(RT_INTR *intr, unsigned irq, int mode)
Possible candidates:
  int rt_intr_create(RT_INTR *intr, const char *name, unsigned irq, int
mode)


...

int rt_intr_bind(rt_intr_placeholder *intr, unsigned irq, RTIME timeout)
Possible candidates:
  int rt_intr_bind(RT_INTR *intr, const char *name, RTIME timeout)
  int rt_intr_bind(RT_INTR *intr, const char *name, RTIME timeout)

Seems the doc is not yet up-to-date.


Thanks. I have overlooked some parts. This patch fixes it up (should be 
applied after the main patch).


 


Applied, thanks.




Jan



--
Best regards,
Dmitry Adamushko



--

Philippe.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core

[Xenomai-core] Re: [PATCH] Shared interrupts (yet another movie :)

[Dmitry Adamushko]

On 28/02/06, Jan Kiszka <[EMAIL PROTECTED]> wrote:
Dmitry Adamushko wrote:> ...> Ok, are there any objections as to the current patch? If no, please apply.>Oops, I found a minor problem:make[2]: Entering directory `/usr/src/xenomai/build/doc/doxygen'
doxygen/usr/src/xenomai/ksrc/skins/native/intr.c:523: Warning: no matching filemember found forint rt_intr_create(RT_INTR *intr, unsigned irq, int mode)Possible candidates:  int rt_intr_create(RT_INTR *intr, const char *name, unsigned irq, int
mode)
... 
int rt_intr_bind(rt_intr_placeholder *intr, unsigned irq, RTIME timeout)Possible candidates:
  int rt_intr_bind(RT_INTR *intr, const char *name, RTIME timeout)  int rt_intr_bind(RT_INTR *intr, const char *name, RTIME timeout)Seems the doc is not yet up-to-date.
Thanks. I have overlooked some parts. This patch fixes it up (should be applied after the main patch).

 

Jan
-- Best regards,Dmitry Adamushko


shirq-doc-update.patch
Description: Binary data
___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core

[Xenomai-core] Re: [PATCH] Shared interrupts (yet another movie :)

[Jan Kiszka]

Dmitry Adamushko wrote:
> Hi there,
> 
> I have explicitly cc'ed Gilles as this patch affects the posix skin.
> 
> In the light of the recent discussions, the AUTOENA flag has been converted
> to NOAUTOENA and the IRQ line is re-enabled on return from
> xnintr_irq_handler() and shirq brothers by default.
> Also XN_ISR_CHAINED -> XN_ISR_PROPAGATE.
> 
> I'm still not sutisfied with results, namely - return values of ISR. But,
> well, this is a quite separate question to the shirq support so the later
> one should not remain in pending status only because of that.
> 
> I still would like to see something along scalar values : NONE, HANDLED,
> PROPAGATE and xnintr_disable() being called in ISR to defer IRQ line
> enabling (not .ending -> PROPAGATE does it).
> (*)
> 
> Currently, there is a XN_ISR_NOENABLE bit which asks the real-time layer to
> defer the IRQ line, Warning!, .ending (and not just enabling) until later.
> In common case, xnarch_end_irq() must be called by the rt_task that stands
> for a bottom half (and not just xnintr_enable() - this may not work on ppc).
> This adds a bit of confusion and we will avoid it with (*) scheme. So this
> is a subject to change in the future.
> As I pointed out in another message, the implementation for PPC is not yet
> clear at the moment. That's it...
> 
> Ok, are there any objections as to the current patch? If no, please apply.

No objections from my side (I'm overseeing those 2 or 3 white-space
inconsistencies ;) ), should get applied!

I will prepare and commit the remaining tiny updates of RTDM and 16550A
(regarding propagate and re-enable) as soon as this one is merged.

> 
> CHANGELOG.patch is here
> https://mail.gna.org/public/xenomai-core/2006-02/msg00154.html
> 
> --
> Best regards,
> Dmitry Adamushko
> 

Thanks for all your efforts!

Jan



signature.asc
Description: OpenPGP digital signature
___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core