Re: [Xenomai-core] rtdm_iomap_to_user() with PowerPC

2007-11-08 Thread Philippe Gerum
Jan Kiszka wrote:
 Markus Osterried wrote:
 Sorry for being intrusive.
 I've already done a quick and dirty bug fix, so final bug fix is not
 urgent.
 Just wanted to know about time schedule.
 
 At least 2.4 is near, but I guess another 2.3 release will follow as
 well (due to recently accumulated fixes). So the time is right to pick
 this up again.
 
 And although Philippe said he would fix this one on his own, this does
 not have to mean no one else would be able to provide an equivalent fix
 as well and he wouldn't be happy to save the otherwise required time... :)
 

Indeed. Quite frankly, the bug report is patiently pending in my queue,
so it was not lost, but I just had no time to address this seriously.
Have everything converge to roll out 2.4 drains much of my Xenomai time,
so I tend to put the non-critical issues on the back burner for now,
especially if they might break things in subtle ways.
Since there is a work around for this issue, and the final fix may make
it to any stable branch once 2.4 is out, I've postponed the latter.

-- 
Philippe.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] rtdm_iomap_to_user() with PowerPC

2007-11-07 Thread Jan Kiszka
Markus Osterried wrote:
 Sorry for being intrusive.
 I've already done a quick and dirty bug fix, so final bug fix is not
 urgent.
 Just wanted to know about time schedule.

At least 2.4 is near, but I guess another 2.3 release will follow as
well (due to recently accumulated fixes). So the time is right to pick
this up again.

And although Philippe said he would fix this one on his own, this does
not have to mean no one else would be able to provide an equivalent fix
as well and he wouldn't be happy to save the otherwise required time... :)

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


[Xenomai-core] rtdm_iomap_to_user() with PowerPC

2007-11-07 Thread Markus Osterried
Hello,

two months ago I reported a problem with rtdm_iomap_to_user().
Philippe acknowledged the problem and promised to submit a bug fix.
Unfortunately, till now I don't have seen this bug fix, or have
overlooked it?
Can you please give me a hint about the roadmap?
Thanks.

Markus

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] rtdm_iomap_to_user() with PowerPC

2007-11-07 Thread Markus Osterried
Sorry for being intrusive.
I've already done a quick and dirty bug fix, so final bug fix is not
urgent.
Just wanted to know about time schedule.

Markus



-Original Message-
From: Jan Kiszka [mailto:[EMAIL PROTECTED] 
Sent: Mittwoch, 7. November 2007 15:46
To: Markus Osterried
Cc: Philippe Gerum; Xenomai-core@gna.org
Subject: Re: [Xenomai-core] rtdm_iomap_to_user() with PowerPC

Markus Osterried wrote:
 Hello,
 
 two months ago I reported a problem with rtdm_iomap_to_user().
 Philippe acknowledged the problem and promised to submit a bug fix.
 Unfortunately, till now I don't have seen this bug fix, or have 
 overlooked it?

Please post your bugs to our bugtracker on gna.org if you feel like it
is getting/already got lost. Everyone is busy, and I'm afraid this
particular issue remained unfixed unintentionally.

 Can you please give me a hint about the roadmap?

This is surely a must-fix for both 2.4 and the next 2.3 releases, we are
only lacking the patch. Unless Philippe is able to come out with
something over the next, say, two days, I would suggest to develop a fix
along his original suggestions on your own. As far as I understood, we
need an arch-specific wrapper for io-remapping in
include/asm-powerps/wrappers.h and awareness for this specific solution
in asm-generic/wrappers.h.

Jan

--
Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center
Embedded Linux

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] rtdm_iomap_to_user() with PowerPC

2007-11-07 Thread Jan Kiszka
Markus Osterried wrote:
 Hello,
 
 two months ago I reported a problem with rtdm_iomap_to_user().
 Philippe acknowledged the problem and promised to submit a bug fix.
 Unfortunately, till now I don't have seen this bug fix, or have
 overlooked it?

Please post your bugs to our bugtracker on gna.org if you feel like it
is getting/already got lost. Everyone is busy, and I'm afraid this
particular issue remained unfixed unintentionally.

 Can you please give me a hint about the roadmap?

This is surely a must-fix for both 2.4 and the next 2.3 releases, we are
only lacking the patch. Unless Philippe is able to come out with
something over the next, say, two days, I would suggest to develop a fix
along his original suggestions on your own. As far as I understood, we
need an arch-specific wrapper for io-remapping in
include/asm-powerps/wrappers.h and awareness for this specific solution
in asm-generic/wrappers.h.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


[Xenomai-core] rtdm_iomap_to_user() with PowerPC

2007-09-06 Thread Markus Osterried (BA/EDD)
Hello,

I want to use rtdm_iomap_to_user() to map our device registers to user
space.
But this doesn't work, our application just crashes when I read from the
mapped registers.

When I insert the line

vma-vm_page_prot = phys_mem_access_prot(filp,
paddrPAGE_SHIFT, size, vma-vm_page_prot);

in rtdm_mmap_buffer() just before calling xnarch_remap_io_page_range()
it works fine.
This is just like it is done in /drivers/char/mem.c and in
/drivers/video/fbmem.c.

But I think this is architecture and kernel version dependent and I
don't know whether rtdm_mmap_buffer() is the right place.
I use Xenomai 2.3.1 and Linux 2.6.18 with PowerPC CPU.
What is the best solution? Everyone else seen this problem?

Thanks
Markus

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] rtdm_iomap_to_user() with PowerPC

2007-09-06 Thread Jan Kiszka
Markus Osterried (BA/EDD) wrote:
 Hello,
 
 I want to use rtdm_iomap_to_user() to map our device registers to user
 space.
 But this doesn't work, our application just crashes when I read from the
 mapped registers.
 
 When I insert the line
 
   vma-vm_page_prot = phys_mem_access_prot(filp,
 paddrPAGE_SHIFT, size, vma-vm_page_prot);
 
 in rtdm_mmap_buffer() just before calling xnarch_remap_io_page_range()
 it works fine.

[hint: using diff -up helps the reader to quickly localise your changes.]

 This is just like it is done in /drivers/char/mem.c and in
 /drivers/video/fbmem.c.
 
 But I think this is architecture and kernel version dependent and I
 don't know whether rtdm_mmap_buffer() is the right place.
 I use Xenomai 2.3.1 and Linux 2.6.18 with PowerPC CPU.
 What is the best solution? Everyone else seen this problem?

Providing phys_mem_access_prot() services for
xnarch_remap_io_page_range() looks like it is actually required -
practically at least for PPC, but I can't tell immediately if there
aren't other yet unnoticed side effect of skipping it.

Hmm, can we extend xnarch_remap_io_page_range()/
wrap_remap_io_page_range() to take care of this as well? Suggestions
(ie. patches) welcome!

Jan



signature.asc
Description: OpenPGP digital signature
___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core