Re: [Xenomai-core] [PATCH] add tut02-skeleton

2007-05-29 Thread Jan Kiszka
trem wrote: > Hi > > You're right, perror could be used instead of strerror(-ret), it's > simpler. And I've remoded all "fflush", as you said, there are useless > and it's a tutorial about xenomai. So I think that those "fflush" aren't > necessary. > Thanks, merged with minor beautifications. P

Re: [Xenomai-core] [PATCH] add tut02-skeleton

2007-05-28 Thread trem
Hi You're right, perror could be used instead of strerror(-ret), it's simpler. And I've remoded all "fflush", as you said, there are useless and it's a tutorial about xenomai. So I think that those "fflush" aren't necessary. Thanks for feedback, Philippe Gilles Chanteperdrix wrote: > trem wrote

Re: [Xenomai-core] [PATCH] add tut02-skeleton

2007-05-28 Thread Gilles Chanteperdrix
trem wrote: > Hi > > Thanks for the reply (jan too). I've tried to use all of your feedback, > and I send you the new release of this tut02. > > (...) > +/* no memory-swapping for this programm */ > +ret = mlockall(MCL_CURRENT | MCL_FUTURE); > +if (ret) { > +fpri

Re: [Xenomai-core] [PATCH] add tut02-skeleton

2007-05-28 Thread trem
Hi Thanks for the reply (jan too). I've tried to use all of your feedback, and I send you the new release of this tut02. regards, Philippe Gilles Chanteperdrix wrote: > trem wrote: > > + mlockall(MCL_CURRENT | MCL_FUTURE); > > Please show people the right way to code, check the return value

Re: [Xenomai-core] [PATCH] add tut02-skeleton

2007-05-28 Thread Gilles Chanteperdrix
trem wrote: > +mlockall(MCL_CURRENT | MCL_FUTURE); Please show people the right way to code, check the return value of mlockall here. > +if (rtdm_safe_copy_to_user(user_info, buf, buffer.data, size)) > +rtdm_printk("ERROR : can't copy data from driver\n"); > + > +/* c

Re: [Xenomai-core] [PATCH] add tut02-skeleton

2007-05-28 Thread Jan Kiszka
trem wrote: > Hi > > Here is the second part of the tutorial serie about rtdm. I've just > added rt-task and semaphore. It's still a very very simple example. Thanks again for your contribution. I have a few comments below. > > Now, I don't know how to continue, have you got any idea of > "topi