Re: [Xenomai-core] [PATCH 07/12] Convert POSIX skin to fast xnsynch

2008-10-16 Thread Gilles Chanteperdrix
Jan Kiszka wrote:

This patch contains too many #ifdefs.

Things like

#ifdef CONFIG_XENO_FASTSYNCH
if (xnsynch_fast_owner_check(...))
#else
if (xnsynch_owner(...) == ...)
#endif

could be replaced with only one macro xnsynch_check_owner in synch.h
that would be defined with some #ifdefs, and used everywhere without
#ifdefs.

-- 
Gilles.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PATCH 07/12] Convert POSIX skin to fast xnsynch

2008-10-16 Thread Jan Kiszka
Gilles Chanteperdrix wrote:
 Jan Kiszka wrote:
 
 This patch contains too many #ifdefs.
 
 Things like
 
 #ifdef CONFIG_XENO_FASTSYNCH
 if (xnsynch_fast_owner_check(...))
 #else
 if (xnsynch_owner(...) == ...)
 #endif
 
 could be replaced with only one macro xnsynch_check_owner in synch.h
 that would be defined with some #ifdefs, and used everywhere without
 #ifdefs.

Yes, that looks like a good idea. Will go through the patch again,
checking for more cleanup possibilities like that.

Jan



signature.asc
Description: OpenPGP digital signature
___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core