Re: [Xenomai-core] [PULL REQUEST] analogy bug fixes

2010-07-09 Thread Alexis Berlemont
Hi,

Gilles Chanteperdrix wrote:
 Alexis Berlemont wrote:
  The following changes since commit 653a38669af4427471ed8cdd129eb0bbb33ba178:
  
nucleus: finalize heap mapping sanitization (2010-07-04 18:57:54 +0200)
 
 Ok. Could you rebase on the current master? The commit message would be:
 Update autotools files

Sorry for the delay. That should be better now.

 
 -- 
   Gilles.

-- 
Alexis.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PULL REQUEST] analogy bug fixes

2010-07-08 Thread Gilles Chanteperdrix
Alexis Berlemont wrote:
 The following changes since commit 653a38669af4427471ed8cdd129eb0bbb33ba178:
 
   nucleus: finalize heap mapping sanitization (2010-07-04 18:57:54 +0200)

Ok. Could you rebase on the current master? The commit message would be:
Update autotools files

-- 
Gilles.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PULL REQUEST] analogy bug fixes + rtdm_rt_capable related changes

2010-05-05 Thread Gilles Chanteperdrix
Alexis Berlemont wrote:
 The following changes since commit
 e9b509c9021e0134117d0fe75d11e495f0e954b7:
 
   arm: add missing #include (2010-05-04 03:44:01 +0200)
 
 are available in the git repository at:
   git://git.xenomai.org/xenomai-abe.git analogy

Pulled, thanks.


-- 
Gilles.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes

2010-03-29 Thread Daniele Nicolodi
Alexis Berlemont wrote:
 There is a bug in cmd_write and cmd_read. I have should have taken
 into account the buffers edges. I will fix it. The function
 a4l_mark_bufrw() is not designed to handle boundaries, that is why its
 arguments represent data size not addresses.

That makes sense. I can provide a patch for cmd_read and cmd_write, as i
got the same kind of code working in my own test programs, but I'm quite
busy right now...

Cheers,
-- 
Daniele


___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes

2010-03-25 Thread Daniele Nicolodi
Daniele Nicolodi wrote:
 Alexis Berlemont wrote:
 If you want to test infinite acquisitions right now, you can clone my
 git repository. I just pushed the modifications on it. I have not made
 a pull request yet because I want to be sure there is no regression. 
 
 Thanks! I'll test it as soon as possible.

I'm testing it now.

 I think I just stumbled into the ring buffer bug you fixed in your
 repository :-) It took me a while to understand if the problem was in
 the hardware, in my code, or somewhere else in the stack...

Unfortunately my ring buffer problem is not fixed by you patch. What I'm
experiencing is exposed by this (pseudo) code:

a4l_open(dsc, device)
a4l_mmap(dsc, subdevice, bufsize, map)
a4l_snd_command(dsc, cmd)

/* preload buffer */
written = write_to_buffer(map, bufsize)

/* send internal trigger */
a4l_snd_insn(dsc,

cnt = 0;
while (1)
  a4l_mark_bufrw(dsc, subdevice, written, towrite);
  cnt += written;
  /* 1 */
  written = write_buffer(map + (cnt % bufsize), towrite)


The problem is that at the place marked with (1) the total extension of
the buffer region that gets written exceeds the ring buffer allocated
memory. That is ((cnt % bufsize) + towrite)  bufsize !

I do not know if this should be handled in my code, or in the driver.
This situation is not handled in the cmd_write example code (where a
simple memcpy() is done).

What do you think?

Cheers,
-- 
Daniele

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes

2010-03-24 Thread Daniele Nicolodi
Alexis Berlemont wrote:
 Daniele Nicolodi wrote:
 Alexis Berlemont wrote:
 The following changes since commit 8cfc1103fe1cf9e700698e8230baf562ffb5cf06:
Gilles Chanteperdrix (1):
  x86 syscalls: make __xn_get_eip a macro

 are available in the git repository at:

git://git.xenomai.org/xenomai-abe.git analogy
 Hello. Looking at your pull request, I see that my patch for correct
 buffer handling when using .stop_src  = TRIG_NONE is not included. Does
 the patch need some more work? Or it simply get lost on the way?
 I have not forgotten it. I did not include it for two reasons:
 - I have not found time to (fully) test it
 - I wanted to properly modify the test program cmd_read so as to allow
   continuous acquisisitions 

Hi Alexis. Sorry for the late response. That's fine, I just wanted to be
sure that the patch was not dropped by mistake. I'll test continuous
output today and let you know if any other bugfix is necessary. I can
also look into providing a patch for cmd_read and cmd_write.

Cheers,
-- 
Daniele

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes

2010-03-21 Thread Alexis Berlemont
Daniele Nicolodi wrote:
 Alexis Berlemont wrote:
  The following changes since commit 8cfc1103fe1cf9e700698e8230baf562ffb5cf06:
 Gilles Chanteperdrix (1):
   x86 syscalls: make __xn_get_eip a macro
  
  are available in the git repository at:
  
 git://git.xenomai.org/xenomai-abe.git analogy
 
 Hello. Looking at your pull request, I see that my patch for correct
 buffer handling when using .stop_src  = TRIG_NONE is not included. Does
 the patch need some more work? Or it simply get lost on the way?
I have not forgotten it. I did not include it for two reasons:
- I have not found time to (fully) test it
- I wanted to properly modify the test program cmd_read so as to allow
  continuous acquisisitions 

 
 Thanks. Cheers,
 -- 
 Daniele
 

-- 
Alexis.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes

2010-03-20 Thread Daniele Nicolodi
Alexis Berlemont wrote:
 The following changes since commit 8cfc1103fe1cf9e700698e8230baf562ffb5cf06:
Gilles Chanteperdrix (1):
  x86 syscalls: make __xn_get_eip a macro
 
 are available in the git repository at:
 
git://git.xenomai.org/xenomai-abe.git analogy

Hello. Looking at your pull request, I see that my patch for correct
buffer handling when using .stop_src  = TRIG_NONE is not included. Does
the patch need some more work? Or it simply get lost on the way?

Thanks. Cheers,
-- 
Daniele

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes + insn_bits

2010-02-07 Thread Gilles Chanteperdrix
Alexis Berlemont wrote:
 The following changes since commit 4a5b93dabf66529e665c8f8422902347d4f6158f:
Jan Kiszka (1):
  RTDM: Split up application and driver debugging
 
 are available in the git repository at:
 
git://git.xenomai.org/xenomai-abe.git analogy

Merged.


-- 
Gilles.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core