Re: [Xenomai-core] [Xenomai-git] Jan Kiszka : x86: Fix return type of DO_SYSCALL_INNER macro
On 2011-04-29 20:38, Gilles Chanteperdrix wrote: GIT version control wrote: Module: xenomai-jki Branch: for-upstream Commit: 852c130d16410a597536c39d06b6abd1c9c6c822 URL: http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=852c130d16410a597536c39d06b6abd1c9c6c822 Author: Jan Kiszka jan.kis...@siemens.com Date: Fri Apr 29 14:12:13 2011 +0200 x86: Fix return type of DO_SYSCALL_INNER macro gcc will complain about 'conversion to ‘int’ from ‘long int’ may alter its value' with -Wconversion as DO_SYSCALL treats the return value of DO_SYSCALL_INNER as int. Align DO_SYSCALL_INNER to its user. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Should not it be aligned the other way around? Using longs everywhere? In case a syscall returns a pointer? Maybe. But let's do this when we have a use case. Lots of arch macros, inline functions, and core code would have to be touched. Jan signature.asc Description: OpenPGP digital signature ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
Re: [Xenomai-core] [Xenomai-git] Jan Kiszka : x86: Fix return type of DO_SYSCALL_INNER macro
Jan Kiszka wrote: On 2011-04-29 20:38, Gilles Chanteperdrix wrote: GIT version control wrote: Module: xenomai-jki Branch: for-upstream Commit: 852c130d16410a597536c39d06b6abd1c9c6c822 URL: http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=852c130d16410a597536c39d06b6abd1c9c6c822 Author: Jan Kiszka jan.kis...@siemens.com Date: Fri Apr 29 14:12:13 2011 +0200 x86: Fix return type of DO_SYSCALL_INNER macro gcc will complain about 'conversion to ‘int’ from ‘long int’ may alter its value' with -Wconversion as DO_SYSCALL treats the return value of DO_SYSCALL_INNER as int. Align DO_SYSCALL_INNER to its user. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Should not it be aligned the other way around? Using longs everywhere? In case a syscall returns a pointer? Maybe. But let's do this when we have a use case. Lots of arch macros, inline functions, and core code would have to be touched. Right, sorry for the noise. -- Gilles. ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
Re: [Xenomai-core] [Xenomai-git] Jan Kiszka : x86: Fix return type of DO_SYSCALL_INNER macro
GIT version control wrote: Module: xenomai-jki Branch: for-upstream Commit: 852c130d16410a597536c39d06b6abd1c9c6c822 URL: http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=852c130d16410a597536c39d06b6abd1c9c6c822 Author: Jan Kiszka jan.kis...@siemens.com Date: Fri Apr 29 14:12:13 2011 +0200 x86: Fix return type of DO_SYSCALL_INNER macro gcc will complain about 'conversion to ‘int’ from ‘long int’ may alter its value' with -Wconversion as DO_SYSCALL treats the return value of DO_SYSCALL_INNER as int. Align DO_SYSCALL_INNER to its user. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Should not it be aligned the other way around? Using longs everywhere? In case a syscall returns a pointer? -- Gilles. ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
