Re: [Xenomai-core] pSOS skin: bug in tm_ticks_to_date() and tm_date_to_ticks()

2008-06-13 Thread Philippe Gerum
Gilles Chanteperdrix wrote:
 On Fri, Jun 13, 2008 at 4:18 PM, Markus Osterried
 [EMAIL PROTECTED] wrote:
 Hello,

 there is a bug in the pSOS kernel-space skin, calculating calendar time to
 ticks and vice versa.
 The file xenomai/ksrc/skins/psos+/tm.c should be fixed like this:
 
 Have you tried Xenomai 2.4.4 ? It contains a fix in the same file.
 

Actually, my fix was wrong, it should have read:

for (n = month - 1; n  0; n--)
-   *count += tm_month_sizes[n];
+   *count += tm_month_sizes[n - 1];

The other hunk, which is an overflow issue has been fixed in SOLO recently, but
not merged back yet, so this still applies.

-- 
Philippe.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] pSOS skin: bug in tm_ticks_to_date() and tm_date_to_ticks()

2008-06-13 Thread Markus Osterried
Sorry, I have not tried 2.4.4 (the same old story, we are a little late
with the versions ... ;-)
But anyway, as Philippe mentioned, both fixes are not okay in 2.4.4.
I hope my fix is correct in both situations.

Markus


-Original Message-
From: Philippe Gerum [mailto:[EMAIL PROTECTED] On Behalf Of
Philippe Gerum
Sent: Freitag, 13. Juni 2008 17:22
To: Gilles Chanteperdrix
Cc: Markus Osterried; Xenomai-core@gna.org
Subject: Re: [Xenomai-core] pSOS skin: bug in tm_ticks_to_date() and
tm_date_to_ticks()

Gilles Chanteperdrix wrote:
 On Fri, Jun 13, 2008 at 4:18 PM, Markus Osterried 
 [EMAIL PROTECTED] wrote:
 Hello,

 there is a bug in the pSOS kernel-space skin, calculating calendar 
 time to ticks and vice versa.
 The file xenomai/ksrc/skins/psos+/tm.c should be fixed like this:
 
 Have you tried Xenomai 2.4.4 ? It contains a fix in the same file.
 

Actually, my fix was wrong, it should have read:

for (n = month - 1; n  0; n--)
-   *count += tm_month_sizes[n];
+   *count += tm_month_sizes[n - 1];

The other hunk, which is an overflow issue has been fixed in SOLO
recently, but not merged back yet, so this still applies.

--
Philippe.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core