[Xenomai-git] Philippe Gerum : cobalt/kernel: drop pointless parameter descriptions
Module: xenomai-3 Branch: next Commit: a7503576b0f70c774ca5008aee481841f3aff920 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=a7503576b0f70c774ca5008aee481841f3aff920 Author: Philippe Gerum r...@xenomai.org Date: Wed Mar 25 09:47:30 2015 +0100 cobalt/kernel: drop pointless parameter descriptions The relevant code is statically built into the kernel, so there is no point in preparing for modinfo to pull this documentation. --- kernel/cobalt/arch/x86/smi.c |1 - kernel/cobalt/posix/process.c |1 - kernel/cobalt/sched.c |1 - 3 files changed, 3 deletions(-) diff --git a/kernel/cobalt/arch/x86/smi.c b/kernel/cobalt/arch/x86/smi.c index 6caedef..7f7c9fd 100644 --- a/kernel/cobalt/arch/x86/smi.c +++ b/kernel/cobalt/arch/x86/smi.c @@ -44,7 +44,6 @@ module_param_string(smi, smi_state_arg, sizeof(smi_state_arg), 0444); static unsigned int smi_masked_bits = 1; /* Global disable bit */ module_param_named(smi_mask, smi_masked_bits, int, 0400); -MODULE_PARM_DESC(smi_mask, Set of bits to mask in the SMI control register); static unsigned int smi_saved_bits; static unsigned short smi_en_addr; diff --git a/kernel/cobalt/posix/process.c b/kernel/cobalt/posix/process.c index 3fb644a..bf684a8 100644 --- a/kernel/cobalt/posix/process.c +++ b/kernel/cobalt/posix/process.c @@ -73,7 +73,6 @@ static int gid_arg = -1; module_param_named(allowed_group, gid_arg, int, 0644); -MODULE_PARM_DESC(allowed_group, GID of the group with access to Xenomai services); static DEFINE_MUTEX(personality_lock); diff --git a/kernel/cobalt/sched.c b/kernel/cobalt/sched.c index f57570e..d394ce8 100644 --- a/kernel/cobalt/sched.c +++ b/kernel/cobalt/sched.c @@ -91,7 +91,6 @@ void xnsched_register_classes(void) static unsigned long wd_timeout_arg = CONFIG_XENO_OPT_WATCHDOG_TIMEOUT; module_param_named(watchdog_timeout, wd_timeout_arg, ulong, 0644); -MODULE_PARM_DESC(watchdog_timeout, Watchdog timeout (s)); /** * @internal ___ Xenomai-git mailing list Xenomai-git@xenomai.org http://www.xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : cobalt/kernel: pair debug options with pipeline debug features
Module: xenomai-3 Branch: next Commit: 1baf594b9f68b6fbf6e2980e86b575185467a89b URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=1baf594b9f68b6fbf6e2980e86b575185467a89b Author: Philippe Gerum r...@xenomai.org Date: Wed Mar 25 15:17:24 2015 +0100 cobalt/kernel: pair debug options with pipeline debug features --- kernel/cobalt/Kconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/cobalt/Kconfig b/kernel/cobalt/Kconfig index 9c754f5..2ebc7a2 100644 --- a/kernel/cobalt/Kconfig +++ b/kernel/cobalt/Kconfig @@ -392,6 +392,7 @@ if XENO_OPT_DEBUG config XENO_OPT_DEBUG_COBALT bool Cobalt runtime assertions + select IPIPE_DEBUG_CONTEXT help This option activates various assertions inside the Cobalt @@ -399,6 +400,7 @@ config XENO_OPT_DEBUG_COBALT config XENO_OPT_DEBUG_CONTEXT bool Check for calling context + select IPIPE_DEBUG_CONTEXT help This option enables checks for the calling context in the @@ -407,6 +409,7 @@ config XENO_OPT_DEBUG_CONTEXT config XENO_OPT_DEBUG_LOCKING bool Spinlock debugging support + select IPIPE_DEBUG_INTERNAL default y if SMP help ___ Xenomai-git mailing list Xenomai-git@xenomai.org http://www.xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : copperplate/init: trap invalid session name early
Module: xenomai-3 Branch: next Commit: 8c0854991cf67919236d720e019107a9910e6620 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=8c0854991cf67919236d720e019107a9910e6620 Author: Philippe Gerum r...@xenomai.org Date: Wed Mar 25 15:09:46 2015 +0100 copperplate/init: trap invalid session name early --- lib/copperplate/init.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/copperplate/init.c b/lib/copperplate/init.c index f6e06d3..ebfa81f 100644 --- a/lib/copperplate/init.c +++ b/lib/copperplate/init.c @@ -523,6 +523,9 @@ static int get_session_root(int *regflags_r) return -ENOMEM; __node_info.session_label = session; *regflags_r |= REGISTRY_ANON; + } else if (strchr(__node_info.session_label, '/')) { + warning(session name may not contain slashes); + return -EINVAL; } ret = asprintf(sessdir, %s/%s/%s, ___ Xenomai-git mailing list Xenomai-git@xenomai.org http://www.xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : doc: drop @file markup from files with no documentation
Module: xenomai-3 Branch: next Commit: 44eb130b4cd01f5870d3dbc2d5d8b828681d7047 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=44eb130b4cd01f5870d3dbc2d5d8b828681d7047 Author: Philippe Gerum r...@xenomai.org Date: Wed Mar 25 16:25:35 2015 +0100 doc: drop @file markup from files with no documentation --- include/cobalt/kernel/rtdm/analogy/buffer.h |3 +-- include/cobalt/kernel/rtdm/analogy/context.h |3 +-- include/cobalt/kernel/rtdm/analogy/device.h |3 +-- include/cobalt/kernel/rtdm/analogy/instruction.h |7 +++ include/cobalt/kernel/rtdm/analogy/rtdm_helpers.h |4 +--- include/cobalt/kernel/rtdm/analogy/transfer.h |3 +-- include/cobalt/kernel/rtdm/can.h |9 - include/cobalt/kernel/rtdm/cobalt.h |5 ++--- include/cobalt/kernel/rtdm/ipc.h |5 ++--- include/cobalt/kernel/rtdm/rtdm.h |7 +++ include/cobalt/kernel/rtdm/serial.h |5 ++--- include/cobalt/kernel/rtdm/testing.h |5 ++--- include/rtdm/ipc.h|5 ++--- lib/analogy/info.c|3 +-- utils/analogy/analogy_calibrate.c |5 ++--- utils/analogy/analogy_calibrate.h |5 ++--- utils/analogy/analogy_config.c|7 +++ utils/analogy/calibration_ni_m.c |5 ++--- utils/analogy/calibration_ni_m.h |5 ++--- utils/analogy/cmd_bits.c |7 +++ utils/analogy/cmd_read.c |7 +++ utils/analogy/cmd_write.c |7 +++ utils/analogy/insn_bits.c |5 ++--- utils/analogy/insn_read.c |5 ++--- utils/analogy/insn_write.c|7 +++ utils/analogy/wf_generate.c |7 +++ 26 files changed, 56 insertions(+), 83 deletions(-) diff --git a/include/cobalt/kernel/rtdm/analogy/buffer.h b/include/cobalt/kernel/rtdm/analogy/buffer.h index d4baefe..e1a0cc9 100644 --- a/include/cobalt/kernel/rtdm/analogy/buffer.h +++ b/include/cobalt/kernel/rtdm/analogy/buffer.h @@ -1,5 +1,4 @@ -/** - * @file +/* * Analogy for Linux, buffer related features * * Copyright (C) 1997-2000 David A. Schleef d...@schleef.org diff --git a/include/cobalt/kernel/rtdm/analogy/context.h b/include/cobalt/kernel/rtdm/analogy/context.h index 71a292c..f619f9c 100644 --- a/include/cobalt/kernel/rtdm/analogy/context.h +++ b/include/cobalt/kernel/rtdm/analogy/context.h @@ -1,5 +1,4 @@ -/** - * @file +/* * Analogy for Linux, context structure / macros declarations * * Copyright (C) 1997-2000 David A. Schleef d...@schleef.org diff --git a/include/cobalt/kernel/rtdm/analogy/device.h b/include/cobalt/kernel/rtdm/analogy/device.h index 4e63bf3..93ecf66 100644 --- a/include/cobalt/kernel/rtdm/analogy/device.h +++ b/include/cobalt/kernel/rtdm/analogy/device.h @@ -1,5 +1,4 @@ -/** - * @file +/* * Analogy for Linux, device related features * * Copyright (C) 1997-2000 David A. Schleef d...@schleef.org diff --git a/include/cobalt/kernel/rtdm/analogy/instruction.h b/include/cobalt/kernel/rtdm/analogy/instruction.h index 9781341..2e8245a 100644 --- a/include/cobalt/kernel/rtdm/analogy/instruction.h +++ b/include/cobalt/kernel/rtdm/analogy/instruction.h @@ -1,9 +1,8 @@ -/** - * @file +/* * Analogy for Linux, instruction related features * - * @note Copyright (C) 1997-2000 David A. Schleef d...@schleef.org - * @note Copyright (C) 2008 Alexis Berlemont alexis.berlem...@free.fr + * Copyright (C) 1997-2000 David A. Schleef d...@schleef.org + * Copyright (C) 2008 Alexis Berlemont alexis.berlem...@free.fr * * Xenomai is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by diff --git a/include/cobalt/kernel/rtdm/analogy/rtdm_helpers.h b/include/cobalt/kernel/rtdm/analogy/rtdm_helpers.h index f3c797b..1f6bfea 100644 --- a/include/cobalt/kernel/rtdm/analogy/rtdm_helpers.h +++ b/include/cobalt/kernel/rtdm/analogy/rtdm_helpers.h @@ -1,5 +1,4 @@ -/** - * @file +/* * Analogy for Linux, Operation system facilities * * Copyright (C) 1997-2000 David A. Schleef d...@schleef.org @@ -141,5 +140,4 @@ int a4l_timedwait_sync(struct a4l_sync * snc, int rt, unsigned long long ns_timeout); void a4l_signal_sync(struct a4l_sync * snc); - #endif /* !_COBALT_RTDM_ANALOGY_RTDM_HELPERS_H */ diff --git a/include/cobalt/kernel/rtdm/analogy/transfer.h b/include/cobalt/kernel/rtdm/analogy/transfer.h index 6674e13..c62c22a 100644 --- a/include/cobalt/kernel/rtdm/analogy/transfer.h +++ b/include/cobalt/kernel/rtdm/analogy/transfer.h @@ -1,5 +1,4 @@ -/** - * @file +/* * Analogy for Linux, transfer related features * * Copyright (C) 1997-2000 David A. Schleef
[Xenomai-git] Philippe Gerum : demo/altency: set default affinity to CPU0
Module: xenomai-3 Branch: next Commit: 215ae29a5fb19511e1dcd6aa888984b2726e7401 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=215ae29a5fb19511e1dcd6aa888984b2726e7401 Author: Philippe Gerum r...@xenomai.org Date: Wed Mar 25 12:01:05 2015 +0100 demo/altency: set default affinity to CPU0 --- demo/alchemy/altency.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/demo/alchemy/altency.c b/demo/alchemy/altency.c index 8db2280..5365ab2 100644 --- a/demo/alchemy/altency.c +++ b/demo/alchemy/altency.c @@ -493,7 +493,7 @@ static void sigdebug(int sig, siginfo_t *si, void *context) int main(int argc, char *const *argv) { struct sigaction sa __attribute__((unused)); - int c, ret, sig, cpu = -1; + int c, ret, sig, cpu = 0; char task_name[32]; cpu_set_t cpus; sigset_t mask; @@ -667,16 +667,14 @@ int main(int argc, char *const *argv) return 0; } - if (cpu = 0) { - CPU_ZERO(cpus); - CPU_SET(cpu, cpus); - ret = rt_task_set_affinity(latency_task, cpus); - if (ret) { - fprintf(stderr, - altency: failed to set CPU affinity, code %d\n, - ret); - return 0; - } + CPU_ZERO(cpus); + CPU_SET(cpu, cpus); + ret = rt_task_set_affinity(latency_task, cpus); + if (ret) { + fprintf(stderr, + altency: failed to set CPU affinity, code %d\n, + ret); + return 0; } ret = rt_task_start(latency_task, latency, NULL); ___ Xenomai-git mailing list Xenomai-git@xenomai.org http://www.xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : copperplate/clockobj: drop useless name property
Module: xenomai-3 Branch: next Commit: 169fcb1dcca5640137efa4f6ac95bd870c365210 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=169fcb1dcca5640137efa4f6ac95bd870c365210 Author: Philippe Gerum r...@xenomai.org Date: Wed Mar 25 12:09:30 2015 +0100 copperplate/clockobj: drop useless name property --- config/apirev |2 +- include/copperplate/clockobj.h |3 +-- lib/alchemy/init.c |2 +- lib/copperplate/clockobj.c |3 +-- lib/psos/init.c|2 +- lib/vxworks/init.c |2 +- 6 files changed, 6 insertions(+), 8 deletions(-) diff --git a/config/apirev b/config/apirev index f599e28..b4de394 100644 --- a/config/apirev +++ b/config/apirev @@ -1 +1 @@ -10 +11 diff --git a/include/copperplate/clockobj.h b/include/copperplate/clockobj.h index 736463f..fdd4cae 100644 --- a/include/copperplate/clockobj.h +++ b/include/copperplate/clockobj.h @@ -58,7 +58,6 @@ struct clockobj { unsigned int resolution; unsigned int frequency; #endif - const char *name; /* __ref FIXME */ }; #define zero_time ((struct timespec){ .tv_sec = 0, .tv_nsec = 0 }) @@ -99,7 +98,7 @@ int clockobj_set_resolution(struct clockobj *clkobj, unsigned int resolution_ns); int clockobj_init(struct clockobj *clkobj, - const char *name, unsigned int resolution_ns); + unsigned int resolution_ns); int clockobj_destroy(struct clockobj *clkobj); diff --git a/lib/alchemy/init.c b/lib/alchemy/init.c index daaa757..14ec212 100644 --- a/lib/alchemy/init.c +++ b/lib/alchemy/init.c @@ -109,7 +109,7 @@ static int alchemy_init(void) syncluster_init(alchemy_heap_table, alchemy.heap); pvcluster_init(alchemy_alarm_table, alchemy.alarm); - ret = clockobj_init(alchemy_clock, alchemy, clock_resolution); + ret = clockobj_init(alchemy_clock, clock_resolution); if (ret) { warning(%s: failed to initialize Alchemy clock (res=%u ns), __FUNCTION__, clock_resolution); diff --git a/lib/copperplate/clockobj.c b/lib/copperplate/clockobj.c index b908fd7..21a420d 100644 --- a/lib/copperplate/clockobj.c +++ b/lib/copperplate/clockobj.c @@ -365,7 +365,7 @@ void clockobj_get_distance(struct clockobj *clkobj, } int clockobj_init(struct clockobj *clkobj, - const char *name, unsigned int resolution_ns) + unsigned int resolution_ns) { pthread_mutexattr_t mattr; struct timespec now; @@ -395,7 +395,6 @@ int clockobj_init(struct clockobj *clkobj, __RT(clock_gettime(CLOCK_COPPERPLATE, now)); timespec_sub(clkobj-offset, clkobj-epoch, now); - clkobj-name = name; return 0; } diff --git a/lib/psos/init.c b/lib/psos/init.c index ee29767..99521fa 100644 --- a/lib/psos/init.c +++ b/lib/psos/init.c @@ -117,7 +117,7 @@ static int psos_init(void) pvcluster_init(psos_pt_table, psos.pt); pvcluster_init(psos_rn_table, psos.rn); - ret = clockobj_init(psos_clock, psos, clock_resolution); + ret = clockobj_init(psos_clock, clock_resolution); if (ret) { warning(%s: failed to initialize pSOS clock (res=%u ns), __FUNCTION__, clock_resolution); diff --git a/lib/vxworks/init.c b/lib/vxworks/init.c index 17ab7e8..54b7cf9 100644 --- a/lib/vxworks/init.c +++ b/lib/vxworks/init.c @@ -90,7 +90,7 @@ static int vxworks_init(void) cluster_init(wind_task_table, vxworks.task); - ret = clockobj_init(wind_clock, vxworks, clock_resolution); + ret = clockobj_init(wind_clock, clock_resolution); if (ret) { warning(%s: failed to initialize VxWorks clock (res=%u ns), __FUNCTION__, clock_resolution); ___ Xenomai-git mailing list Xenomai-git@xenomai.org http://www.xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : testsuite/latency: set default affinity to CPU0
Module: xenomai-3 Branch: next Commit: f4882226c07f72284a14ac45427a6d47f7cfc433 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=f4882226c07f72284a14ac45427a6d47f7cfc433 Author: Philippe Gerum r...@xenomai.org Date: Wed Mar 25 12:01:17 2015 +0100 testsuite/latency: set default affinity to CPU0 --- testsuite/latency/latency.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/testsuite/latency/latency.c b/testsuite/latency/latency.c index 2b51b06..e3dadae 100644 --- a/testsuite/latency/latency.c +++ b/testsuite/latency/latency.c @@ -576,7 +576,7 @@ static void sigdebug(int sig, siginfo_t *si, void *context) int main(int argc, char *const *argv) { struct sigaction sa __attribute__((unused)); - int c, err, sig, cpu = -1; + int c, err, sig, cpu = 0; cpu_set_t cpus; sigset_t mask; @@ -792,17 +792,13 @@ int main(int argc, char *const *argv) return 0; } - if (cpu = 0) { - CPU_ZERO(cpus); - CPU_SET(cpu, cpus); - err = pthread_attr_setaffinity_np(tattr, sizeof(cpus), - cpus); - if (err) { - fprintf(stderr, - latency: failed to set CPU affinity, code %d\n, - err); + CPU_ZERO(cpus); + CPU_SET(cpu, cpus); + err = pthread_attr_setaffinity_np(tattr, sizeof(cpus), cpus); + if (err) { + fprintf(stderr, + latency: failed to set CPU affinity, code %d\n, err); return 0; - } } err = pthread_create(latency_task, tattr, latency, NULL); ___ Xenomai-git mailing list Xenomai-git@xenomai.org http://www.xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : testsuite/latenct: set default affinity to CPU0
Module: xenomai-3 Branch: next Commit: 492b3f667478326989d5799e3fed87067e5eb5ce URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=492b3f667478326989d5799e3fed87067e5eb5ce Author: Philippe Gerum r...@xenomai.org Date: Wed Mar 25 12:01:17 2015 +0100 testsuite/latenct: set default affinity to CPU0 --- testsuite/latency/latency.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/testsuite/latency/latency.c b/testsuite/latency/latency.c index 2b51b06..e3dadae 100644 --- a/testsuite/latency/latency.c +++ b/testsuite/latency/latency.c @@ -576,7 +576,7 @@ static void sigdebug(int sig, siginfo_t *si, void *context) int main(int argc, char *const *argv) { struct sigaction sa __attribute__((unused)); - int c, err, sig, cpu = -1; + int c, err, sig, cpu = 0; cpu_set_t cpus; sigset_t mask; @@ -792,17 +792,13 @@ int main(int argc, char *const *argv) return 0; } - if (cpu = 0) { - CPU_ZERO(cpus); - CPU_SET(cpu, cpus); - err = pthread_attr_setaffinity_np(tattr, sizeof(cpus), - cpus); - if (err) { - fprintf(stderr, - latency: failed to set CPU affinity, code %d\n, - err); + CPU_ZERO(cpus); + CPU_SET(cpu, cpus); + err = pthread_attr_setaffinity_np(tattr, sizeof(cpus), cpus); + if (err) { + fprintf(stderr, + latency: failed to set CPU affinity, code %d\n, err); return 0; - } } err = pthread_create(latency_task, tattr, latency, NULL); ___ Xenomai-git mailing list Xenomai-git@xenomai.org http://www.xenomai.org/mailman/listinfo/xenomai-git