[Xenomai-git] Jan Kiszka : common: Restore memory corruption warning for non-leak case
Module: xenomai-2.5
Branch: master
Commit: 0386ae9a4e8befc67088e247b65be534d34efbe1
URL:
http://git.xenomai.org/?p=xenomai-2.5.git;a=commit;h=0386ae9a4e8befc67088e247b65be534d34efbe1
Author: Jan Kiszka
Date: Thu Mar 11 11:32:37 2010 +0100
common: Restore memory corruption warning for non-leak case
We should still warn the user about potential corruptions in the
!HAVE___THREAD case. Also specify when the corruption can occur.
Signed-off-by: Jan Kiszka
---
src/skins/common/current.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/skins/common/current.c b/src/skins/common/current.c
index 5d418a4..4011cae 100644
--- a/src/skins/common/current.c
+++ b/src/skins/common/current.c
@@ -29,6 +29,11 @@ static inline unsigned long *create_current_mode(void)
static inline void free_current_mode(unsigned long *mode) { }
+#define XENO_MODE_LEAK_WARNING \
+ "Xenomai: WARNING, this version of Xenomai kernel is anterior to" \
+ " 2.5.2.\nIt can cause memory corruption on thread termination.\n" \
+ "Upgrade is recommended.\n"
+
#else /* !HAVE___THREAD */
pthread_key_t xeno_current_key;
@@ -55,8 +60,9 @@ static inline void free_current_mode(unsigned long *mode)
#define XENO_MODE_LEAK_WARNING \
"Xenomai: WARNING, this version of Xenomai kernel is anterior to" \
- " 2.5.2.\nIn order to avoid getting memory corruption, we leak 4" \
- " bytes per thread.\nUpgrade is recommended.\n"
+ " 2.5.2.\nIn order to avoid getting memory corruption on thread " \
+ "termination, we leak\nup to 8 bytes per thread. Upgrade is " \
+ "recommended.\n"
#endif /* !HAVE___THREAD */
@@ -71,7 +77,6 @@ static void cleanup_current_mode(void *key)
if (!err)
free_current_mode(mode);
-#ifdef XENO_MODE_LEAK_WARNING
else {
static int warned;
@@ -80,7 +85,6 @@ static void cleanup_current_mode(void *key)
fprintf(stderr, XENO_MODE_LEAK_WARNING);
}
}
-#endif /* XENO_MODE_LEAK_WARNING */
}
static void init_current_keys(void)
___
Xenomai-git mailing list
Xenomai-git@gna.org
https://mail.gna.org/listinfo/xenomai-git
[Xenomai-git] Jan Kiszka : common: Restore memory corruption warning for non-leak case
Module: xenomai-jki
Branch: for-upstream
Commit: 4ed43a5ff9959ec2fe2490d870546fcbf528b691
URL:
http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=4ed43a5ff9959ec2fe2490d870546fcbf528b691
Author: Jan Kiszka
Date: Thu Mar 11 11:32:37 2010 +0100
common: Restore memory corruption warning for non-leak case
We should still warn the user about potential corruptions in the
!HAVE___THREAD case. Also specify when the corruption can occur.
Signed-off-by: Jan Kiszka
---
src/skins/common/current.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/skins/common/current.c b/src/skins/common/current.c
index 5d418a4..4011cae 100644
--- a/src/skins/common/current.c
+++ b/src/skins/common/current.c
@@ -29,6 +29,11 @@ static inline unsigned long *create_current_mode(void)
static inline void free_current_mode(unsigned long *mode) { }
+#define XENO_MODE_LEAK_WARNING \
+ "Xenomai: WARNING, this version of Xenomai kernel is anterior to" \
+ " 2.5.2.\nIt can cause memory corruption on thread termination.\n" \
+ "Upgrade is recommended.\n"
+
#else /* !HAVE___THREAD */
pthread_key_t xeno_current_key;
@@ -55,8 +60,9 @@ static inline void free_current_mode(unsigned long *mode)
#define XENO_MODE_LEAK_WARNING \
"Xenomai: WARNING, this version of Xenomai kernel is anterior to" \
- " 2.5.2.\nIn order to avoid getting memory corruption, we leak 4" \
- " bytes per thread.\nUpgrade is recommended.\n"
+ " 2.5.2.\nIn order to avoid getting memory corruption on thread " \
+ "termination, we leak\nup to 8 bytes per thread. Upgrade is " \
+ "recommended.\n"
#endif /* !HAVE___THREAD */
@@ -71,7 +77,6 @@ static void cleanup_current_mode(void *key)
if (!err)
free_current_mode(mode);
-#ifdef XENO_MODE_LEAK_WARNING
else {
static int warned;
@@ -80,7 +85,6 @@ static void cleanup_current_mode(void *key)
fprintf(stderr, XENO_MODE_LEAK_WARNING);
}
}
-#endif /* XENO_MODE_LEAK_WARNING */
}
static void init_current_keys(void)
___
Xenomai-git mailing list
Xenomai-git@gna.org
https://mail.gna.org/listinfo/xenomai-git
